Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_dms_replication_task forcing removal of CloudWatchLogStream on every run #36598

Closed
mitchellharvey97 opened this issue Mar 26, 2024 · 4 comments · Fixed by #36936
Closed
Assignees
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@mitchellharvey97
Copy link

Terraform Core Version

1.5.7

AWS Provider Version

5.43

Affected Resource(s)

aws_dms_replication_task

Expected Behavior

Should be able to enable logging & not have to set the CloudWatchLogStream within the replication_task_settings object with 0 changes

Actual Behavior

Since upgrading to AWS Provider v5.42, terraform now wants to try and remove unset logging properties of CloudWatchLogGroup & CloudWatchLogStream. These are ReadOnly properties that cannot be modified or set so results in changes for every run
Screenshot 2024-03-27 at 8 40 55 am

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

A very trimmed down version of the config to give the general idea

resource "aws_dms_replication_task" "dms" { for_each = var.dms_replication_task migration_type = each.value.migration_type replication_instance_arn = aws_dms_replication_instance.dms.replication_instance_arn replication_task_id = each.key replication_task_settings = file("${path.module}/dms-task-settings.json") source_endpoint_arn = aws_dms_endpoint.dms_source_endpoint[each.value.source].endpoint_arn table_mappings = jsonencode(local.dms_table_mappings[each.key]) start_replication_task = true target_endpoint_arn = aws_dms_endpoint.dms_target_endpoint[each.value.target].endpoint_arn }

dms-task-settings.json

{ "Logging": { "EnableLogging": true, "EnableLogContext": false, "LogComponents": [ { "Severity": "LOGGER_SEVERITY_DEFAULT", "Id": "TRANSFORMATION" }, { "Severity": "LOGGER_SEVERITY_DEFAULT", "Id": "SOURCE_UNLOAD" } ] }, }

Steps to Reproduce

Create a DMS replication task with logging enabled and provide a replication_task_settings object that does not contain the redonly fields of CloudWatchLogGroup & CloudWatchLogStream

Debug Output

No response

Panic Output

No response

Important Factoids

Believe this has been reintroduced in 5.42 as I can set the version back to 5.41 without an issue. This was first resolved in 2021 under PR 13476

References

https://github.com/hashicorp/terraform-provider-aws/pull/13476/files

Would you like to implement a fix?

No

@mitchellharvey97 mitchellharvey97 added the bug Addresses a defect in current functionality. label Mar 26, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/dms Issues and PRs that pertain to the dms service. label Mar 26, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 26, 2024
@justinretzolk justinretzolk added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 2, 2024
@gdavison gdavison self-assigned this Apr 10, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.46.0 milestone Apr 17, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
3 participants