feat: Add s3_storage_options configuration block for aws_transfer_server

[acwwat]

Description

This PR adds the s3_storage_options configuration block to the aws_transfer_server resource.

IMPLEMENTATION CAVEAT

The s3_storage_options configuration block and its arguments are set as Optional and Computed, which means if the block is not provided Terraform will store the value read from the API into the state. Originally I avoided using Computed thinking that omitting the block from the update operation will remove the settings, however the UpdateServer API does NOT remove the settings or set DirectoryListingOptmization to DISABLED.

Consequently, if user set s3_storage_options and directory_listing_optimization to ENABLED, the only way to disable it is to explicitly set dierctory_listing_optimization to DISABLED. I am not sure if there are better ways to address this, in which case I am option to suggestions.

Relations

Closes #35851

References

Referred to CreateServer for specs and descriptions.

Output from Acceptance Testing

$ make testacc TESTS=TestAccTransfer_serial/Server PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server'  -timeout 360m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/Protocols
=== RUN   TestAccTransfer_serial/Server/DirectoryService
=== RUN   TestAccTransfer_serial/Server/Domain
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/APIGateway
=== RUN   TestAccTransfer_serial/Server/tags
=== RUN   TestAccTransfer_serial/Server/AuthenticationLoginBanners
=== RUN   TestAccTransfer_serial/Server/DataSourceAPIGateway
=== RUN   TestAccTransfer_serial/Server/ForceDestroy
=== RUN   TestAccTransfer_serial/Server/S3StorageOptions
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
=== RUN   TestAccTransfer_serial/Server/SecurityPolicyFIPS
=== RUN   TestAccTransfer_serial/Server/disappears
=== RUN   TestAccTransfer_serial/Server/VPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/StructuredLogDestinations
=== RUN   TestAccTransfer_serial/Server/APIGatewayForceDestroy
=== RUN   TestAccTransfer_serial/Server/HostKey
=== RUN   TestAccTransfer_serial/Server/LambdaFunction
=== RUN   TestAccTransfer_serial/Server/DataSourceServiceManaged
=== RUN   TestAccTransfer_serial/Server/ProtocolDetails
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic
=== RUN   TestAccTransfer_serial/Server/Workflow
=== RUN   TestAccTransfer_serial/Server/basic
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC
=== RUN   TestAccTransfer_serial/Server/VPC
=== RUN   TestAccTransfer_serial/Server/VPCEndpointID
=== RUN   TestAccTransfer_serial/Server/DataSourceBasic
--- PASS: TestAccTransfer_serial (11002.28s)
    --- PASS: TestAccTransfer_serial/Server (11002.28s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs (566.08s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDs (523.37s)
        --- PASS: TestAccTransfer_serial/Server/Protocols (882.59s)
        --- PASS: TestAccTransfer_serial/Server/DirectoryService (1066.42s)
        --- PASS: TestAccTransfer_serial/Server/Domain (178.87s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC (378.08s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs (402.10s)
        --- PASS: TestAccTransfer_serial/Server/APIGateway (385.58s)
        --- PASS: TestAccTransfer_serial/Server/tags (244.37s)
        --- PASS: TestAccTransfer_serial/Server/AuthenticationLoginBanners (176.52s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceAPIGateway (376.22s)
        --- PASS: TestAccTransfer_serial/Server/ForceDestroy (270.46s)
        --- PASS: TestAccTransfer_serial/Server/S3StorageOptions (200.34s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (299.42s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicyFIPS (225.90s)
        --- PASS: TestAccTransfer_serial/Server/disappears (205.29s)
        --- PASS: TestAccTransfer_serial/Server/VPCSecurityGroupIDs (257.52s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs (490.08s)
        --- PASS: TestAccTransfer_serial/Server/StructuredLogDestinations (328.49s)
        --- PASS: TestAccTransfer_serial/Server/APIGatewayForceDestroy (387.47s)
        --- PASS: TestAccTransfer_serial/Server/HostKey (176.68s)
        --- PASS: TestAccTransfer_serial/Server/LambdaFunction (348.20s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceServiceManaged (216.98s)
        --- PASS: TestAccTransfer_serial/Server/ProtocolDetails (226.69s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs (272.95s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic (292.13s)
        --- PASS: TestAccTransfer_serial/Server/Workflow (308.15s)
        --- PASS: TestAccTransfer_serial/Server/basic (241.12s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC (306.01s)
        --- PASS: TestAccTransfer_serial/Server/VPC (335.93s)
        --- PASS: TestAccTransfer_serial/Server/VPCEndpointID (214.36s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceBasic (217.93s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   11002.375s

$

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/basic\|TestAccTransfer_serial/Server/S3StorageOptions' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server/basic\|TestAccTransfer_serial/Server/S3StorageOptions -timeout 360m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/basic
=== RUN   TestAccTransfer_serial/Server/S3StorageOptions
--- PASS: TestAccTransfer_serial (402.04s)
    --- PASS: TestAccTransfer_serial/Server (402.04s)
        --- PASS: TestAccTransfer_serial/Server/basic (208.22s)
        --- PASS: TestAccTransfer_serial/Server/S3StorageOptions (193.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	413.321s

[ewbankkit]

@acwwat Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.