Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f-policy_data_source: adding support for attachment count #36759

Merged
merged 11 commits into from
Apr 17, 2024
Merged

f-policy_data_source: adding support for attachment count #36759

merged 11 commits into from
Apr 17, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 5, 2024 •
edited by jar-b
Loading

Description

Relations

Closes #36768

References

Output from Acceptance Testing

make testacc TESTS=TestAccIAMPolicyDataSource PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMPolicyDataSource'  -timeout 360m
=== RUN   TestAccIAMPolicyDataSource_arn
=== PAUSE TestAccIAMPolicyDataSource_arn
=== RUN   TestAccIAMPolicyDataSource_arnTags
=== PAUSE TestAccIAMPolicyDataSource_arnTags
=== RUN   TestAccIAMPolicyDataSource_name
=== PAUSE TestAccIAMPolicyDataSource_name
=== RUN   TestAccIAMPolicyDataSource_nameTags
=== PAUSE TestAccIAMPolicyDataSource_nameTags
=== RUN   TestAccIAMPolicyDataSource_nameAndPathPrefix
=== PAUSE TestAccIAMPolicyDataSource_nameAndPathPrefix
=== RUN   TestAccIAMPolicyDataSource_nameAndPathPrefixTags
=== PAUSE TestAccIAMPolicyDataSource_nameAndPathPrefixTags
=== RUN   TestAccIAMPolicyDataSource_nonExistent
=== PAUSE TestAccIAMPolicyDataSource_nonExistent
=== CONT  TestAccIAMPolicyDataSource_arn
=== CONT  TestAccIAMPolicyDataSource_nameAndPathPrefix
=== CONT  TestAccIAMPolicyDataSource_nameAndPathPrefixTags
=== CONT  TestAccIAMPolicyDataSource_nonExistent
=== CONT  TestAccIAMPolicyDataSource_name
=== CONT  TestAccIAMPolicyDataSource_arnTags
=== CONT  TestAccIAMPolicyDataSource_nameTags
--- PASS: TestAccIAMPolicyDataSource_nameAndPathPrefixTags (67.01s)
--- PASS: TestAccIAMPolicyDataSource_arnTags (67.94s)
--- PASS: TestAccIAMPolicyDataSource_nameAndPathPrefix (68.33s)
--- PASS: TestAccIAMPolicyDataSource_arn (68.49s)
--- PASS: TestAccIAMPolicyDataSource_nameTags (70.82s)
--- PASS: TestAccIAMPolicyDataSource_name (70.85s)
--- PASS: TestAccIAMPolicyDataSource_nonExistent (130.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	154.548s

...
make testacc TESTS=TestAccIAMPolicy PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMPolicy'  -timeout 360m
=== RUN   TestAccIAMPolicyAttachment_basic
=== PAUSE TestAccIAMPolicyAttachment_basic
=== RUN   TestAccIAMPolicyAttachment_disappears
=== PAUSE TestAccIAMPolicyAttachment_disappears
=== RUN   TestAccIAMPolicyAttachment_paginatedEntities
=== PAUSE TestAccIAMPolicyAttachment_paginatedEntities
=== RUN   TestAccIAMPolicyDataSource_arn
=== PAUSE TestAccIAMPolicyDataSource_arn
=== RUN   TestAccIAMPolicyDataSource_arnTags
=== PAUSE TestAccIAMPolicyDataSource_arnTags
=== RUN   TestAccIAMPolicyDataSource_name
=== PAUSE TestAccIAMPolicyDataSource_name
=== RUN   TestAccIAMPolicyDataSource_nameTags
=== PAUSE TestAccIAMPolicyDataSource_nameTags
=== RUN   TestAccIAMPolicyDataSource_nameAndPathPrefix
=== PAUSE TestAccIAMPolicyDataSource_nameAndPathPrefix
=== RUN   TestAccIAMPolicyDataSource_nameAndPathPrefixTags
=== PAUSE TestAccIAMPolicyDataSource_nameAndPathPrefixTags
=== RUN   TestAccIAMPolicyDataSource_nonExistent
=== PAUSE TestAccIAMPolicyDataSource_nonExistent
=== RUN   TestAccIAMPolicyDocumentDataSource_basic
=== PAUSE TestAccIAMPolicyDocumentDataSource_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_singleConditionValue
=== PAUSE TestAccIAMPolicyDocumentDataSource_singleConditionValue
=== RUN   TestAccIAMPolicyDocumentDataSource_multipleConditionKeys
=== PAUSE TestAccIAMPolicyDocumentDataSource_multipleConditionKeys
=== RUN   TestAccIAMPolicyDocumentDataSource_duplicateConditionKeys
=== PAUSE TestAccIAMPolicyDocumentDataSource_duplicateConditionKeys
=== RUN   TestAccIAMPolicyDocumentDataSource_conditionWithBoolValue
=== PAUSE TestAccIAMPolicyDocumentDataSource_conditionWithBoolValue
=== RUN   TestAccIAMPolicyDocumentDataSource_source
=== PAUSE TestAccIAMPolicyDocumentDataSource_source
=== RUN   TestAccIAMPolicyDocumentDataSource_sourceList
=== PAUSE TestAccIAMPolicyDocumentDataSource_sourceList
=== RUN   TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== PAUSE TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== RUN   TestAccIAMPolicyDocumentDataSource_sourceListConflicting
=== PAUSE TestAccIAMPolicyDocumentDataSource_sourceListConflicting
=== RUN   TestAccIAMPolicyDocumentDataSource_override
=== PAUSE TestAccIAMPolicyDocumentDataSource_override
=== RUN   TestAccIAMPolicyDocumentDataSource_overrideList
=== PAUSE TestAccIAMPolicyDocumentDataSource_overrideList
=== RUN   TestAccIAMPolicyDocumentDataSource_noStatementMerge
=== PAUSE TestAccIAMPolicyDocumentDataSource_noStatementMerge
=== RUN   TestAccIAMPolicyDocumentDataSource_noStatementOverride
=== PAUSE TestAccIAMPolicyDocumentDataSource_noStatementOverride
=== RUN   TestAccIAMPolicyDocumentDataSource_duplicateSid
=== PAUSE TestAccIAMPolicyDocumentDataSource_duplicateSid
=== RUN   TestAccIAMPolicyDocumentDataSource_sourcePolicyValidJSON
=== PAUSE TestAccIAMPolicyDocumentDataSource_sourcePolicyValidJSON
=== RUN   TestAccIAMPolicyDocumentDataSource_overridePolicyDocumentValidJSON
=== PAUSE TestAccIAMPolicyDocumentDataSource_overridePolicyDocumentValidJSON
=== RUN   TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_stringAndSlice
=== PAUSE TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_stringAndSlice
=== RUN   TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_multiplePrincipals
=== PAUSE TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_multiplePrincipals
=== RUN   TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_multiplePrincipalsGov
=== PAUSE TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_multiplePrincipalsGov
=== RUN   TestAccIAMPolicyDocumentDataSource_version20081017
=== PAUSE TestAccIAMPolicyDocumentDataSource_version20081017
=== RUN   TestAccIAMPolicy_tags
=== PAUSE TestAccIAMPolicy_tags
=== RUN   TestAccIAMPolicy_tags_null
=== PAUSE TestAccIAMPolicy_tags_null
=== RUN   TestAccIAMPolicy_tags_AddOnUpdate
=== PAUSE TestAccIAMPolicy_tags_AddOnUpdate
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMPolicy_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_overlapping
=== RUN   TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMPolicy_basic
=== PAUSE TestAccIAMPolicy_basic
=== RUN   TestAccIAMPolicy_description
=== PAUSE TestAccIAMPolicy_description
=== RUN   TestAccIAMPolicy_whitespace
=== PAUSE TestAccIAMPolicy_whitespace
=== RUN   TestAccIAMPolicy_disappears
=== PAUSE TestAccIAMPolicy_disappears
=== RUN   TestAccIAMPolicy_namePrefix
=== PAUSE TestAccIAMPolicy_namePrefix
=== RUN   TestAccIAMPolicy_path
=== PAUSE TestAccIAMPolicy_path
=== RUN   TestAccIAMPolicy_policy
=== PAUSE TestAccIAMPolicy_policy
=== RUN   TestAccIAMPolicy_diffs
=== PAUSE TestAccIAMPolicy_diffs
=== RUN   TestAccIAMPolicy_policyDuplicateKeys
=== PAUSE TestAccIAMPolicy_policyDuplicateKeys
=== CONT  TestAccIAMPolicyAttachment_basic
=== CONT  TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_multiplePrincipals
=== CONT  TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== CONT  TestAccIAMPolicy_diffs
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccIAMPolicy_tags_AddOnUpdate
=== CONT  TestAccIAMPolicy_disappears
=== CONT  TestAccIAMPolicy_policyDuplicateKeys
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== CONT  TestAccIAMPolicy_whitespace
=== CONT  TestAccIAMPolicy_description
=== CONT  TestAccIAMPolicy_basic
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccIAMPolicy_policy
=== CONT  TestAccIAMPolicyDocumentDataSource_conditionWithBoolValue
=== CONT  TestAccIAMPolicy_namePrefix
=== CONT  TestAccIAMPolicy_path
=== CONT  TestAccIAMPolicy_tags_null
--- PASS: TestAccIAMPolicy_policyDuplicateKeys (19.45s)
=== CONT  TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_stringAndSlice
--- PASS: TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_multiplePrincipals (188.69s)
=== CONT  TestAccIAMPolicyDocumentDataSource_overridePolicyDocumentValidJSON
--- PASS: TestAccIAMPolicyDocumentDataSource_conditionWithBoolValue (189.26s)
=== CONT  TestAccIAMPolicyDocumentDataSource_sourcePolicyValidJSON
--- PASS: TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_stringAndSlice (197.02s)
=== CONT  TestAccIAMPolicyDocumentDataSource_duplicateSid
--- PASS: TestAccIAMPolicy_disappears (243.31s)
=== CONT  TestAccIAMPolicyDocumentDataSource_noStatementOverride
--- PASS: TestAccIAMPolicy_description (278.65s)
=== CONT  TestAccIAMPolicyDocumentDataSource_noStatementMerge
--- PASS: TestAccIAMPolicy_namePrefix (279.06s)
=== CONT  TestAccIAMPolicyDocumentDataSource_overrideList
--- PASS: TestAccIAMPolicy_path (279.21s)
=== CONT  TestAccIAMPolicyDocumentDataSource_override
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag (279.78s)
=== CONT  TestAccIAMPolicyDocumentDataSource_sourceListConflicting
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (279.78s)
=== CONT  TestAccIAMPolicyDocumentDataSource_sourceConflicting
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag (280.11s)
=== CONT  TestAccIAMPolicyDocumentDataSource_sourceList
--- PASS: TestAccIAMPolicy_basic (280.15s)
=== CONT  TestAccIAMPolicyDocumentDataSource_source
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceListConflicting (17.20s)
=== CONT  TestAccIAMPolicyDocumentDataSource_version20081017
--- PASS: TestAccIAMPolicy_tags_null (346.81s)
=== CONT  TestAccIAMPolicy_tags
--- PASS: TestAccIAMPolicyAttachment_basic (364.79s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
--- PASS: TestAccIAMPolicyDocumentDataSource_sourcePolicyValidJSON (186.37s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccIAMPolicyDocumentDataSource_noStatementOverride (148.06s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_overlapping
--- PASS: TestAccIAMPolicyDocumentDataSource_duplicateSid (175.90s)
=== CONT  TestAccIAMPolicyDataSource_nameAndPathPrefix
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly (395.13s)
=== CONT  TestAccIAMPolicyDocumentDataSource_duplicateConditionKeys
--- PASS: TestAccIAMPolicy_tags_AddOnUpdate (410.21s)
=== CONT  TestAccIAMPolicyDocumentDataSource_multipleConditionKeys
--- PASS: TestAccIAMPolicyDocumentDataSource_overrideList (144.65s)
=== CONT  TestAccIAMPolicyDocumentDataSource_singleConditionValue
--- PASS: TestAccIAMPolicyDocumentDataSource_override (144.62s)
--- PASS: TestAccIAMPolicyDocumentDataSource_noStatementMerge (145.20s)
=== CONT  TestAccIAMPolicyDataSource_nonExistent
=== CONT  TestAccIAMPolicyDocumentDataSource_basic
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceList (144.05s)
=== CONT  TestAccIAMPolicyDataSource_nameAndPathPrefixTags
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceConflicting (144.72s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_providerOnly
--- PASS: TestAccIAMPolicy_policy (428.84s)
=== CONT  TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_multiplePrincipalsGov
    policy_document_data_source_test.go:390: skipping tests; current partition (aws) does not equal aws-us-gov
--- SKIP: TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_multiplePrincipalsGov (0.00s)
=== CONT  TestAccIAMPolicyDataSource_arnTags
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnCreate (457.30s)
=== CONT  TestAccIAMPolicyDataSource_nameTags
--- PASS: TestAccIAMPolicyDocumentDataSource_overridePolicyDocumentValidJSON (282.01s)
=== CONT  TestAccIAMPolicyDataSource_name
--- PASS: TestAccIAMPolicy_whitespace (489.11s)
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccIAMPolicyDocumentDataSource_version20081017 (216.44s)
=== CONT  TestAccIAMPolicyAttachment_paginatedEntities
--- PASS: TestAccIAMPolicyDocumentDataSource_duplicateConditionKeys (133.50s)
=== CONT  TestAccIAMPolicyDataSource_arn
--- PASS: TestAccIAMPolicyDocumentDataSource_source (248.53s)
=== CONT  TestAccIAMPolicyAttachment_disappears
--- PASS: TestAccIAMPolicyDocumentDataSource_multipleConditionKeys (130.19s)
--- PASS: TestAccIAMPolicyDataSource_nameAndPathPrefix (150.74s)
--- PASS: TestAccIAMPolicyDocumentDataSource_basic (128.38s)
--- PASS: TestAccIAMPolicyDocumentDataSource_singleConditionValue (131.58s)
--- PASS: TestAccIAMPolicyDataSource_nonExistent (140.24s)
--- PASS: TestAccIAMPolicyDataSource_arnTags (138.11s)
--- PASS: TestAccIAMPolicyDataSource_nameAndPathPrefixTags (142.93s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add (567.40s)
--- PASS: TestAccIAMPolicyDataSource_nameTags (127.61s)
--- PASS: TestAccIAMPolicyDataSource_name (126.35s)
--- PASS: TestAccIAMPolicyDataSource_arn (89.85s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly (247.33s)
--- PASS: TestAccIAMPolicyAttachment_disappears (96.18s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace (167.00s)
--- PASS: TestAccIAMPolicyAttachment_paginatedEntities (146.56s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nonOverlapping (314.21s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_overlapping (292.20s)
--- PASS: TestAccIAMPolicy_tags (358.73s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_providerOnly (287.99s)
--- PASS: TestAccIAMPolicy_diffs (722.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	738.391s

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. labels Apr 5, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 5, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 8, 2024
jar-b
jar-b approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=iam TESTS="TestAccIAMPolicy_|TestAccIAMPolicyDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMPolicy_|TestAccIAMPolicyDataSource_'  -timeout 360m

--- PASS: TestAccIAMPolicyDataSource_nameAndPathPrefix (28.57s)
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccIAMPolicyDataSource_arn (29.21s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag (29.60s)
=== CONT  TestAccIAMPolicy_policyDuplicateKeys
--- PASS: TestAccIAMPolicy_disappears (31.60s)
=== CONT  TestAccIAMPolicyDataSource_nameAndPathPrefixTags
--- PASS: TestAccIAMPolicy_policyDuplicateKeys (2.62s)
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag (32.70s)
=== CONT  TestAccIAMPolicy_diffs
--- PASS: TestAccIAMPolicy_path (35.66s)
=== CONT  TestAccIAMPolicy_tags_AddOnUpdate
--- PASS: TestAccIAMPolicy_description (35.85s)
=== CONT  TestAccIAMPolicyDataSource_name
--- PASS: TestAccIAMPolicy_namePrefix (36.07s)
=== CONT  TestAccIAMPolicyDataSource_arnTags
--- PASS: TestAccIAMPolicy_basic (37.81s)
=== CONT  TestAccIAMPolicyDataSource_nameTags
--- PASS: TestAccIAMPolicy_tags_null (45.37s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly (51.16s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly (55.83s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace (56.29s)
--- PASS: TestAccIAMPolicy_policy (56.48s)
--- PASS: TestAccIAMPolicyDataSource_nameAndPathPrefixTags (26.21s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (29.58s)
--- PASS: TestAccIAMPolicyDataSource_arnTags (24.33s)
--- PASS: TestAccIAMPolicyDataSource_name (26.92s)
--- PASS: TestAccIAMPolicy_whitespace (63.60s)
--- PASS: TestAccIAMPolicyDataSource_nameTags (26.24s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nonOverlapping (68.67s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_overlapping (70.66s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnCreate (43.73s)
--- PASS: TestAccIAMPolicy_tags_AddOnUpdate (36.70s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_providerOnly (77.45s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add (46.94s)
--- PASS: TestAccIAMPolicy_tags (81.17s)
--- PASS: TestAccIAMPolicy_diffs (76.54s)
--- PASS: TestAccIAMPolicyDataSource_nonExistent (124.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        129.845s

@jar-b
Copy link
Member

jar-b commented Apr 16, 2024

Thanks for your contribution, @nikhil-goenka! 🚀

@jar-b jar-b merged commit 6d992fd into hashicorp:main Apr 17, 2024
52 checks passed
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 17, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
@nikhil-goenka nikhil-goenka deleted the f-policy_data_source-attachment_count branch June 16, 2024 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.46.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: policy_data_source add attachment count as output
3 participants
@nikhil-goenka @jar-b @justinretzolk