Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f-aws_fsx_openzfs_file_system-add endpoint IP as output #36767

Merged
merged 5 commits into from
Apr 16, 2024
Merged

f-aws_fsx_openzfs_file_system-add endpoint IP as output #36767

merged 5 commits into from
Apr 16, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 6, 2024 •
edited
Loading

Description

Relations

Closes #36428

References

Output from Acceptance Testing

% make testacc TESTS=TestAccFSxOpenZFSFileSystem_basic PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_basic'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_basic
=== PAUSE TestAccFSxOpenZFSFileSystem_basic
=== CONT  TestAccFSxOpenZFSFileSystem_basic
--- PASS: TestAccFSxOpenZFSFileSystem_basic (647.44s)               
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	663.500s
% make testacc TESTS=TestAccFSxOpenZFSFileSystem_copyTags PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_copyTags'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_copyTags
=== PAUSE TestAccFSxOpenZFSFileSystem_copyTags
=== CONT  TestAccFSxOpenZFSFileSystem_copyTags
--- PASS: TestAccFSxOpenZFSFileSystem_copyTags (530.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	598.706s
% make testacc TESTS=TestAccFSxOpenZFSFileSystem_rootVolume PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_rootVolume'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_rootVolume
=== PAUSE TestAccFSxOpenZFSFileSystem_rootVolume
=== CONT  TestAccFSxOpenZFSFileSystem_rootVolume
--- PASS: TestAccFSxOpenZFSFileSystem_rootVolume (1314.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1340.675s
% make testacc TESTS=TestAccFSxOpenZFSFileSystem_routeTableIDs PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_routeTableIDs'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_routeTableIDs
=== PAUSE TestAccFSxOpenZFSFileSystem_routeTableIDs
=== CONT  TestAccFSxOpenZFSFileSystem_routeTableIDs
--- PASS: TestAccFSxOpenZFSFileSystem_routeTableIDs (1247.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1278.814s
--- PASS: TestAccFSxOpenZFSFileSystem_tags (619.36s)
--- PASS: TestAccFSxOpenZFSFileSystem_disappears (636.64s)
--- PASS: TestAccFSxOpenZFSFileSystem_storageType (646.12s)
--- PASS: TestAccFSxOpenZFSFileSystem_weeklyMaintenanceStartTime (682.46s)
--- PASS: TestAccFSxOpenZFSFileSystem_storageCapacity (744.88s)
--- PASS: TestAccFSxOpenZFSFileSystem_securityGroupIDs (1046.78s)
--- PASS: TestAccFSxOpenZFSFileSystem_throughput (1288.78s)
--- PASS: TestAccFSxOpenZFSFileSystem_throughputCapacity (1288.79s)
% make testacc TESTS=TestAccFSxOpenZFSFileSystem_multiAZ PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_multiAZ'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_multiAZ
=== PAUSE TestAccFSxOpenZFSFileSystem_multiAZ
=== CONT  TestAccFSxOpenZFSFileSystem_multiAZ
--- PASS: TestAccFSxOpenZFSFileSystem_multiAZ (1011.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1032.237s
% make testacc TESTS=TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays
=== CONT  TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays
--- PASS: TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays (634.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	680.641s
% make testacc TESTS=TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime (575.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	605.894s
% make testacc TESTS=TestAccFSxOpenZFSFileSystem_diskIops PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_diskIops'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_diskIops
=== PAUSE TestAccFSxOpenZFSFileSystem_diskIops
=== CONT  TestAccFSxOpenZFSFileSystem_diskIops
--- PASS: TestAccFSxOpenZFSFileSystem_diskIops (676.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	701.698s
% make testacc TESTS=TestAccFSxOpenZFSFileSystem_deploymentType PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_deploymentType'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_deploymentType
=== PAUSE TestAccFSxOpenZFSFileSystem_deploymentType
=== CONT  TestAccFSxOpenZFSFileSystem_deploymentType
--- PASS: TestAccFSxOpenZFSFileSystem_deploymentType (933.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	948.649s
% make testacc TESTS=TestAccFSxOpenZFSFileSystem_kmsKeyID PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_kmsKeyID'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_kmsKeyID
=== PAUSE TestAccFSxOpenZFSFileSystem_kmsKeyID
=== CONT  TestAccFSxOpenZFSFileSystem_kmsKeyID
--- PASS: TestAccFSxOpenZFSFileSystem_kmsKeyID (589.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	603.655s
...

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. labels Apr 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 6, 2024
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Apr 6, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 8, 2024
jar-b
jar-b approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=fsx TESTS=TestAccFSxOpenZFSFileSystem_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenZFSFileSystem_'  -timeout 360m

--- PASS: TestAccFSxOpenZFSFileSystem_tags (513.57s)
--- PASS: TestAccFSxOpenZFSFileSystem_weeklyMaintenanceStartTime (518.75s)
--- PASS: TestAccFSxOpenZFSFileSystem_storageType (553.35s)
--- PASS: TestAccFSxOpenZFSFileSystem_kmsKeyID (573.91s)
--- PASS: TestAccFSxOpenZFSFileSystem_dailyAutomaticBackupStartTime (578.67s)
--- PASS: TestAccFSxOpenZFSFileSystem_copyTags (579.89s)
--- PASS: TestAccFSxOpenZFSFileSystem_storageCapacity (598.38s)
--- PASS: TestAccFSxOpenZFSFileSystem_disappears (601.81s)
--- PASS: TestAccFSxOpenZFSFileSystem_automaticBackupRetentionDays (641.00s)
--- PASS: TestAccFSxOpenZFSFileSystem_basic (695.86s)
--- PASS: TestAccFSxOpenZFSFileSystem_diskIops (700.22s)
--- PASS: TestAccFSxOpenZFSFileSystem_securityGroupIDs (904.77s)
--- PASS: TestAccFSxOpenZFSFileSystem_deploymentType (971.19s)
--- PASS: TestAccFSxOpenZFSFileSystem_multiAZ (1005.03s)
--- PASS: TestAccFSxOpenZFSFileSystem_routeTableIDs (1054.04s)
--- PASS: TestAccFSxOpenZFSFileSystem_throughputCapacity (1131.97s)
--- PASS: TestAccFSxOpenZFSFileSystem_throughput (1132.41s)
--- PASS: TestAccFSxOpenZFSFileSystem_rootVolume (1279.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        1285.433s

@jar-b
Copy link
Member

jar-b commented Apr 16, 2024

Thanks for your contribution, @nikhil-goenka! 🎸

@jar-b jar-b merged commit 558f3a6 into hashicorp:main Apr 16, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 16, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
@nikhil-goenka nikhil-goenka deleted the f-aws_fsx_openzfs_file_system-endpoint-ip-output branch June 16, 2024 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.46.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: [FSx] Return endpoint IP address when aws_fsx_openzfs_file_system is created
3 participants
@nikhil-goenka @jar-b @justinretzolk