-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
costexplorer: Migrate to AWS SDK v2 #36773
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
d4287b3
to
3f5e993
Compare
% make testacc TESTARGS='-run=TestAccCEAnomalyMonitor_' PKG=ce ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCEAnomalyMonitor_ -timeout 360m === RUN TestAccCEAnomalyMonitor_basic === PAUSE TestAccCEAnomalyMonitor_basic === RUN TestAccCEAnomalyMonitor_disappears === PAUSE TestAccCEAnomalyMonitor_disappears === RUN TestAccCEAnomalyMonitor_update === PAUSE TestAccCEAnomalyMonitor_update === RUN TestAccCEAnomalyMonitor_tags === PAUSE TestAccCEAnomalyMonitor_tags === RUN TestAccCEAnomalyMonitor_Dimensional === PAUSE TestAccCEAnomalyMonitor_Dimensional === CONT TestAccCEAnomalyMonitor_basic === CONT TestAccCEAnomalyMonitor_tags --- PASS: TestAccCEAnomalyMonitor_basic (20.43s) === CONT TestAccCEAnomalyMonitor_update --- PASS: TestAccCEAnomalyMonitor_tags (44.13s) === CONT TestAccCEAnomalyMonitor_disappears --- PASS: TestAccCEAnomalyMonitor_update (34.78s) === CONT TestAccCEAnomalyMonitor_Dimensional --- PASS: TestAccCEAnomalyMonitor_disappears (21.08s) --- PASS: TestAccCEAnomalyMonitor_Dimensional (19.70s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 86.024s
% make testacc TESTARGS='-run=TestAccCEAnomalySubscription_' PKG=ce ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCEAnomalySubscription_ -timeout 360m === RUN TestAccCEAnomalySubscription_basic === PAUSE TestAccCEAnomalySubscription_basic === RUN TestAccCEAnomalySubscription_disappears === PAUSE TestAccCEAnomalySubscription_disappears === RUN TestAccCEAnomalySubscription_Frequency === PAUSE TestAccCEAnomalySubscription_Frequency === RUN TestAccCEAnomalySubscription_MonitorARNList === PAUSE TestAccCEAnomalySubscription_MonitorARNList === RUN TestAccCEAnomalySubscription_Subscriber === PAUSE TestAccCEAnomalySubscription_Subscriber === RUN TestAccCEAnomalySubscription_Tags === PAUSE TestAccCEAnomalySubscription_Tags === CONT TestAccCEAnomalySubscription_basic === CONT TestAccCEAnomalySubscription_MonitorARNList --- PASS: TestAccCEAnomalySubscription_basic (20.86s) === CONT TestAccCEAnomalySubscription_Frequency --- PASS: TestAccCEAnomalySubscription_MonitorARNList (33.15s) === CONT TestAccCEAnomalySubscription_Tags --- PASS: TestAccCEAnomalySubscription_Frequency (31.09s) === CONT TestAccCEAnomalySubscription_disappears --- PASS: TestAccCEAnomalySubscription_disappears (16.26s) === CONT TestAccCEAnomalySubscription_Subscriber --- PASS: TestAccCEAnomalySubscription_Tags (42.98s) --- PASS: TestAccCEAnomalySubscription_Subscriber (60.94s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 139.298s
% make testacc TESTARGS='-run=TestAccCECostAllocationTag_' PKG=ce ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCECostAllocationTag_ -timeout 360m === RUN TestAccCECostAllocationTag_basic === PAUSE TestAccCECostAllocationTag_basic === RUN TestAccCECostAllocationTag_disappears === PAUSE TestAccCECostAllocationTag_disappears === CONT TestAccCECostAllocationTag_basic === CONT TestAccCECostAllocationTag_disappears --- PASS: TestAccCECostAllocationTag_disappears (18.20s) --- PASS: TestAccCECostAllocationTag_basic (41.58s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 52.926s
% make testacc TESTARGS='-run=TestAccCETagsDataSource_' PKG=ce ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCETagsDataSource_ -timeout 360m === RUN TestAccCETagsDataSource_basic === PAUSE TestAccCETagsDataSource_basic === RUN TestAccCETagsDataSource_filter === PAUSE TestAccCETagsDataSource_filter === CONT TestAccCETagsDataSource_basic === CONT TestAccCETagsDataSource_filter --- PASS: TestAccCETagsDataSource_basic (17.50s) --- PASS: TestAccCETagsDataSource_filter (18.40s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 29.918s
% make testacc TESTARGS='-run=TestAccCECostCategory_' PKG=ce ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCECostCategory_ -timeout 360m === RUN TestAccCECostCategory_basic === PAUSE TestAccCECostCategory_basic === RUN TestAccCECostCategory_effectiveStart === PAUSE TestAccCECostCategory_effectiveStart === RUN TestAccCECostCategory_disappears === PAUSE TestAccCECostCategory_disappears === RUN TestAccCECostCategory_complete === PAUSE TestAccCECostCategory_complete === RUN TestAccCECostCategory_splitCharge === PAUSE TestAccCECostCategory_splitCharge === RUN TestAccCECostCategory_tags === PAUSE TestAccCECostCategory_tags === CONT TestAccCECostCategory_basic === CONT TestAccCECostCategory_complete --- PASS: TestAccCECostCategory_basic (21.54s) === CONT TestAccCECostCategory_tags --- PASS: TestAccCECostCategory_complete (36.00s) === CONT TestAccCECostCategory_disappears --- PASS: TestAccCECostCategory_disappears (18.13s) === CONT TestAccCECostCategory_splitCharge --- PASS: TestAccCECostCategory_tags (47.34s) --- PASS: TestAccCECostCategory_effectiveStart (30.95s) --- PASS: TestAccCECostCategory_splitCharge (35.83s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 101.564s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCEAnomalyMonitor_' PKG=ce ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCEAnomalyMonitor_ -timeout 360m
=== RUN TestAccCEAnomalyMonitor_basic
=== PAUSE TestAccCEAnomalyMonitor_basic
=== RUN TestAccCEAnomalyMonitor_disappears
=== PAUSE TestAccCEAnomalyMonitor_disappears
=== RUN TestAccCEAnomalyMonitor_update
=== PAUSE TestAccCEAnomalyMonitor_update
=== RUN TestAccCEAnomalyMonitor_tags
=== PAUSE TestAccCEAnomalyMonitor_tags
=== RUN TestAccCEAnomalyMonitor_Dimensional
=== PAUSE TestAccCEAnomalyMonitor_Dimensional
=== CONT TestAccCEAnomalyMonitor_basic
=== CONT TestAccCEAnomalyMonitor_tags
--- PASS: TestAccCEAnomalyMonitor_basic (20.43s)
=== CONT TestAccCEAnomalyMonitor_update
--- PASS: TestAccCEAnomalyMonitor_tags (44.13s)
=== CONT TestAccCEAnomalyMonitor_disappears
--- PASS: TestAccCEAnomalyMonitor_update (34.78s)
=== CONT TestAccCEAnomalyMonitor_Dimensional
--- PASS: TestAccCEAnomalyMonitor_disappears (21.08s)
--- PASS: TestAccCEAnomalyMonitor_Dimensional (19.70s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 86.024s
% make testacc TESTARGS='-run=TestAccCEAnomalySubscription_' PKG=ce ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCEAnomalySubscription_ -timeout 360m
=== RUN TestAccCEAnomalySubscription_basic
=== PAUSE TestAccCEAnomalySubscription_basic
=== RUN TestAccCEAnomalySubscription_disappears
=== PAUSE TestAccCEAnomalySubscription_disappears
=== RUN TestAccCEAnomalySubscription_Frequency
=== PAUSE TestAccCEAnomalySubscription_Frequency
=== RUN TestAccCEAnomalySubscription_MonitorARNList
=== PAUSE TestAccCEAnomalySubscription_MonitorARNList
=== RUN TestAccCEAnomalySubscription_Subscriber
=== PAUSE TestAccCEAnomalySubscription_Subscriber
=== RUN TestAccCEAnomalySubscription_Tags
=== PAUSE TestAccCEAnomalySubscription_Tags
=== CONT TestAccCEAnomalySubscription_basic
=== CONT TestAccCEAnomalySubscription_MonitorARNList
--- PASS: TestAccCEAnomalySubscription_basic (20.86s)
=== CONT TestAccCEAnomalySubscription_Frequency
--- PASS: TestAccCEAnomalySubscription_MonitorARNList (33.15s)
=== CONT TestAccCEAnomalySubscription_Tags
--- PASS: TestAccCEAnomalySubscription_Frequency (31.09s)
=== CONT TestAccCEAnomalySubscription_disappears
--- PASS: TestAccCEAnomalySubscription_disappears (16.26s)
=== CONT TestAccCEAnomalySubscription_Subscriber
--- PASS: TestAccCEAnomalySubscription_Tags (42.98s)
--- PASS: TestAccCEAnomalySubscription_Subscriber (60.94s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 139.298s
% make testacc TESTARGS='-run=TestAccCECostAllocationTag_' PKG=ce ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCECostAllocationTag_ -timeout 360m
=== RUN TestAccCECostAllocationTag_basic
=== PAUSE TestAccCECostAllocationTag_basic
=== RUN TestAccCECostAllocationTag_disappears
=== PAUSE TestAccCECostAllocationTag_disappears
=== CONT TestAccCECostAllocationTag_basic
=== CONT TestAccCECostAllocationTag_disappears
--- PASS: TestAccCECostAllocationTag_disappears (18.20s)
--- PASS: TestAccCECostAllocationTag_basic (41.58s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 52.926s
% make testacc TESTARGS='-run=TestAccCETagsDataSource_' PKG=ce ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCETagsDataSource_ -timeout 360m
=== RUN TestAccCETagsDataSource_basic
=== PAUSE TestAccCETagsDataSource_basic
=== RUN TestAccCETagsDataSource_filter
=== PAUSE TestAccCETagsDataSource_filter
=== CONT TestAccCETagsDataSource_basic
=== CONT TestAccCETagsDataSource_filter
--- PASS: TestAccCETagsDataSource_basic (17.50s)
--- PASS: TestAccCETagsDataSource_filter (18.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 29.918s
% make testacc TESTARGS='-run=TestAccCECostCategory_' PKG=ce ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCECostCategory_ -timeout 360m
=== RUN TestAccCECostCategory_basic
=== PAUSE TestAccCECostCategory_basic
=== RUN TestAccCECostCategory_effectiveStart
=== PAUSE TestAccCECostCategory_effectiveStart
=== RUN TestAccCECostCategory_disappears
=== PAUSE TestAccCECostCategory_disappears
=== RUN TestAccCECostCategory_complete
=== PAUSE TestAccCECostCategory_complete
=== RUN TestAccCECostCategory_splitCharge
=== PAUSE TestAccCECostCategory_splitCharge
=== RUN TestAccCECostCategory_tags
=== PAUSE TestAccCECostCategory_tags
=== CONT TestAccCECostCategory_basic
=== CONT TestAccCECostCategory_complete
--- PASS: TestAccCECostCategory_basic (21.54s)
=== CONT TestAccCECostCategory_tags
--- PASS: TestAccCECostCategory_complete (36.00s)
=== CONT TestAccCECostCategory_disappears
--- PASS: TestAccCECostCategory_disappears (18.13s)
=== CONT TestAccCECostCategory_splitCharge
--- PASS: TestAccCECostCategory_tags (47.34s)
--- PASS: TestAccCECostCategory_effectiveStart (30.95s)
--- PASS: TestAccCECostCategory_splitCharge (35.83s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 101.564s
% make testacc TESTARGS='-run=TestAccCECostCategoryDataSource_' PKG=ce ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCECostCategoryDataSource_ -timeout 360m
=== RUN TestAccCECostCategoryDataSource_basic
=== PAUSE TestAccCECostCategoryDataSource_basic
=== CONT TestAccCECostCategoryDataSource_basic
--- PASS: TestAccCECostCategoryDataSource_basic (15.87s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 26.289s
@mattburgess Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36123
References
Output from Acceptance Testing