-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/datasync_location_object_storage: fix issue when updating agent_arns
#36819
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=datasync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/datasync/... -v -count 1 -parallel 20 -timeout 360m
--- PASS: TestAccDataSyncLocationS3_storageClass (22.94s)
=== CONT TestAccDataSyncLocationObjectStorage_update
--- PASS: TestAccDataSyncLocationS3_disappears (28.03s)
=== CONT TestAccDataSyncTask_DefaultSyncOptions_atimeMtime
--- PASS: TestAccDataSyncLocationS3_basic (30.37s)
=== CONT TestAccDataSyncLocationObjectStorage_basic
--- PASS: TestAccDataSyncLocationS3_tags (55.03s)
=== CONT TestAccDataSyncLocationNFS_tags
--- PASS: TestAccDataSyncLocationObjectStorage_serverCertificate (103.21s)
=== CONT TestAccDataSyncLocationNFS_subdirectory
--- PASS: TestAccDataSyncLocationSMB_basic (117.33s)
=== CONT TestAccDataSyncLocationNFS_AgentARNs_multiple
--- PASS: TestAccDataSyncLocationObjectStorage_disappears (128.41s)
=== CONT TestAccDataSyncLocationNFS_disappears
--- PASS: TestAccDataSyncLocationSMB_disappears (128.62s)
=== CONT TestAccDataSyncLocationNFS_mountOptions
--- PASS: TestAccDataSyncLocationObjectStorage_tags (153.47s)
=== CONT TestAccDataSyncLocationNFS_basic
--- PASS: TestAccDataSyncLocationObjectStorage_basic (123.95s)
=== CONT TestAccDataSyncLocationHDFS_kerberos
--- PASS: TestAccDataSyncTask_basic (162.15s)
=== CONT TestAccDataSyncLocationHDFS_tags
--- PASS: TestAccDataSyncTask_cloudWatchLogGroupARN (177.12s)
=== CONT TestAccDataSyncLocationHDFS_disappears
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_atimeMtime (163.68s)
=== CONT TestAccDataSyncLocationHDFS_basic
--- PASS: TestAccDataSyncTask_disappears (197.72s)
=== CONT TestAccDataSyncLocationFSxWindowsFileSystem_tags
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_taskQueueing (200.22s)
=== CONT TestAccDataSyncLocationFSxWindowsFileSystem_subdirectory
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_logLevel (202.15s)
=== CONT TestAccDataSyncLocationFSxWindowsFileSystem_disappears
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles (206.38s) 10:14:25 [111/433]
=== CONT TestAccDataSyncTask_taskReportConfig
--- PASS: TestAccDataSyncLocationObjectStorage_update (184.17s)
=== CONT TestAccDataSyncLocationFSxWindowsFileSystem_basic
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_gid (217.59s)
=== CONT TestAccDataSyncLocationFSxOpenZFSFileSystem_tags
--- PASS: TestAccDataSyncLocationNFS_subdirectory (118.93s)
=== CONT TestAccDataSyncLocationFSxOpenZFSFileSystem_subdirectory
--- PASS: TestAccDataSyncLocationNFS_tags (178.38s)
=== CONT TestAccDataSyncLocationFSxOpenZFSFileSystem_disappears
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_objectTags (235.09s)
=== CONT TestAccDataSyncLocationFSxOpenZFSFileSystem_basic
--- PASS: TestAccDataSyncTask_schedule (245.28s)
=== CONT TestAccDataSyncLocationSMB_tags
--- PASS: TestAccDataSyncLocationNFS_disappears (125.08s)
=== CONT TestAccDataSyncLocationEFS_accessPointARN
--- PASS: TestAccDataSyncTask_tags (260.24s)
=== CONT TestAccDataSyncAgent_vpcEndpointID
--- PASS: TestAccDataSyncLocationNFS_mountOptions (133.17s)
=== CONT TestAccDataSyncLocationFSxONTAPFileSystem_subdirectory
--- PASS: TestAccDataSyncLocationNFS_basic (122.95s)
=== CONT TestAccDataSyncLocationEFS_basic
--- PASS: TestAccDataSyncLocationHDFS_kerberos (127.36s)
=== CONT TestAccDataSyncLocationFSxONTAPFileSystem_smb
=== CONT TestAccDataSyncLocationAzureBlob_update
--- PASS: TestAccDataSyncLocationHDFS_disappears (122.08s)
--- PASS: TestAccDataSyncLocationHDFS_basic (136.65s)
=== CONT TestAccDataSyncLocationFSxONTAPFileSystem_disappears
--- PASS: TestAccDataSyncLocationNFS_AgentARNs_multiple (218.12s)
=== CONT TestAccDataSyncLocationAzureBlob_tags
--- PASS: TestAccDataSyncLocationHDFS_tags (184.49s)
=== CONT TestAccDataSyncLocationFSxONTAPFileSystem_basic
--- PASS: TestAccDataSyncLocationEFS_accessPointARN (117.08s)
=== CONT TestAccDataSyncLocationAzureBlob_disappears
--- PASS: TestAccDataSyncLocationEFS_basic (116.77s)
=== CONT TestAccDataSyncLocationFSxLustreFileSystem_tags
=== CONT TestAccDataSyncLocationAzureBlob_basic
--- PASS: TestAccDataSyncTask_taskReportConfig (190.03s)
--- PASS: TestAccDataSyncLocationAzureBlob_update (115.12s)
=== CONT TestAccDataSyncLocationFSxLustreFileSystem_subdirectory
--- PASS: TestAccDataSyncLocationSMB_tags (183.89s)
=== CONT TestAccDataSyncLocationFSxLustreFileSystem_disappears
--- PASS: TestAccDataSyncLocationAzureBlob_tags (144.27s)
=== CONT TestAccDataSyncAgent_disappears
--- PASS: TestAccDataSyncLocationAzureBlob_disappears (113.90s)
=== CONT TestAccDataSyncLocationFSxLustreFileSystem_basic
--- PASS: TestAccDataSyncLocationAzureBlob_basic (116.70s)
=== CONT TestAccDataSyncAgent_tags
--- PASS: TestAccDataSyncAgent_vpcEndpointID (279.16s)
=== CONT TestAccDataSyncLocationEFS_tags
--- PASS: TestAccDataSyncAgent_disappears (124.37s)
=== CONT TestAccDataSyncAgent_agentName
--- PASS: TestAccDataSyncLocationEFS_tags (138.40s)
=== CONT TestAccDataSyncLocationEFS_subdirectory
--- PASS: TestAccDataSyncAgent_tags (185.96s)
=== CONT TestAccDataSyncTask_includes
--- PASS: TestAccDataSyncLocationFSxOpenZFSFileSystem_disappears (485.64s)
=== CONT TestAccDataSyncLocationEFS_disappears
--- PASS: TestAccDataSyncAgent_agentName (115.57s)
=== CONT TestAccDataSyncAgent_basic
--- PASS: TestAccDataSyncLocationFSxOpenZFSFileSystem_subdirectory (497.84s)
=== CONT TestAccDataSyncTask_DefaultSyncOptions_overwriteMode
--- PASS: TestAccDataSyncLocationFSxOpenZFSFileSystem_basic (488.23s)
=== CONT TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
--- PASS: TestAccDataSyncLocationFSxOpenZFSFileSystem_tags (521.06s)
=== CONT TestAccDataSyncTask_DefaultSyncOptions_preserveDevices
--- PASS: TestAccDataSyncLocationEFS_subdirectory (116.58s)
=== CONT TestAccDataSyncTask_excludes
--- PASS: TestAccDataSyncLocationEFS_disappears (115.24s)
--- PASS: TestSubdirectoryFromLocationURI (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/empty_URI (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/FSx_Zfs_URI_one_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/FSx_Zfs_URI_top_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_two_levels (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_one_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_top_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/HDFS_URI_two_levels (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/HDFS_URI_one_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/HDFS_URI_top_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/SMB_URI_two_levels (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/SMB_URI_one_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/FSx_Zfs_URI_two_levels (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/SMB_URI_top_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/NFS_URI_two_levels (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/NFS_URI_one_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/NFS_URI_top_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/EFS_URI_two_levels (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/EFS_URI_one_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/EFS_URI_top_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_two_levels (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_one_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_top_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_two_levels (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_one_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_top_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(2) (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(1) (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/invalid_URI_scheme (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/Azure_blob_URI_one_level (0.00s)
--- PASS: TestSubdirectoryFromLocationURI/Object_storage_two_levels (0.00s)
=== CONT TestDecodeObjectStorageURI/empty_URI
=== CONT TestDecodeObjectStorageURI/Object_storage_one_level
=== CONT TestDecodeObjectStorageURI/Object_storage_two_levels
=== CONT TestDecodeObjectStorageURI/Object_storage_top_level
=== CONT TestDecodeObjectStorageURI/S3_bucket_URI_top_level
--- PASS: TestDecodeObjectStorageURI (0.00s)
--- PASS: TestDecodeObjectStorageURI/empty_URI (0.00s)
--- PASS: TestDecodeObjectStorageURI/Object_storage_one_level (0.00s)
--- PASS: TestDecodeObjectStorageURI/Object_storage_two_levels (0.00s)
--- PASS: TestDecodeObjectStorageURI/Object_storage_top_level (0.00s)
--- PASS: TestDecodeObjectStorageURI/S3_bucket_URI_top_level (0.00s)
--- PASS: TestAccDataSyncTask_excludes (163.53s)
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_subdirectory (570.26s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_uid (174.18s)
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_tags (633.82s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond (153.65s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_transferMode (174.17s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_verifyMode (180.05s)
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_disappears (681.26s)
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_basic (652.43s)
--- PASS: TestAccDataSyncLocationFSxONTAPFileSystem_subdirectory (2977.19s)
--- PASS: TestAccDataSyncLocationFSxONTAPFileSystem_smb (3090.29s)
--- PASS: TestAccDataSyncLocationFSxONTAPFileSystem_basic (3038.33s)
--- PASS: TestAccDataSyncLocationFSxONTAPFileSystem_disappears (3096.54s)
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_tags (3464.84s)
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_subdirectory (3520.49s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags (3801.70s)
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_basic (3785.80s)
--- PASS: TestAccDataSyncLocationFSxONTAPFileSystem_tags (3081.08s)
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_disappears (4311.87s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/datasync 4520.718s
This functionality has been released in v5.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36817
Closes #36136
References
Output from Acceptance Testing