-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f-aws_vpc_ipam_pool support for cascade #36898
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=ec2 TESTS="TestAccIPAMPool_" ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 1 -run='TestAccIPAMPool_' -timeout 360m
=== RUN TestAccIPAMPool_basic
=== PAUSE TestAccIPAMPool_basic
=== RUN TestAccIPAMPool_disappears
=== PAUSE TestAccIPAMPool_disappears
=== RUN TestAccIPAMPool_ipv6Basic
=== PAUSE TestAccIPAMPool_ipv6Basic
=== RUN TestAccIPAMPool_ipv6Contiguous
=== PAUSE TestAccIPAMPool_ipv6Contiguous
=== RUN TestAccIPAMPool_cascade
=== PAUSE TestAccIPAMPool_cascade
=== RUN TestAccIPAMPool_tags
=== PAUSE TestAccIPAMPool_tags
=== CONT TestAccIPAMPool_basic
--- PASS: TestAccIPAMPool_basic (56.32s)
=== CONT TestAccIPAMPool_ipv6Contiguous
--- PASS: TestAccIPAMPool_ipv6Contiguous (50.17s)
=== CONT TestAccIPAMPool_tags
--- PASS: TestAccIPAMPool_tags (61.07s)
=== CONT TestAccIPAMPool_cascade
--- PASS: TestAccIPAMPool_cascade (83.87s)
=== CONT TestAccIPAMPool_ipv6Basic
--- PASS: TestAccIPAMPool_ipv6Basic (67.03s)
=== CONT TestAccIPAMPool_disappears
--- PASS: TestAccIPAMPool_disappears (39.94s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 364.138s
Thanks for your contribution, @nikhil-goenka! 👍 |
This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36245
References
Output from Acceptance Testing