-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/imagebuilder_image: adds workflow functionality #36953
r/imagebuilder_image: adds workflow functionality #36953
Conversation
Community NoteVoting for Prioritization
For Submitters
|
9e61485
to
7bee042
Compare
7bee042
to
cdbcff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccImageBuilderImage_' PKG=imagebuilder ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/imagebuilder/... -v -count 1 -parallel 3 -run=TestAccImageBuilderImage_ -timeout 360m
=== RUN TestAccImageBuilderImage_basic
=== PAUSE TestAccImageBuilderImage_basic
=== RUN TestAccImageBuilderImage_disappears
=== PAUSE TestAccImageBuilderImage_disappears
=== RUN TestAccImageBuilderImage_distributionARN
=== PAUSE TestAccImageBuilderImage_distributionARN
=== RUN TestAccImageBuilderImage_enhancedImageMetadataEnabled
=== PAUSE TestAccImageBuilderImage_enhancedImageMetadataEnabled
=== RUN TestAccImageBuilderImage_ImageTests_imageTestsEnabled
=== PAUSE TestAccImageBuilderImage_ImageTests_imageTestsEnabled
=== RUN TestAccImageBuilderImage_ImageTests_timeoutMinutes
=== PAUSE TestAccImageBuilderImage_ImageTests_timeoutMinutes
=== RUN TestAccImageBuilderImage_tags
=== PAUSE TestAccImageBuilderImage_tags
=== RUN TestAccImageBuilderImage_containerRecipeARN
=== PAUSE TestAccImageBuilderImage_containerRecipeARN
=== RUN TestAccImageBuilderImage_imageScanningConfiguration
=== PAUSE TestAccImageBuilderImage_imageScanningConfiguration
=== RUN TestAccImageBuilderImage_outputResources_containers
=== PAUSE TestAccImageBuilderImage_outputResources_containers
=== RUN TestAccImageBuilderImage_workflows
=== PAUSE TestAccImageBuilderImage_workflows
=== CONT TestAccImageBuilderImage_basic
=== CONT TestAccImageBuilderImage_workflows
=== CONT TestAccImageBuilderImage_ImageTests_imageTestsEnabled
--- PASS: TestAccImageBuilderImage_ImageTests_imageTestsEnabled (559.77s)
=== CONT TestAccImageBuilderImage_outputResources_containers
--- PASS: TestAccImageBuilderImage_workflows (835.47s)
=== CONT TestAccImageBuilderImage_imageScanningConfiguration
image_test.go:279: Amazon Inspector not available: operation error Inspector2: ListDelegatedAdminAccounts, https response error StatusCode: 403, RequestID: 7521e35f-ca4d-4a48-a8cb-62c40f6d62c1, AccessDeniedException: Invoking account is not organization administrator account
--- SKIP: TestAccImageBuilderImage_imageScanningConfiguration (0.33s)
=== CONT TestAccImageBuilderImage_containerRecipeARN
--- PASS: TestAccImageBuilderImage_basic (962.33s)
=== CONT TestAccImageBuilderImage_tags
--- PASS: TestAccImageBuilderImage_outputResources_containers (452.50s)
=== CONT TestAccImageBuilderImage_ImageTests_timeoutMinutes
--- PASS: TestAccImageBuilderImage_containerRecipeARN (533.18s)
=== CONT TestAccImageBuilderImage_disappears
--- PASS: TestAccImageBuilderImage_tags (856.19s)
=== CONT TestAccImageBuilderImage_enhancedImageMetadataEnabled
--- PASS: TestAccImageBuilderImage_ImageTests_timeoutMinutes (846.67s)
=== CONT TestAccImageBuilderImage_distributionARN
--- PASS: TestAccImageBuilderImage_disappears (945.57s)
--- PASS: TestAccImageBuilderImage_enhancedImageMetadataEnabled (793.41s)
--- PASS: TestAccImageBuilderImage_distributionARN (1009.39s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder 2881.854s
This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
ImageBuilder now allows for customized workflows: https://aws.amazon.com/about-aws/whats-new/2023/12/ec2-image-builder-image-workflows/
This adds that functionality to
imagebuilder_image
Relations
Relates #35045
References
CreateImage input: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/imagebuilder#CreateImageInput
Output from Acceptance Testing