Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/imagebuilder_image: adds workflow functionality #36953

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

thatderek
Copy link
Contributor

@thatderek thatderek commented Apr 17, 2024

Description

ImageBuilder now allows for customized workflows: https://aws.amazon.com/about-aws/whats-new/2023/12/ec2-image-builder-image-workflows/

This adds that functionality to imagebuilder_image

Relations

Relates #35045

References

CreateImage input: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/imagebuilder#CreateImageInput

Output from Acceptance Testing

% make testacc TESTS=TestAccImageBuilderImage_workflows PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run='TestAccImageBuilderImage_workflows'  -timeout 360m
=== RUN   TestAccImageBuilderImage_workflows
=== PAUSE TestAccImageBuilderImage_workflows
=== CONT  TestAccImageBuilderImage_workflows
--- PASS: TestAccImageBuilderImage_workflows (1046.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	1046.386s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. labels Apr 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 17, 2024
@thatderek thatderek force-pushed the f-imagebuilder-image-workflows branch 5 times, most recently from 9e61485 to 7bee042 Compare April 17, 2024 19:53
@thatderek thatderek force-pushed the f-imagebuilder-image-workflows branch from 7bee042 to cdbcff0 Compare April 17, 2024 20:40
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 18, 2024
@ewbankkit ewbankkit self-assigned this Apr 18, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 18, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccImageBuilderImage_' PKG=imagebuilder ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/imagebuilder/... -v -count 1 -parallel 3  -run=TestAccImageBuilderImage_ -timeout 360m
=== RUN   TestAccImageBuilderImage_basic
=== PAUSE TestAccImageBuilderImage_basic
=== RUN   TestAccImageBuilderImage_disappears
=== PAUSE TestAccImageBuilderImage_disappears
=== RUN   TestAccImageBuilderImage_distributionARN
=== PAUSE TestAccImageBuilderImage_distributionARN
=== RUN   TestAccImageBuilderImage_enhancedImageMetadataEnabled
=== PAUSE TestAccImageBuilderImage_enhancedImageMetadataEnabled
=== RUN   TestAccImageBuilderImage_ImageTests_imageTestsEnabled
=== PAUSE TestAccImageBuilderImage_ImageTests_imageTestsEnabled
=== RUN   TestAccImageBuilderImage_ImageTests_timeoutMinutes
=== PAUSE TestAccImageBuilderImage_ImageTests_timeoutMinutes
=== RUN   TestAccImageBuilderImage_tags
=== PAUSE TestAccImageBuilderImage_tags
=== RUN   TestAccImageBuilderImage_containerRecipeARN
=== PAUSE TestAccImageBuilderImage_containerRecipeARN
=== RUN   TestAccImageBuilderImage_imageScanningConfiguration
=== PAUSE TestAccImageBuilderImage_imageScanningConfiguration
=== RUN   TestAccImageBuilderImage_outputResources_containers
=== PAUSE TestAccImageBuilderImage_outputResources_containers
=== RUN   TestAccImageBuilderImage_workflows
=== PAUSE TestAccImageBuilderImage_workflows
=== CONT  TestAccImageBuilderImage_basic
=== CONT  TestAccImageBuilderImage_workflows
=== CONT  TestAccImageBuilderImage_ImageTests_imageTestsEnabled
--- PASS: TestAccImageBuilderImage_ImageTests_imageTestsEnabled (559.77s)
=== CONT  TestAccImageBuilderImage_outputResources_containers
--- PASS: TestAccImageBuilderImage_workflows (835.47s)
=== CONT  TestAccImageBuilderImage_imageScanningConfiguration
    image_test.go:279: Amazon Inspector not available: operation error Inspector2: ListDelegatedAdminAccounts, https response error StatusCode: 403, RequestID: 7521e35f-ca4d-4a48-a8cb-62c40f6d62c1, AccessDeniedException: Invoking account is not organization administrator account
--- SKIP: TestAccImageBuilderImage_imageScanningConfiguration (0.33s)
=== CONT  TestAccImageBuilderImage_containerRecipeARN
--- PASS: TestAccImageBuilderImage_basic (962.33s)
=== CONT  TestAccImageBuilderImage_tags
--- PASS: TestAccImageBuilderImage_outputResources_containers (452.50s)
=== CONT  TestAccImageBuilderImage_ImageTests_timeoutMinutes
--- PASS: TestAccImageBuilderImage_containerRecipeARN (533.18s)
=== CONT  TestAccImageBuilderImage_disappears
--- PASS: TestAccImageBuilderImage_tags (856.19s)
=== CONT  TestAccImageBuilderImage_enhancedImageMetadataEnabled
--- PASS: TestAccImageBuilderImage_ImageTests_timeoutMinutes (846.67s)
=== CONT  TestAccImageBuilderImage_distributionARN
--- PASS: TestAccImageBuilderImage_disappears (945.57s)
--- PASS: TestAccImageBuilderImage_enhancedImageMetadataEnabled (793.41s)
--- PASS: TestAccImageBuilderImage_distributionARN (1009.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	2881.854s

@ewbankkit ewbankkit merged commit 70718c6 into hashicorp:main Apr 18, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 18, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants