Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_appconfig_deployment: Handle ConflictException in resource Create #36980

Merged
merged 10 commits into from
Apr 18, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 18, 2024

Description

Handles ConflictException in aws_appconfig_deployment resource Create.
The AWS SDK for Go v2 IsErrorRetryable mechanism receives a ResponseError, not its wrapping OperationError (that's added once the request fails), so it is not possible to determine the operation name.

Relations

Closes #36975.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAppConfigDeployment_' PKG=appconfig ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/appconfig/... -v -count 1 -parallel 3  -run=TestAccAppConfigDeployment_ -timeout 360m
=== RUN   TestAccAppConfigDeployment_basic
=== PAUSE TestAccAppConfigDeployment_basic
=== RUN   TestAccAppConfigDeployment_kms
=== PAUSE TestAccAppConfigDeployment_kms
=== RUN   TestAccAppConfigDeployment_predefinedStrategy
=== PAUSE TestAccAppConfigDeployment_predefinedStrategy
=== RUN   TestAccAppConfigDeployment_tags
=== PAUSE TestAccAppConfigDeployment_tags
=== RUN   TestAccAppConfigDeployment_multiple
=== PAUSE TestAccAppConfigDeployment_multiple
=== CONT  TestAccAppConfigDeployment_basic
=== CONT  TestAccAppConfigDeployment_multiple
=== CONT  TestAccAppConfigDeployment_tags
--- PASS: TestAccAppConfigDeployment_basic (25.41s)
=== CONT  TestAccAppConfigDeployment_predefinedStrategy
--- PASS: TestAccAppConfigDeployment_predefinedStrategy (22.88s)
=== CONT  TestAccAppConfigDeployment_kms
--- PASS: TestAccAppConfigDeployment_tags (54.10s)
--- PASS: TestAccAppConfigDeployment_kms (19.09s)
--- PASS: TestAccAppConfigDeployment_multiple (392.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appconfig	404.025s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appconfig Issues and PRs that pertain to the appconfig service. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Apr 18, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 18, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@ewbankkit ewbankkit merged commit 31d05e7 into main Apr 18, 2024
38 checks passed
@ewbankkit ewbankkit deleted the b-aws_appconfig_deployment.ConflictException branch April 18, 2024 17:58
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 18, 2024
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/appconfig Issues and PRs that pertain to the appconfig service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AWS API ConflictException when creating multiple aws_appconfig_deployment resources
1 participant