Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_paymentcryptography_key #37017

Merged
merged 23 commits into from
Jun 3, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Apr 20, 2024

Description

New resource for managing AWS Payment Cryptography keys.

Output from Acceptance Testing

%  make testacc TESTS=TestAccPaymentCryptographyKey_ PKG=paymentcryptography
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/paymentcryptography/... -v -count 1 -parallel 20 -run='TestAccPaymentCryptographyKey_'  -timeout 360m
=== RUN   TestAccPaymentCryptographyKey_basic
=== PAUSE TestAccPaymentCryptographyKey_basic
=== RUN   TestAccPaymentCryptographyKey_tags
=== PAUSE TestAccPaymentCryptographyKey_tags
=== RUN   TestAccPaymentCryptographyKey_update
=== PAUSE TestAccPaymentCryptographyKey_update
=== RUN   TestAccPaymentCryptographyKey_disappears
=== PAUSE TestAccPaymentCryptographyKey_disappears
=== CONT  TestAccPaymentCryptographyKey_basic
=== CONT  TestAccPaymentCryptographyKey_update
=== CONT  TestAccPaymentCryptographyKey_tags
=== CONT  TestAccPaymentCryptographyKey_disappears
--- PASS: TestAccPaymentCryptographyKey_disappears (15.52s)
--- PASS: TestAccPaymentCryptographyKey_basic (18.12s)
--- PASS: TestAccPaymentCryptographyKey_tags (27.26s)
--- PASS: TestAccPaymentCryptographyKey_update (35.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/paymentcryptography        40.174s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/paymentcryptography Issues and PRs that pertain to the paymentcryptography service. labels Apr 20, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Apr 20, 2024
@drewtul drewtul marked this pull request as ready for review April 20, 2024 21:59
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
acctest.PreCheck(ctx, t)
testAccPreCheck(ctx, t)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No partition check as the latest go SDK v1 doesn't have endpoints for this service, the region pre-check still checks the service is available in the region being tested against.

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 23, 2024
@YakDriver YakDriver self-assigned this Jun 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 3, 2024
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

% make testacc TESTS=TestAccPaymentCryptographyKey_ PKG=paymentcryptography
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/paymentcryptography/... -v -count 1 -parallel 20 -run='TestAccPaymentCryptographyKey_'  -timeout 360m
=== RUN   TestAccPaymentCryptographyKey_basic
=== PAUSE TestAccPaymentCryptographyKey_basic
=== RUN   TestAccPaymentCryptographyKey_tags
=== PAUSE TestAccPaymentCryptographyKey_tags
=== RUN   TestAccPaymentCryptographyKey_update
=== PAUSE TestAccPaymentCryptographyKey_update
=== RUN   TestAccPaymentCryptographyKey_disappears
=== PAUSE TestAccPaymentCryptographyKey_disappears
=== CONT  TestAccPaymentCryptographyKey_basic
=== CONT  TestAccPaymentCryptographyKey_update
=== CONT  TestAccPaymentCryptographyKey_disappears
=== CONT  TestAccPaymentCryptographyKey_tags
--- PASS: TestAccPaymentCryptographyKey_disappears (17.60s)
--- PASS: TestAccPaymentCryptographyKey_basic (20.71s)
--- PASS: TestAccPaymentCryptographyKey_tags (30.84s)
--- PASS: TestAccPaymentCryptographyKey_update (40.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/paymentcryptography	42.811s

@YakDriver YakDriver merged commit 1acf1cf into hashicorp:main Jun 3, 2024
45 checks passed
@github-actions github-actions bot added this to the v5.53.0 milestone Jun 3, 2024
@drewtul drewtul deleted the f-paymentcryptography-key branch June 6, 2024 11:00
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jul 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/paymentcryptography Issues and PRs that pertain to the paymentcryptography service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants