Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_app_image_config - add code_editor_app_image_config #37059

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Apr 23, 2024

Description

Relations

Closes #36828
Closes #36321

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Apr 23, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Apr 23, 2024
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 23, 2024
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Apr 23, 2024
@DrFaust92
Copy link
Collaborator Author

I was not able to run tests, something strange with tags and getting 500 responses even though i did not change anything related.

@DrFaust92 DrFaust92 marked this pull request as ready for review April 23, 2024 16:50
@ewbankkit ewbankkit self-assigned this Apr 24, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 24, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerAppImageConfig_' PKG=sagemaker ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 3  -run=TestAccSageMakerAppImageConfig_ -timeout 360m
=== RUN   TestAccSageMakerAppImageConfig_basic
=== PAUSE TestAccSageMakerAppImageConfig_basic
=== RUN   TestAccSageMakerAppImageConfig_KernelGatewayImage_kernelSpecs
=== PAUSE TestAccSageMakerAppImageConfig_KernelGatewayImage_kernelSpecs
=== RUN   TestAccSageMakerAppImageConfig_KernelGatewayImage_fileSystem
=== PAUSE TestAccSageMakerAppImageConfig_KernelGatewayImage_fileSystem
=== RUN   TestAccSageMakerAppImageConfig_CodeEditor
=== PAUSE TestAccSageMakerAppImageConfig_CodeEditor
=== RUN   TestAccSageMakerAppImageConfig_JupyterLab
=== PAUSE TestAccSageMakerAppImageConfig_JupyterLab
=== RUN   TestAccSageMakerAppImageConfig_tags
--- PASS: TestAccSageMakerAppImageConfig_tags (46.34s)
=== RUN   TestAccSageMakerAppImageConfig_disappears
=== PAUSE TestAccSageMakerAppImageConfig_disappears
=== CONT  TestAccSageMakerAppImageConfig_basic
=== CONT  TestAccSageMakerAppImageConfig_CodeEditor
=== CONT  TestAccSageMakerAppImageConfig_KernelGatewayImage_fileSystem
--- PASS: TestAccSageMakerAppImageConfig_basic (29.75s)
=== CONT  TestAccSageMakerAppImageConfig_KernelGatewayImage_kernelSpecs
--- PASS: TestAccSageMakerAppImageConfig_KernelGatewayImage_fileSystem (47.20s)
=== CONT  TestAccSageMakerAppImageConfig_disappears
--- PASS: TestAccSageMakerAppImageConfig_CodeEditor (47.67s)
=== CONT  TestAccSageMakerAppImageConfig_JupyterLab
--- PASS: TestAccSageMakerAppImageConfig_disappears (37.25s)
--- PASS: TestAccSageMakerAppImageConfig_KernelGatewayImage_kernelSpecs (57.96s)
--- PASS: TestAccSageMakerAppImageConfig_JupyterLab (55.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	159.865s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4669a81 into hashicorp:main Apr 24, 2024
80 checks passed
@github-actions github-actions bot added this to the v5.47.0 milestone Apr 24, 2024
Copy link

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 26, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants