-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/sagemaker_app_image_config - add code_editor_app_image_config
#37059
Conversation
Community NoteVoting for Prioritization
For Submitters
|
f3508b2
to
06a298b
Compare
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
06a298b
to
48b05c0
Compare
I was not able to run tests, something strange with tags and getting 500 responses even though i did not change anything related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSageMakerAppImageConfig_' PKG=sagemaker ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 3 -run=TestAccSageMakerAppImageConfig_ -timeout 360m
=== RUN TestAccSageMakerAppImageConfig_basic
=== PAUSE TestAccSageMakerAppImageConfig_basic
=== RUN TestAccSageMakerAppImageConfig_KernelGatewayImage_kernelSpecs
=== PAUSE TestAccSageMakerAppImageConfig_KernelGatewayImage_kernelSpecs
=== RUN TestAccSageMakerAppImageConfig_KernelGatewayImage_fileSystem
=== PAUSE TestAccSageMakerAppImageConfig_KernelGatewayImage_fileSystem
=== RUN TestAccSageMakerAppImageConfig_CodeEditor
=== PAUSE TestAccSageMakerAppImageConfig_CodeEditor
=== RUN TestAccSageMakerAppImageConfig_JupyterLab
=== PAUSE TestAccSageMakerAppImageConfig_JupyterLab
=== RUN TestAccSageMakerAppImageConfig_tags
--- PASS: TestAccSageMakerAppImageConfig_tags (46.34s)
=== RUN TestAccSageMakerAppImageConfig_disappears
=== PAUSE TestAccSageMakerAppImageConfig_disappears
=== CONT TestAccSageMakerAppImageConfig_basic
=== CONT TestAccSageMakerAppImageConfig_CodeEditor
=== CONT TestAccSageMakerAppImageConfig_KernelGatewayImage_fileSystem
--- PASS: TestAccSageMakerAppImageConfig_basic (29.75s)
=== CONT TestAccSageMakerAppImageConfig_KernelGatewayImage_kernelSpecs
--- PASS: TestAccSageMakerAppImageConfig_KernelGatewayImage_fileSystem (47.20s)
=== CONT TestAccSageMakerAppImageConfig_disappears
--- PASS: TestAccSageMakerAppImageConfig_CodeEditor (47.67s)
=== CONT TestAccSageMakerAppImageConfig_JupyterLab
--- PASS: TestAccSageMakerAppImageConfig_disappears (37.25s)
--- PASS: TestAccSageMakerAppImageConfig_KernelGatewayImage_kernelSpecs (57.96s)
--- PASS: TestAccSageMakerAppImageConfig_JupyterLab (55.37s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 159.865s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #36828
Closes #36321
References
Output from Acceptance Testing