Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource aws_bedrockagent_agent_knowledge_base_association #37185

Merged

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Apr 30, 2024

Description

New resource aws_bedrockagent_agent_knowledge_base_association for associating knowledge bases with agents.

I restored the test-fixtures folder that was deleted in #36783 because this is needed for agent tests.

The tests rely on the knowledge base and agent setup to create a knowledge base to associate to the agent.

Output from Acceptance Testing

% make testacc TESTS=TestAccBedrockAgentAgentKnowledgeBaseAssociation_ PKG=bedrockagent
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgentKnowledgeBaseAssociation_'  -timeout 360m
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic
=== PAUSE TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_update
=== PAUSE TestAccBedrockAgentAgentKnowledgeBaseAssociation_update
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears
=== PAUSE TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears
=== CONT  TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic
=== CONT  TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears
=== CONT  TestAccBedrockAgentAgentKnowledgeBaseAssociation_update
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic (1537.65s)
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears (1721.37s)
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_update (1856.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       1860.855s


...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Apr 30, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Apr 30, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. labels Apr 30, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 30, 2024
@drewtul drewtul marked this pull request as ready for review April 30, 2024 20:54
@ewbankkit ewbankkit self-assigned this May 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 1, 2024
@ewbankkit ewbankkit mentioned this pull request May 2, 2024
6 tasks
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccBedrockAgentAgentKnowledgeBaseAssociation_' PKG=bedrockagent ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 2  -run=TestAccBedrockAgentAgentKnowledgeBaseAssociation_ -timeout 720m
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic
=== PAUSE TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_update
=== PAUSE TestAccBedrockAgentAgentKnowledgeBaseAssociation_update
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears
=== PAUSE TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears
=== CONT  TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic
=== CONT  TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears (1745.67s)
=== CONT  TestAccBedrockAgentAgentKnowledgeBaseAssociation_update
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic (1803.84s)
--- PASS: TestAccBedrockAgentAgentKnowledgeBaseAssociation_update (1684.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	3441.076s

@ewbankkit
Copy link
Contributor

@drewtul Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8d11201 into hashicorp:main May 2, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.48.0 milestone May 2, 2024
@drewtul drewtul deleted the f-bedrockagent-knowledgebase-association branch May 2, 2024 18:14
Copy link

github-actions bot commented May 2, 2024

This functionality has been released in v5.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 2, 2024
Copy link

github-actions bot commented Jun 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants