Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rds): DescribeOrderableDBInstanceOptionsInput MaxRecords to 1000 #37251

Merged
merged 2 commits into from
May 3, 2024
Merged

fix(rds): DescribeOrderableDBInstanceOptionsInput MaxRecords to 1000 #37251

merged 2 commits into from
May 3, 2024

Conversation

diegofd
Copy link
Contributor

@diegofd diegofd commented May 3, 2024 •
edited by justinretzolk
Loading

Description

RDS DescribeOrderableDBInstanceOptions MaxRecords is 1000.

Doc: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribeOrderableDBInstanceOptions.html

Relations

Closes #37221
Closes #37258
Introduced in: #35698

References

Output from Acceptance Testing

% make t T=TestAccRDSOrderableInstanceDataSource_ K=rds
# It would be great if anyone can run this, but the change looks simple enough.

...

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. labels May 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 3, 2024
github-actions[bot]
github-actions bot reviewed May 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @diegofd 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels May 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 3, 2024
@ewbankkit ewbankkit self-assigned this May 3, 2024
ewbankkit
ewbankkit approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Before

% make testacc TESTARGS='-run=TestAccRDSOrderableInstanceDataSource_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSOrderableInstanceDataSource_ -timeout 360m
=== RUN   TestAccRDSOrderableInstanceDataSource_basic
=== PAUSE TestAccRDSOrderableInstanceDataSource_basic
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredClass
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredClass
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
=== RUN   TestAccRDSOrderableInstanceDataSource_latestVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_latestVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsClusters
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsClusters
=== RUN   TestAccRDSOrderableInstanceDataSource_readReplicaCapable
=== PAUSE TestAccRDSOrderableInstanceDataSource_readReplicaCapable
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsMultiAZ
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsMultiAZ
=== RUN   TestAccRDSOrderableInstanceDataSource_supportedEngineModes
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportedEngineModes
=== RUN   TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsIops
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsIops
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
=== CONT  TestAccRDSOrderableInstanceDataSource_basic
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsMultiAZ
=== CONT  TestAccRDSOrderableInstanceDataSource_latestVersion
    orderable_instance_data_source_test.go:154: Step 1/2 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: 318cb471-5f64-4e1f-89c8-a5b460a35b91
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 12, in data "aws_rds_orderable_db_instance" "test":
          12: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_supportsMultiAZ
    orderable_instance_data_source_test.go:257: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: 55f13ce2-b947-4e6a-96ec-e08820fe113c
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 12, in data "aws_rds_orderable_db_instance" "test":
          12: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_basic
    orderable_instance_data_source_test.go:29: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: b537cc9e-692a-4938-8c1e-b62e5e867faa
        
          with data.aws_rds_orderable_db_instance.dynamic,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "dynamic":
          16: data "aws_rds_orderable_db_instance" "dynamic" {
        
--- FAIL: TestAccRDSOrderableInstanceDataSource_latestVersion (5.41s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportsMultiAZ (5.45s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
--- FAIL: TestAccRDSOrderableInstanceDataSource_basic (5.52s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
=== NAME  TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
    orderable_instance_data_source_test.go:451: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: 8732065d-14f0-4fed-a1aa-f17aaeb11d5e
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "test":
          16: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
    orderable_instance_data_source_test.go:375: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: c0d24d4b-ab95-4672-90bb-0370ebfb7fb6
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "test":
          16: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
    orderable_instance_data_source_test.go:427: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: 0feba209-7277-4bcb-b7df-77d1c5da41ec
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "test":
          16: data "aws_rds_orderable_db_instance" "test" {
        
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption (4.72s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication (4.79s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling (4.71s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsIops
    orderable_instance_data_source_test.go:351: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: d9e41b13-dc53-4e73-a707-ca34b978b960
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "test":
          16: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
    orderable_instance_data_source_test.go:327: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: f9dd6b0f-cecd-4b7a-81fd-ada9568a962d
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "test":
          16: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
    orderable_instance_data_source_test.go:399: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: 861f95ff-b226-491d-aba3-d2e17a1472c5
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "test":
          16: data "aws_rds_orderable_db_instance" "test" {
        
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportsIops (4.57s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication (4.62s)
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights (5.20s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
=== NAME  TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes
    orderable_instance_data_source_test.go:301: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: a13943e8-340d-4c1a-86c0-2e59d21b1d89
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 12, in data "aws_rds_orderable_db_instance" "test":
          12: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
    orderable_instance_data_source_test.go:105: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: 2f7a15b8-1316-4c03-b3c3-4b46231b875b
        
          with data.aws_rds_orderable_db_instance.dynamic,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "dynamic":
          16: data "aws_rds_orderable_db_instance" "dynamic" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
    orderable_instance_data_source_test.go:130: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: b69fcf74-e883-4dee-adf9-4e1e7af7530f
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "test":
          16: data "aws_rds_orderable_db_instance" "test" {
        
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes (4.69s)
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredVersion
--- FAIL: TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion (4.91s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsClusters
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring (4.63s)
=== CONT  TestAccRDSOrderableInstanceDataSource_readReplicaCapable
=== NAME  TestAccRDSOrderableInstanceDataSource_preferredVersion
    orderable_instance_data_source_test.go:81: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: ab3d901a-e595-45d8-9916-d982c06deda2
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "test":
          16: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_supportsClusters
    orderable_instance_data_source_test.go:211: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: d4a5cac6-24ff-4757-b274-09b3c0740802
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 12, in data "aws_rds_orderable_db_instance" "test":
          12: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_readReplicaCapable
    orderable_instance_data_source_test.go:234: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: 928212ea-a8c0-4f51-8348-f5c6725d5cff
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 12, in data "aws_rds_orderable_db_instance" "test":
          12: data "aws_rds_orderable_db_instance" "test" {
        
--- FAIL: TestAccRDSOrderableInstanceDataSource_preferredVersion (4.73s)
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredClass
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportsClusters (4.59s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportedEngineModes
--- FAIL: TestAccRDSOrderableInstanceDataSource_readReplicaCapable (4.38s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases
    orderable_instance_data_source_test.go:188: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: 1784e2b2-d4fa-4eb6-af87-58207cf49eb3
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 12, in data "aws_rds_orderable_db_instance" "test":
          12: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_preferredClass
    orderable_instance_data_source_test.go:57: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: 047aa717-b554-414f-ab78-7d560f4622f4
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 16, in data "aws_rds_orderable_db_instance" "test":
          16: data "aws_rds_orderable_db_instance" "test" {
        
=== NAME  TestAccRDSOrderableInstanceDataSource_supportedEngineModes
    orderable_instance_data_source_test.go:279: Step 1/1 error: Error running pre-apply plan: exit status 1
        
        Error: reading RDS Orderable DB Instance Options: InvalidParameterValue: Invalid value 3412 for MaxRecords. Must be between 20 and 1000
        	status code: 400, request id: 3361cb84-8bc8-4470-8fd2-297885765c0e
        
          with data.aws_rds_orderable_db_instance.test,
          on terraform_plugin_test.tf line 12, in data "aws_rds_orderable_db_instance" "test":
          12: data "aws_rds_orderable_db_instance" "test" {
        
--- FAIL: TestAccRDSOrderableInstanceDataSource_preferredClass (4.85s)
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases (4.70s)
--- FAIL: TestAccRDSOrderableInstanceDataSource_supportedEngineModes (4.81s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	40.511s
FAIL
make: *** [testacc] Error 1

After

% make testacc TESTARGS='-run=TestAccRDSOrderableInstanceDataSource_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSOrderableInstanceDataSource_ -timeout 360m
=== RUN   TestAccRDSOrderableInstanceDataSource_basic
=== PAUSE TestAccRDSOrderableInstanceDataSource_basic
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredClass
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredClass
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
=== RUN   TestAccRDSOrderableInstanceDataSource_latestVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_latestVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsClusters
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsClusters
=== RUN   TestAccRDSOrderableInstanceDataSource_readReplicaCapable
=== PAUSE TestAccRDSOrderableInstanceDataSource_readReplicaCapable
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsMultiAZ
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsMultiAZ
=== RUN   TestAccRDSOrderableInstanceDataSource_supportedEngineModes
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportedEngineModes
=== RUN   TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsIops
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsIops
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
=== CONT  TestAccRDSOrderableInstanceDataSource_basic
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsMultiAZ
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
--- PASS: TestAccRDSOrderableInstanceDataSource_basic (19.81s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsMultiAZ (38.04s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling (36.72s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption (37.08s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsIops
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication (87.95s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication (37.59s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsIops (37.64s)
=== CONT  TestAccRDSOrderableInstanceDataSource_latestVersion
--- PASS: TestAccRDSOrderableInstanceDataSource_supportedNetworkTypes (28.92s)
=== CONT  TestAccRDSOrderableInstanceDataSource_readReplicaCapable
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights (39.28s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsClusters
--- PASS: TestAccRDSOrderableInstanceDataSource_latestVersion (40.45s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsClusters (36.84s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportedEngineModes
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsGlobalDatabases (21.21s)
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
--- PASS: TestAccRDSOrderableInstanceDataSource_readReplicaCapable (82.56s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
--- PASS: TestAccRDSOrderableInstanceDataSource_supportedEngineModes (29.56s)
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredVersion
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion (41.74s)
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredClass
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredClass (17.51s)
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredVersion (36.87s)
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring (37.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	246.945s

@ewbankkit
Copy link
Contributor

@diegofd Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c6d09d6 into hashicorp:main May 3, 2024
33 checks passed
@github-actions github-actions bot added this to the v5.49.0 milestone May 3, 2024
@diegofd diegofd deleted the fix-DescribeOrderableDBInstanceOptionsInput-MaxRecords branch May 3, 2024 18:54
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 10, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.49.0
3 participants
@diegofd @ewbankkit @justinretzolk