r/aws_opensearch_domain: handle unset auto_tune_options.rollback_on_disable #37394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XS
terraform-aws-provider
bot
added
the
prioritized
This fixes an issue observed during domain creation when `auto_tune_options` are configured. `auto_tune_options` are set after the cluster becomes active via the `UpdateDomain` API. The provider was not waiting for this update to complete before calling the read operation, which can result in incorrect `auto_tune_options` data being written to state. The appropriate waiter has been added to prevent this failure mode.
…isable Previously omitting this optional argument resulted in a failure when creating or updating the domain: ``` Error: modifying config for OpenSearch Domain: ValidationException: 1 validation error detected: Value '' at 'autoTuneOptions.rollbackOnDisable' failed to satisfy constraint: Member must satisfy enum value set: [DEFAULT_ROLLBACK, NO_ROLLBACK] ``` The `auto_tune_options` expander logic has been updated to properly handle cases where `rollback_on_disable` is unset. ```console % make testacc PKG=opensearch TESTS=TestAccOpenSearchDomain_autoTuneOptions ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.2 test ./internal/service/opensearch/... -v -count 1 -parallel 20 -run='TestAccOpenSearchDomain_autoTuneOptions' -timeout 360m --- PASS: TestAccOpenSearchDomain_autoTuneOptions (1915.20s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 1920.265s ```
…n_disable Previously omitting this optional argument resulted in a failure when creating or updating the domain: ``` Error: modifying config for OpenSearch Domain: ValidationException: 1 validation error detected: Value '' at 'autoTuneOptions.rollbackOnDisable' failed to satisfy constraint: Member must satisfy enum value set: [DEFAULT_ROLLBACK, NO_ROLLBACK] ``` The `auto_tune_options` expander logic has been updated to properly handle cases where `rollback_on_disable` is unset. ```console % make testacc PKG=elasticsearch TESTS=TestAccElasticsearchDomain_AutoTuneOptions ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.2 test ./internal/service/elasticsearch/... -v -count 1 -parallel 20 -run='TestAccElasticsearchDomain_AutoTuneOptions' -timeout 360m === RUN TestAccElasticsearchDomain_AutoTuneOptions === PAUSE TestAccElasticsearchDomain_AutoTuneOptions === CONT TestAccElasticsearchDomain_AutoTuneOptions --- PASS: TestAccElasticsearchDomain_AutoTuneOptions (2287.79s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch 2292.708s ```
jar-b
force-pushed
the
b-opensearch_domain-autotune
branch
from
245fd1f
to
fb7a829
Compare
|
This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
github-actions
bot
removed
the
prioritized
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously omitting this optional argument resulted in a failure when creating or updating the domain:
The
auto_tune_optionsexpander logic has been updated to properly handle cases whererollback_on_disableis unset.Also adds a missing waiter in create operation when
auto_tune_optionsare configured.Relations
Closes #37234
References
Output from Acceptance Testing