-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aws_shield_protection data source #37524
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
The acceptance tests for the corresponding `aws_sheild_protection` resource cover many of the potential resource types which can be passed into the `resource_arn` argument. For the data source, we can reduce the complexity and simply test one resource type and verify that the expected fields are returned.
…idator Also updates the registry documentation with the appropriate attribute names and adds examples using both optional arguments. ```console % make testacc PKG=shield TESTS=TestAccShieldProtectionDataSource_basic make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.0 test ./internal/service/shield/... -v -count 1 -parallel 20 -run='TestAccShieldProtectionDataSource_basic' -timeout 360m --- PASS: TestAccShieldProtectionDataSource_basic (85.86s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/shield 91.931s ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=shield TESTS=TestAccShieldProtectionDataSource_basic
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/shield/... -v -count 1 -parallel 20 -run='TestAccShieldProtectionDataSource_basic' -timeout 360m
--- PASS: TestAccShieldProtectionDataSource_basic (85.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/shield 91.931s
Thanks for your contribution, @hong-yi! 👍 |
This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
aws_shield_protection
Relations
Closes #35387
References
https://docs.aws.amazon.com/waf/latest/DDOSAPIReference/API_DescribeProtection.html
Output from Acceptance Testing