Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/route53_record Check region set #37565

Merged
merged 3 commits into from
May 16, 2024
Merged

r/route53_record Check region set #37565

merged 3 commits into from
May 16, 2024

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented May 16, 2024

Description

Change route53 region default to us-east-1

Relations

Closes #34016

References

Output from Acceptance Testing

> make testacc TESTS=TestAccRoute53Record_ PKG=route53
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53Record_'  -timeout 360m
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_disappears
=== PAUSE TestAccRoute53Record_disappears
=== RUN   TestAccRoute53Record_Disappears_multipleRecords
=== PAUSE TestAccRoute53Record_Disappears_multipleRecords
=== RUN   TestAccRoute53Record_underscored
=== PAUSE TestAccRoute53Record_underscored
=== RUN   TestAccRoute53Record_fqdn
=== PAUSE TestAccRoute53Record_fqdn
=== RUN   TestAccRoute53Record_trailingPeriodAndZoneID
=== PAUSE TestAccRoute53Record_trailingPeriodAndZoneID
=== RUN   TestAccRoute53Record_Support_txt
=== PAUSE TestAccRoute53Record_Support_txt
=== RUN   TestAccRoute53Record_Support_spf
=== PAUSE TestAccRoute53Record_Support_spf
=== RUN   TestAccRoute53Record_Support_caa
=== PAUSE TestAccRoute53Record_Support_caa
=== RUN   TestAccRoute53Record_Support_ds
=== PAUSE TestAccRoute53Record_Support_ds
=== RUN   TestAccRoute53Record_generatesSuffix
=== PAUSE TestAccRoute53Record_generatesSuffix
=== RUN   TestAccRoute53Record_wildcard
=== PAUSE TestAccRoute53Record_wildcard
=== RUN   TestAccRoute53Record_failover
=== PAUSE TestAccRoute53Record_failover
=== RUN   TestAccRoute53Record_Weighted_basic
=== PAUSE TestAccRoute53Record_Weighted_basic
=== RUN   TestAccRoute53Record_WeightedToSimple_basic
=== PAUSE TestAccRoute53Record_WeightedToSimple_basic
=== RUN   TestAccRoute53Record_Alias_elb
=== PAUSE TestAccRoute53Record_Alias_elb
=== RUN   TestAccRoute53Record_Alias_s3
=== PAUSE TestAccRoute53Record_Alias_s3
=== RUN   TestAccRoute53Record_Alias_vpcEndpoint
=== PAUSE TestAccRoute53Record_Alias_vpcEndpoint
=== RUN   TestAccRoute53Record_Alias_uppercase
=== PAUSE TestAccRoute53Record_Alias_uppercase
=== RUN   TestAccRoute53Record_Weighted_alias
=== PAUSE TestAccRoute53Record_Weighted_alias
=== RUN   TestAccRoute53Record_cidr
=== PAUSE TestAccRoute53Record_cidr
=== RUN   TestAccRoute53Record_Geolocation_basic
=== PAUSE TestAccRoute53Record_Geolocation_basic
=== RUN   TestAccRoute53Record_Geoproximity_basic
=== PAUSE TestAccRoute53Record_Geoproximity_basic
=== RUN   TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== PAUSE TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== RUN   TestAccRoute53Record_HealthCheckID_typeChange
=== PAUSE TestAccRoute53Record_HealthCheckID_typeChange
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53Record_typeChange
=== PAUSE TestAccRoute53Record_typeChange
=== RUN   TestAccRoute53Record_nameChange
=== PAUSE TestAccRoute53Record_nameChange
=== RUN   TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== PAUSE TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== RUN   TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
=== RUN   TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
=== RUN   TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates
=== RUN   TestAccRoute53Record_SetIdentifierRename_failover
=== PAUSE TestAccRoute53Record_SetIdentifierRename_failover
=== RUN   TestAccRoute53Record_SetIdentifierRename_latency
=== PAUSE TestAccRoute53Record_SetIdentifierRename_latency
=== RUN   TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== PAUSE TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== RUN   TestAccRoute53Record_SetIdentifierRename_weighted
=== PAUSE TestAccRoute53Record_SetIdentifierRename_weighted
=== RUN   TestAccRoute53Record_Alias_change
=== PAUSE TestAccRoute53Record_Alias_change
=== RUN   TestAccRoute53Record_Alias_changeDualstack
=== PAUSE TestAccRoute53Record_Alias_changeDualstack
=== RUN   TestAccRoute53Record_empty
=== PAUSE TestAccRoute53Record_empty
=== RUN   TestAccRoute53Record_longTXTrecord
=== PAUSE TestAccRoute53Record_longTXTrecord
=== RUN   TestAccRoute53Record_MultiValueAnswer_basic
=== PAUSE TestAccRoute53Record_MultiValueAnswer_basic
=== RUN   TestAccRoute53Record_Allow_doNotOverwrite
=== PAUSE TestAccRoute53Record_Allow_doNotOverwrite
=== RUN   TestAccRoute53Record_Allow_overwrite
=== PAUSE TestAccRoute53Record_Allow_overwrite
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53Record_HealthCheckID_typeChange
=== CONT  TestAccRoute53Record_SetIdentifierRename_failover
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== CONT  TestAccRoute53Record_failover
=== CONT  TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== CONT  TestAccRoute53Record_Geoproximity_basic
=== CONT  TestAccRoute53Record_Geolocation_basic
=== CONT  TestAccRoute53Record_cidr
=== CONT  TestAccRoute53Record_Weighted_alias
=== CONT  TestAccRoute53Record_Alias_uppercase
=== CONT  TestAccRoute53Record_Alias_vpcEndpoint
=== CONT  TestAccRoute53Record_Alias_s3
=== CONT  TestAccRoute53Record_Alias_elb
=== CONT  TestAccRoute53Record_WeightedToSimple_basic
--- PASS: TestAccRoute53Record_failover (189.35s)
=== CONT  TestAccRoute53Record_Weighted_basic
--- PASS: TestAccRoute53Record_Alias_s3 (199.72s)
=== CONT  TestAccRoute53Record_Support_txt
--- PASS: TestAccRoute53Record_basic (205.92s)
=== CONT  TestAccRoute53Record_wildcard
--- PASS: TestAccRoute53Record_Alias_uppercase (209.84s)
=== CONT  TestAccRoute53Record_generatesSuffix
--- PASS: TestAccRoute53Record_Geoproximity_basic (215.14s)
=== CONT  TestAccRoute53Record_Support_spf
--- PASS: TestAccRoute53Record_Alias_elb (216.46s)
=== CONT  TestAccRoute53Record_underscored
--- PASS: TestAccRoute53Record_Geolocation_basic (245.80s)
=== CONT  TestAccRoute53Record_trailingPeriodAndZoneID
=== CONT  TestAccRoute53Record_fqdn
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup (252.51s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates (255.61s)
=== CONT  TestAccRoute53Record_empty
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (256.81s)
=== CONT  TestAccRoute53Record_Allow_overwrite
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault (257.34s)
=== CONT  TestAccRoute53Record_Allow_doNotOverwrite
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified (261.49s)
=== CONT  TestAccRoute53Record_MultiValueAnswer_basic
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (261.83s)
=== CONT  TestAccRoute53Record_longTXTrecord
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision (268.94s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_weighted
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (273.45s)
=== CONT  TestAccRoute53Record_Alias_changeDualstack
=== CONT  TestAccRoute53Record_Alias_change
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityRegion (319.24s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_failover (328.57s)
=== CONT  TestAccRoute53Record_Support_ds
--- PASS: TestAccRoute53Record_Weighted_alias (372.21s)
=== CONT  TestAccRoute53Record_nameChange
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (376.50s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationContinent
--- PASS: TestAccRoute53Record_generatesSuffix (174.22s)
=== CONT  TestAccRoute53Record_Support_caa
--- PASS: TestAccRoute53Record_cidr (386.68s)
=== CONT  TestAccRoute53Record_Disappears_multipleRecords
--- PASS: TestAccRoute53Record_Weighted_basic (202.91s)
=== CONT  TestAccRoute53Record_disappears
--- PASS: TestAccRoute53Record_underscored (177.97s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
--- PASS: TestAccRoute53Record_Support_spf (181.46s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_latency
--- PASS: TestAccRoute53Record_Support_txt (211.35s)
=== CONT  TestAccRoute53Record_typeChange
--- PASS: TestAccRoute53Record_fqdn (168.96s)
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53Record_empty (166.57s)
=== CONT  TestAccRoute53Record_setIdentifierChangeBasicToWeighted
--- PASS: TestAccRoute53Record_longTXTrecord (166.49s)
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (169.31s)
--- PASS: TestAccRoute53Record_trailingPeriodAndZoneID (189.48s)
--- PASS: TestAccRoute53Record_Allow_doNotOverwrite (180.13s)
--- PASS: TestAccRoute53Record_wildcard (249.75s)
--- PASS: TestAccRoute53Record_Allow_overwrite (204.26s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_weighted (212.88s)
--- PASS: TestAccRoute53Record_Alias_changeDualstack (218.30s)
--- PASS: TestAccRoute53Record_Support_ds (177.72s)
--- PASS: TestAccRoute53Record_Alias_change (188.15s)
--- PASS: TestAccRoute53Record_disappears (151.63s)
--- PASS: TestAccRoute53Record_Support_caa (172.17s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationContinent (199.20s)
--- PASS: TestAccRoute53Record_Latency_basic (155.95s)
--- PASS: TestAccRoute53Record_typeChange (178.69s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_multiValueAnswer (215.40s)
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (236.04s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_latency (245.06s)
--- PASS: TestAccRoute53Record_nameChange (269.80s)
--- PASS: TestAccRoute53Record_setIdentifierChangeBasicToWeighted (241.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    668.635s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/route53 Issues and PRs that pertain to the route53 service. labels May 16, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 16, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@nam054 nam054 marked this pull request as ready for review May 16, 2024 18:43
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Needs a CHANGELOG entry.

@nam054 nam054 merged commit 3f8353c into main May 16, 2024
34 checks passed
@nam054 nam054 deleted the b-route53-region branch May 16, 2024 19:47
@github-actions github-actions bot added this to the v5.50.0 milestone May 16, 2024
github-actions bot pushed a commit that referenced this pull request May 16, 2024
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
@ewbankkit
Copy link
Contributor

Relates #32085 (where us-west-2 was introduced by mistake).

Copy link

github-actions bot commented Jul 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: wrong region used for requests to route53
2 participants