Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appflow Glue Integration and allow setting pathPrefixHierarchy #37566

Merged
merged 11 commits into from
Jul 24, 2024

Conversation

nickmhankins
Copy link

Description

Adds Glue integration with Appflow (metadata_catalog_config) and allows setting the prefix_hierarchy properties.

Relations

Closes #29007
Closes #31874
Closes #34638

References

https://docs.aws.amazon.com/appflow/1.0/APIReference/API_PrefixConfig.html
https://docs.aws.amazon.com/appflow/1.0/APIReference/API_GlueDataCatalogConfig.html

Output from Acceptance Testing

❯ make testacc TESTS=TestAccAppFlowFlow_metadata_catalog  PKG=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appflow/... -v -count 1 -parallel 20 -run='TestAccAppFlowFlow_metadata_catalog'  -timeout 360m
=== RUN   TestAccAppFlowFlow_metadata_catalog
=== PAUSE TestAccAppFlowFlow_metadata_catalog
=== CONT  TestAccAppFlowFlow_metadata_catalog
--- PASS: TestAccAppFlowFlow_metadata_catalog (28.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	32.914s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appflow Issues and PRs that pertain to the appflow service. size/L Managed by automation to categorize the size of a PR. labels May 16, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 16, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @nickmhankins 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 16, 2024
@nsb413
Copy link

nsb413 commented May 28, 2024

image
Unable to uncheck Execution ID via Terraform-aws 5.46.0

@johnsonaj johnsonaj self-assigned this Jul 23, 2024
@johnsonaj johnsonaj requested a review from a team as a code owner July 23, 2024 21:34
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccAppFlowFlow_metadataCatalog\|TestAccAppFlowFlow_basic\|TestAccAppFlowFlow_disappears" PKG=appflow

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_metadataCatalog\|TestAccAppFlowFlow_basic\|TestAccAppFlowFlow_disappears -timeout 360m
--- PASS: TestAccAppFlowFlow_disappears (17.48s)
--- PASS: TestAccAppFlowFlow_basic (18.14s)
--- PASS: TestAccAppFlowFlow_metadataCatalog (20.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	26.333s

@johnsonaj
Copy link
Contributor

@nickmhankins thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 3a29801 into hashicorp:main Jul 24, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.60.0 milestone Jul 24, 2024
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appflow Issues and PRs that pertain to the appflow service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
4 participants