Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: Add support for Grafana Service Account and Token #37645

Closed
gingersnapz opened this issue May 22, 2024 · 7 comments · Fixed by #38101
Closed

[New Resource]: Add support for Grafana Service Account and Token #37645

gingersnapz opened this issue May 22, 2024 · 7 comments · Fixed by #38101
Labels
new-resource Introduces a new resource. service/grafana Issues and PRs that pertain to the grafana service.
Milestone

Comments

@gingersnapz
Copy link

Description

With the 10.4 version release for AWS Managed Grafana, new APIs were introduced to manage service accounts and service account tokens.

Requested Resource(s) and/or Data Source(s)

aws_grafana_workspace_service_account
aws_grafana_workspace_service_account_token

Potential Terraform Configuration

resource "aws_grafana_workspace_service_account" "example" {
  grafana_role_name  = "ADMIN"
  name               = "myAdmin"
  workspace_id       = "grafana_workspace_id"
}

resource "aws_grafana_workspace_service_account_token" "tkn" {
  name               = "admin_token_a"
  service_account_id = aws_grafana_workspace_service_account.example.id
  seconds_to_live    = 3600
  workspace_id       = "grafana_workspace_id"
}

References

https://docs.aws.amazon.com/grafana/latest/APIReference/API_Operations.html
https://aws.amazon.com/about-aws/whats-new/2024/05/amazon-managed-grafana-supports-version-10-4/
https://docs.aws.amazon.com/sdk-for-go/api/service/managedgrafana/

Would you like to implement a fix?

No

@github-actions github-actions bot added the service/grafana Issues and PRs that pertain to the grafana service. label May 22, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 22, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 24, 2024
@bonclay7
Copy link
Contributor

Interested to take this one

@aristosvo
Copy link
Contributor

aristosvo commented Jun 3, 2024

@bonclay7 did you already look at Go SDK v2 for the Grafana Service? FYI, I've picked that one up in #37831.

@bonclay7
Copy link
Contributor

@aristosvo Thanks for this. I was going to implement only the new resources in v2

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.59.0 milestone Jul 12, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/grafana Issues and PRs that pertain to the grafana service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants