Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate tagging tests for CloudWatch and CloudWatch Logs #37668

Merged
merged 9 commits into from
Jun 4, 2024
Merged

Generate tagging tests for CloudWatch and CloudWatch Logs #37668

merged 9 commits into from
Jun 4, 2024

Conversation

gdavison
Copy link
Contributor

Description

Generate tagging tests for CloudWatch and CloudWatch Logs

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. generators Relates to code generators. service/logs Issues and PRs that pertain to the logs service. labels May 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 23, 2024
@gdavison gdavison force-pushed the td-generate-tagtests-cloudwatch-core branch from 65fcce8 to fc6f95d Compare May 24, 2024 19:21
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@gdavison gdavison force-pushed the td-generate-tagtests-cloudwatch-core branch 2 times, most recently from 03989ef to e6ca1f3 Compare June 1, 2024 06:58
ewbankkit
ewbankkit approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison force-pushed the td-generate-tagtests-cloudwatch-core branch from e6ca1f3 to bdeba92 Compare June 4, 2024 19:01
@gdavison gdavison merged commit 48694a7 into main Jun 4, 2024
38 checks passed
@gdavison gdavison deleted the td-generate-tagtests-cloudwatch-core branch June 4, 2024 19:58
@github-actions github-actions bot added this to the v5.53.0 milestone Jun 4, 2024
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Update CHANGELOG.md for #37668
1e912eb
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jinnko jinnko mentioned this pull request Jun 11, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/logs Issues and PRs that pertain to the logs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.53.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit