Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_vpc_endpoint: Fix private_dns_enabled when false or undefined #37715

Merged
merged 10 commits into from
Jun 4, 2024
Merged

r/aws_vpc_endpoint: Fix private_dns_enabled when false or undefined #37715

merged 10 commits into from
Jun 4, 2024

Conversation

theipster
Copy link
Contributor

@theipster theipster commented May 26, 2024 •
edited
Loading

Description

The API documentation for the CreateVpcEndpoint operation documents that the PrivateDnsEnabled attribute defaults to true, whereas this TF provider's aws_vpc_endpoint resource's private_dns_enabled attribute defaults to false (at least, prior to bug).

This means that if the user wants the attribute to be false (either by explicitly configuring private_dns_enabled = false or leaving private_dns_enabled undefined), then the aws_vpc_endpoint resource implementation must explicitly pass PrivateDnsEnabled = false in the SDK call.

Notes

Appreciate there's a recently introduced resource aws_vpc_endpoint_private_dns, which is designed to take precedence over aws_vpc_endpoint.private_dns_enabled, and if used in conjunction with this fix will cause drift (if aws_vpc_endpoint.private_dns_enabled is undefined, then one-off drift; if defined and not equal to the aws_vpc_endpoint_private_dns.private_dns_enabled, then perpetual drift).

However, introducing some drift is still preferable than a regression / breaking change, which is the case without this fix. Furthermore, the documentation for aws_vpc_endpoint_private_dns sufficiently documents and discourages this conflicting usage.

Relations

Closes #37694

References

Output from Acceptance Testing

$ make testacc PKG=ec2 TESTS="TestAccVPCEndpoint_|TestAccVPCEndpointPrivateDNS_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpoint_|TestAccVPCEndpointPrivateDNS_'  -timeout 360m
=== RUN   TestAccVPCEndpointPrivateDNS_basic
=== PAUSE TestAccVPCEndpointPrivateDNS_basic
=== RUN   TestAccVPCEndpointPrivateDNS_disabled
=== PAUSE TestAccVPCEndpointPrivateDNS_disabled
=== RUN   TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== PAUSE TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== RUN   TestAccVPCEndpointPrivateDNS_update
=== PAUSE TestAccVPCEndpointPrivateDNS_update
=== RUN   TestAccVPCEndpoint_gatewayBasic
=== PAUSE TestAccVPCEndpoint_gatewayBasic
=== RUN   TestAccVPCEndpoint_interfaceBasic
=== PAUSE TestAccVPCEndpoint_interfaceBasic
=== RUN   TestAccVPCEndpoint_interfaceNoPrivateDNS
=== PAUSE TestAccVPCEndpoint_interfaceNoPrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNS
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== RUN   TestAccVPCEndpoint_disappears
=== PAUSE TestAccVPCEndpoint_disappears
=== RUN   TestAccVPCEndpoint_tags
=== PAUSE TestAccVPCEndpoint_tags
=== RUN   TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccVPCEndpoint_gatewayPolicy
=== PAUSE TestAccVPCEndpoint_gatewayPolicy
=== RUN   TestAccVPCEndpoint_ignoreEquivalent
=== PAUSE TestAccVPCEndpoint_ignoreEquivalent
=== RUN   TestAccVPCEndpoint_ipAddressType
=== PAUSE TestAccVPCEndpoint_ipAddressType
=== RUN   TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== PAUSE TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT  TestAccVPCEndpoint_gatewayBasic
=== CONT  TestAccVPCEndpoint_gatewayPolicy
=== CONT  TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT  TestAccVPCEndpointPrivateDNS_basic
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== CONT  TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== CONT  TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== CONT  TestAccVPCEndpoint_ipAddressType
=== CONT  TestAccVPCEndpoint_ignoreEquivalent
=== CONT  TestAccVPCEndpointPrivateDNS_disabled
=== CONT  TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== CONT  TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== CONT  TestAccVPCEndpoint_tags
=== CONT  TestAccVPCEndpointPrivateDNS_update
=== CONT  TestAccVPCEndpoint_disappears
=== CONT  TestAccVPCEndpoint_interfaceNoPrivateDNS
=== CONT  TestAccVPCEndpoint_interfacePrivateDNS
=== CONT  TestAccVPCEndpoint_interfaceBasic
--- PASS: TestAccVPCEndpoint_disappears (145.69s)
--- PASS: TestAccVPCEndpointPrivateDNS_disabled (147.63s)
--- PASS: TestAccVPCEndpointPrivateDNS_disappears_Endpoint (150.40s)
--- PASS: TestAccVPCEndpoint_gatewayBasic (172.73s)
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (177.60s)
--- PASS: TestAccVPCEndpointPrivateDNS_update (195.54s)
--- PASS: TestAccVPCEndpointPrivateDNS_basic (199.09s)
--- PASS: TestAccVPCEndpoint_interfaceNoPrivateDNS (206.86s)
--- PASS: TestAccVPCEndpoint_interfaceBasic (209.75s)
--- PASS: TestAccVPCEndpoint_gatewayPolicy (215.74s)
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (221.40s)
--- PASS: TestAccVPCEndpoint_tags (224.66s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (363.21s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (368.18s)
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (417.41s)
--- PASS: TestAccVPCEndpoint_ipAddressType (429.22s)
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (463.90s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (522.97s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNS (584.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        585.177s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/vpc Issues and PRs that pertain to the vpc service. labels May 26, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 26, 2024
@theipster
Copy link
Contributor Author

Before taking this PR out of draft, I'm tempted to add an additional test for the explicit private_dns_enabled = false scenario.

@theipster
Copy link
Contributor Author

New test:

make testacc PKG=ec2 TESTS="TestAccVPCEndpoint_interfaceNoPrivateDNS"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpoint_interfaceNoPrivateDNS'  -timeout 360m
=== RUN   TestAccVPCEndpoint_interfaceNoPrivateDNS
=== PAUSE TestAccVPCEndpoint_interfaceNoPrivateDNS
=== CONT  TestAccVPCEndpoint_interfaceNoPrivateDNS
--- PASS: TestAccVPCEndpoint_interfaceNoPrivateDNS (131.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        132.434s

@theipster theipster changed the title r/aws_vpc_endpoint: Fix private_dns_enabled = false (or undefined) r/aws_vpc_endpoint: Fix private_dns_enabled when false or undefined May 26, 2024
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels May 26, 2024
@theipster
Copy link
Contributor Author

Further tests:

$ make testacc PKG=ec2 TESTS="TestAccVPCEndpointPrivateDNS_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointPrivateDNS_'  -timeout 360m
=== RUN   TestAccVPCEndpointPrivateDNS_basic
=== PAUSE TestAccVPCEndpointPrivateDNS_basic
=== RUN   TestAccVPCEndpointPrivateDNS_disabled
=== PAUSE TestAccVPCEndpointPrivateDNS_disabled
=== RUN   TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== PAUSE TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== RUN   TestAccVPCEndpointPrivateDNS_update
=== PAUSE TestAccVPCEndpointPrivateDNS_update
=== CONT  TestAccVPCEndpointPrivateDNS_basic
=== CONT  TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== CONT  TestAccVPCEndpointPrivateDNS_disabled
=== CONT  TestAccVPCEndpointPrivateDNS_update
--- PASS: TestAccVPCEndpointPrivateDNS_disabled (91.20s)
--- PASS: TestAccVPCEndpointPrivateDNS_basic (171.95s)
--- PASS: TestAccVPCEndpointPrivateDNS_disappears_Endpoint (180.20s)
--- PASS: TestAccVPCEndpointPrivateDNS_update (219.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        219.365s

Alan Ip added 4 commits May 26, 2024 17:09
@theipster
Add test for explicit private_dns_enabled = false
19ee7c7
@theipster
Add test for explicit `aws_vpc_endpoint_private_dns.private_dns_enabl…
f14d1b7 
…ed = false` too.
@theipster
Re-implement default value (false) for PrivateDnsEnabled flag
f34a04e 
AWS SDK endpoint defaults to true, whereas TF provider defaults to false (at least, prior to bug).

Appreciate there's a new resource `aws_vpc_endpoint_private_dns`, which is designed to take precedence over `aws_vpc_endpoint.private_dns_enabled`, which this re-implementation of will cause drift (if undefined, then one-off drift; if defined and not equal to the `aws_vpc_endpoint_private_dns.private_dns_enabled`, then perpetual drift). However, introducing some drift is still preferable than a regression / breaking change.
@theipster
Add changelog entry
a23338a
@theipster theipster force-pushed the fix-vpc-endpoint-private-dns-enabled branch from 906459e to f14d1b7 Compare May 26, 2024 19:35
@theipster
Copy link
Contributor Author

And for completeness, proving that the same tests are failing without the fix in place:

$ make testacc PKG=ec2 TESTS="TestAccVPCEndpoint_|TestAccVPCEndpointPrivateDNS_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpoint_|TestAccVPCEndpointPrivateDNS_'  -timeout 360m
=== RUN   TestAccVPCEndpointPrivateDNS_basic
=== PAUSE TestAccVPCEndpointPrivateDNS_basic
=== RUN   TestAccVPCEndpointPrivateDNS_disabled
=== PAUSE TestAccVPCEndpointPrivateDNS_disabled
=== RUN   TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== PAUSE TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== RUN   TestAccVPCEndpointPrivateDNS_update
=== PAUSE TestAccVPCEndpointPrivateDNS_update
=== RUN   TestAccVPCEndpoint_gatewayBasic
=== PAUSE TestAccVPCEndpoint_gatewayBasic
=== RUN   TestAccVPCEndpoint_interfaceBasic
=== PAUSE TestAccVPCEndpoint_interfaceBasic
=== RUN   TestAccVPCEndpoint_interfaceNoPrivateDNS
=== PAUSE TestAccVPCEndpoint_interfaceNoPrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNS
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== RUN   TestAccVPCEndpoint_disappears
=== PAUSE TestAccVPCEndpoint_disappears
=== RUN   TestAccVPCEndpoint_tags
=== PAUSE TestAccVPCEndpoint_tags
=== RUN   TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccVPCEndpoint_gatewayPolicy
=== PAUSE TestAccVPCEndpoint_gatewayPolicy
=== RUN   TestAccVPCEndpoint_ignoreEquivalent
=== PAUSE TestAccVPCEndpoint_ignoreEquivalent
=== RUN   TestAccVPCEndpoint_ipAddressType
=== PAUSE TestAccVPCEndpoint_ipAddressType
=== RUN   TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== PAUSE TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT  TestAccVPCEndpointPrivateDNS_basic
=== CONT  TestAccVPCEndpoint_tags
=== CONT  TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== CONT  TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== CONT  TestAccVPCEndpoint_ipAddressType
=== CONT  TestAccVPCEndpoint_ignoreEquivalent
=== CONT  TestAccVPCEndpoint_gatewayPolicy
=== CONT  TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== CONT  TestAccVPCEndpoint_interfaceBasic
=== CONT  TestAccVPCEndpoint_disappears
=== CONT  TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== CONT  TestAccVPCEndpoint_interfacePrivateDNS
=== CONT  TestAccVPCEndpoint_interfaceNoPrivateDNS
=== CONT  TestAccVPCEndpointPrivateDNS_update
=== CONT  TestAccVPCEndpoint_gatewayBasic
=== CONT  TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== CONT  TestAccVPCEndpointPrivateDNS_disabled
=== NAME  TestAccVPCEndpoint_interfaceNoPrivateDNS
    vpc_endpoint_test.go:116: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating EC2 VPC Endpoint (com.amazonaws.eu-west-1.ec2): operation error EC2: CreateVpcEndpoint, https response error StatusCode: 400, RequestID: 13e4610f-884b-4803-b7c8-c13a5db92fbc, api error InvalidParameter: Enabling private DNS requires both enableDnsSupport and enableDnsHostnames VPC attributes set to true for vpc-09a6058864bc29dee
        
          with aws_vpc_endpoint.test,
          on terraform_plugin_test.tf line 22, in resource "aws_vpc_endpoint" "test":
          22: resource "aws_vpc_endpoint" "test" {
        
=== NAME  TestAccVPCEndpoint_interfaceBasic
    vpc_endpoint_test.go:72: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating EC2 VPC Endpoint (com.amazonaws.eu-west-1.ec2): operation error EC2: CreateVpcEndpoint, https response error StatusCode: 400, RequestID: 690febc4-0bd3-4ec5-b9fb-3fc6e3ca99a6, api error InvalidParameter: Enabling private DNS requires both enableDnsSupport and enableDnsHostnames VPC attributes set to true for vpc-0fbaae57225283b9c
        
          with aws_vpc_endpoint.test,
          on terraform_plugin_test.tf line 22, in resource "aws_vpc_endpoint" "test":
          22: resource "aws_vpc_endpoint" "test" {
        
=== NAME  TestAccVPCEndpointPrivateDNS_disabled
    vpc_endpoint_private_dns_test.go:74: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating EC2 VPC Endpoint (com.amazonaws.eu-west-1.ec2): operation error EC2: CreateVpcEndpoint, https response error StatusCode: 400, RequestID: 8811ef0e-0427-4e13-9cdd-06bfc8af3014, api error InvalidParameter: Enabling private DNS requires both enableDnsSupport and enableDnsHostnames VPC attributes set to true for vpc-0e429663f50dc9428
        
          with aws_vpc_endpoint.test,
          on terraform_plugin_test.tf line 22, in resource "aws_vpc_endpoint" "test":
          22: resource "aws_vpc_endpoint" "test" {
        
--- FAIL: TestAccVPCEndpoint_interfaceNoPrivateDNS (100.30s)
--- FAIL: TestAccVPCEndpoint_interfaceBasic (100.40s)
--- FAIL: TestAccVPCEndpointPrivateDNS_disabled (100.67s)
--- PASS: TestAccVPCEndpoint_disappears (168.03s)
--- PASS: TestAccVPCEndpoint_gatewayBasic (179.64s)
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (199.34s)
=== NAME  TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
    vpc_endpoint_test.go:483: Step 1/3 error: After applying this test step, the non-refresh plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_vpc_endpoint.test will be updated in-place
          ~ resource "aws_vpc_endpoint" "test" {
                id                    = "vpce-026ef09596ae5bef8"
              ~ private_dns_enabled   = true -> false
                tags                  = {
                    "Name" = "tf-acc-test-8479936531020150750"
                }
                # (16 unchanged attributes hidden)
        
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccVPCEndpointPrivateDNS_disappears_Endpoint (260.56s)
--- PASS: TestAccVPCEndpoint_gatewayPolicy (260.66s)
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (272.17s)
--- PASS: TestAccVPCEndpoint_tags (282.44s)
--- PASS: TestAccVPCEndpointPrivateDNS_basic (310.50s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (341.61s)
--- PASS: TestAccVPCEndpointPrivateDNS_update (356.04s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (394.39s)
--- FAIL: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (415.18s)
--- PASS: TestAccVPCEndpoint_ipAddressType (462.08s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (482.52s)
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (487.79s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNS (612.36s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ec2        612.799s
FAIL

@theipster theipster marked this pull request as ready for review May 26, 2024 21:35
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 28, 2024
@theipster
Copy link
Contributor Author

Hi, any news on this please? It's ready for review.

@ewbankkit ewbankkit self-assigned this Jun 4, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 4, 2024
ewbankkit
ewbankkit approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCEndpoint_\|TestAccVPCEndpointPrivateDNS_' PKG=ec2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccVPCEndpoint_\|TestAccVPCEndpointPrivateDNS_ -timeout 360m
=== RUN   TestAccVPCEndpointPrivateDNS_basic
=== PAUSE TestAccVPCEndpointPrivateDNS_basic
=== RUN   TestAccVPCEndpointPrivateDNS_disabled
=== PAUSE TestAccVPCEndpointPrivateDNS_disabled
=== RUN   TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== PAUSE TestAccVPCEndpointPrivateDNS_disappears_Endpoint
=== RUN   TestAccVPCEndpointPrivateDNS_update
=== PAUSE TestAccVPCEndpointPrivateDNS_update
=== RUN   TestAccVPCEndpoint_gatewayBasic
=== PAUSE TestAccVPCEndpoint_gatewayBasic
=== RUN   TestAccVPCEndpoint_interfaceBasic
=== PAUSE TestAccVPCEndpoint_interfaceBasic
=== RUN   TestAccVPCEndpoint_interfaceNoPrivateDNS
=== PAUSE TestAccVPCEndpoint_interfaceNoPrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNS
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== RUN   TestAccVPCEndpoint_disappears
=== PAUSE TestAccVPCEndpoint_disappears
=== RUN   TestAccVPCEndpoint_tags
=== PAUSE TestAccVPCEndpoint_tags
=== RUN   TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccVPCEndpoint_gatewayPolicy
=== PAUSE TestAccVPCEndpoint_gatewayPolicy
=== RUN   TestAccVPCEndpoint_ignoreEquivalent
=== PAUSE TestAccVPCEndpoint_ignoreEquivalent
=== RUN   TestAccVPCEndpoint_ipAddressType
=== PAUSE TestAccVPCEndpoint_ipAddressType
=== RUN   TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== PAUSE TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT  TestAccVPCEndpointPrivateDNS_basic
=== CONT  TestAccVPCEndpoint_tags
=== CONT  TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccVPCEndpoint_tags (57.95s)
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccVPCEndpointPrivateDNS_basic (144.41s)
=== CONT  TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (308.16s)
=== CONT  TestAccVPCEndpoint_ipAddressType
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (272.29s)
=== CONT  TestAccVPCEndpoint_ignoreEquivalent
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (350.41s)
=== CONT  TestAccVPCEndpoint_gatewayPolicy
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (33.30s)
=== CONT  TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccVPCEndpoint_gatewayPolicy (48.18s)
=== CONT  TestAccVPCEndpoint_interfaceBasic
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (47.18s)
=== CONT  TestAccVPCEndpoint_disappears
--- PASS: TestAccVPCEndpoint_disappears (25.61s)
=== CONT  TestAccVPCEndpoint_interfacePrivateDNSNoGateway
--- PASS: TestAccVPCEndpoint_interfaceBasic (43.60s)
=== CONT  TestAccVPCEndpoint_interfacePrivateDNS
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (341.44s)
=== CONT  TestAccVPCEndpoint_interfaceNoPrivateDNS
--- PASS: TestAccVPCEndpoint_interfaceNoPrivateDNS (77.96s)
=== CONT  TestAccVPCEndpointPrivateDNS_update
--- PASS: TestAccVPCEndpoint_ipAddressType (318.50s)
=== CONT  TestAccVPCEndpoint_gatewayBasic
--- PASS: TestAccVPCEndpoint_gatewayBasic (28.01s)
=== CONT  TestAccVPCEndpointPrivateDNS_disappears_Endpoint
--- PASS: TestAccVPCEndpointPrivateDNS_update (202.70s)
=== CONT  TestAccVPCEndpointPrivateDNS_disabled
--- PASS: TestAccVPCEndpointPrivateDNS_disappears_Endpoint (127.90s)
--- PASS: TestAccVPCEndpointPrivateDNS_disabled (63.81s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (464.42s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNS (478.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	925.199s

@ewbankkit ewbankkit merged commit 48ac09e into hashicorp:main Jun 4, 2024
37 checks passed
@github-actions github-actions bot added this to the v5.53.0 milestone Jun 4, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@theipster theipster deleted the fix-vpc-endpoint-private-dns-enabled branch June 15, 2024 13:53
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
bug Addresses a defect in current functionality. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.53.0
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_vpc_endpoint resource: private_dns_enabled effectively stuck on true.
3 participants
@theipster @ewbankkit @justinretzolk