r/aws_route53_zone: Use zone_id for transparent tagging identifier

[ewbankkit]

Description

Use zone_id, not id, as the transparent tagging idemtifier to work around AWS SDK for Go v2 backwards compatibility issue.

Relations

Closes #37817.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRoute53Zone_' PKG=route53 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53Zone_ -timeout 360m
=== RUN   TestAccRoute53Zone_basic
=== PAUSE TestAccRoute53Zone_basic
=== RUN   TestAccRoute53Zone_disappears
=== PAUSE TestAccRoute53Zone_disappears
=== RUN   TestAccRoute53Zone_multiple
=== PAUSE TestAccRoute53Zone_multiple
=== RUN   TestAccRoute53Zone_comment
=== PAUSE TestAccRoute53Zone_comment
=== RUN   TestAccRoute53Zone_delegationSetID
=== PAUSE TestAccRoute53Zone_delegationSetID
=== RUN   TestAccRoute53Zone_forceDestroy
=== PAUSE TestAccRoute53Zone_forceDestroy
=== RUN   TestAccRoute53Zone_ForceDestroy_trailingPeriod
=== PAUSE TestAccRoute53Zone_ForceDestroy_trailingPeriod
=== RUN   TestAccRoute53Zone_tags
=== PAUSE TestAccRoute53Zone_tags
=== RUN   TestAccRoute53Zone_VPC_single
=== PAUSE TestAccRoute53Zone_VPC_single
=== RUN   TestAccRoute53Zone_VPC_multiple
=== PAUSE TestAccRoute53Zone_VPC_multiple
=== RUN   TestAccRoute53Zone_VPC_updates
=== PAUSE TestAccRoute53Zone_VPC_updates
=== RUN   TestAccRoute53Zone_VPC_single_forceDestroy
=== PAUSE TestAccRoute53Zone_VPC_single_forceDestroy
=== CONT  TestAccRoute53Zone_basic
=== CONT  TestAccRoute53Zone_VPC_multiple
=== CONT  TestAccRoute53Zone_ForceDestroy_trailingPeriod
--- PASS: TestAccRoute53Zone_basic (95.55s)
=== CONT  TestAccRoute53Zone_comment
--- PASS: TestAccRoute53Zone_VPC_multiple (195.60s)
=== CONT  TestAccRoute53Zone_forceDestroy
--- PASS: TestAccRoute53Zone_comment (102.96s)
=== CONT  TestAccRoute53Zone_delegationSetID
--- PASS: TestAccRoute53Zone_ForceDestroy_trailingPeriod (265.15s)
=== CONT  TestAccRoute53Zone_multiple
--- PASS: TestAccRoute53Zone_delegationSetID (98.32s)
=== CONT  TestAccRoute53Zone_VPC_single_forceDestroy
--- PASS: TestAccRoute53Zone_multiple (103.94s)
=== CONT  TestAccRoute53Zone_VPC_updates
--- PASS: TestAccRoute53Zone_forceDestroy (279.56s)
=== CONT  TestAccRoute53Zone_disappears
--- PASS: TestAccRoute53Zone_VPC_single_forceDestroy (238.84s)
=== CONT  TestAccRoute53Zone_VPC_single
--- PASS: TestAccRoute53Zone_disappears (92.81s)
=== CONT  TestAccRoute53Zone_tags
--- PASS: TestAccRoute53Zone_VPC_updates (271.23s)
--- PASS: TestAccRoute53Zone_VPC_single (124.37s)
--- PASS: TestAccRoute53Zone_tags (124.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	696.831s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.