Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drs: Fix replication configuration template #38143

Merged
merged 19 commits into from
Jun 27, 2024

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jun 26, 2024

Description

Adds fixes and information to enable actual usage of the resource.

Relations

Relates #21865
Relates #26399
Relates #37816

References

Output from Acceptance Testing

% make t T=TestAccDRSReplicationConfigurationTemplate_serial K=drs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/drs/... -v -count 1 -parallel 20 -run='TestAccDRSReplicationConfigurationTemplate_serial'  -timeout 360m
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial
=== PAUSE TestAccDRSReplicationConfigurationTemplate_serial
=== CONT  TestAccDRSReplicationConfigurationTemplate_serial
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/basic
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/disappears
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial (185.20s)
    --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/basic (94.53s)
    --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/disappears (90.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/drs	187.661s

@YakDriver YakDriver requested a review from a team as a code owner June 26, 2024 18:56
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/drs Issues and PRs that pertain to the drs service. labels Jun 26, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 26, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. create Pertains to generating names, hashcodes, etc. size/L Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. create Pertains to generating names, hashcodes, etc. labels Jun 26, 2024
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jun 26, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. examples Introduces or discusses updates to examples. create Pertains to generating names, hashcodes, etc. labels Jun 26, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDRSReplicationConfigurationTemplate_serial' PKG=drs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/drs/... -v -count 1 -parallel 20  -run=TestAccDRSReplicationConfigurationTemplate_serial -timeout 360m
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial
=== PAUSE TestAccDRSReplicationConfigurationTemplate_serial
=== CONT  TestAccDRSReplicationConfigurationTemplate_serial
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/basic
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/disappears
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial (175.21s)
    --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/basic (89.30s)
    --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/disappears (85.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/drs	179.476s

@YakDriver YakDriver merged commit afa0f24 into main Jun 27, 2024
48 checks passed
@YakDriver YakDriver deleted the b-drs-replication_configuration_template branch June 27, 2024 15:10
@github-actions github-actions bot added this to the v5.56.0 milestone Jun 27, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jun 27, 2024
Copy link

This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 27, 2024
Copy link

github-actions bot commented Aug 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create Pertains to generating names, hashcodes, etc. documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. service/drs Issues and PRs that pertain to the drs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants