Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add jupyter_lab_app_settings block to default_space_settings in aws_sagemaker_domain #38150

Closed
philipgebus opened this issue Jun 27, 2024 · 4 comments · Fixed by #38457
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Milestone

Comments

@philipgebus
Copy link

Description

SageMaker Studio now supports Shared JupyterLab spaces. In order to configure custom lifecycle configuration scripts, images etc. for shared spaces, a jupyter_lab_app_settings block needs to be added to the aws_sagemaker_domain.default_space_settings block.

Affected Resource(s) and/or Data Source(s)

aws_sagemaker_domain

Potential Terraform Configuration

resource "aws_sagemaker_domain" "this" {
  # other attributes ...
  
  default_space_settings {
    jupyter_lab_app_settings {
      code_repository {
        repository_url = "https://github.com/my_repo"
      }
      default_resource_spec {
        instance_type        = "ml.t3.medium"
        lifecycle_config_arn = aws_sagemaker_studio_lifecycle_config.jupyterlab.arn
        # sagemaker_image_arn
        # sagemaker_image_version_alias
        # sagemaker_image_version_arn
      }
      lifecycle_config_arns = [aws_sagemaker_studio_lifecycle_config.jupyterlab.arn]
      custom_image {
        app_image_config_name = aws_sagemaker_app_image_config.jupyterlab.id
        image_name            = aws_sagemaker_image.jupyterlab.id
      }
    }
  }
}

References

  1. https://pkg.go.dev/github.com/aws/aws-sdk-go@v1.54.9/service/sagemaker#DefaultSpaceSettings
  2. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sagemaker/client/create_domain.html

Would you like to implement a fix?

No

@philipgebus philipgebus added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 27, 2024
@github-actions github-actions bot added the service/sagemaker Issues and PRs that pertain to the sagemaker service. label Jun 27, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 27, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 27, 2024
Copy link

github-actions bot commented Sep 9, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.67.0 milestone Sep 9, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
2 participants