r/aws_cognito_user: Fix resource recreation for pre-v5.56.0 resources imported with certain import IDs

[ewbankkit]

Description

Prior to Terraform AWS Provider v5.56.0 the resource ID wasn't parsed during Read/Update/Delete -- the configured user_pool_id and username attributes were referenced directly.
This means that if a pre-existing resource had a resource ID that didn't match user_pool_id/username, after upgrading to v5.56.0 the resource would show as to-be-recreated in terraform plan.
This PR restores the functionality of referencing the attributes directly.

Relations

Closes #38175.
Relates #37024.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCognitoIDPUser_' PKG=cognitoidp ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/cognitoidp/... -v -count 1 -parallel 3  -run=TestAccCognitoIDPUser_ -timeout 360m
=== RUN   TestAccCognitoIDPUser_basic
=== PAUSE TestAccCognitoIDPUser_basic
=== RUN   TestAccCognitoIDPUser_disappears
=== PAUSE TestAccCognitoIDPUser_disappears
=== RUN   TestAccCognitoIDPUser_temporaryPassword
=== PAUSE TestAccCognitoIDPUser_temporaryPassword
=== RUN   TestAccCognitoIDPUser_password
=== PAUSE TestAccCognitoIDPUser_password
=== RUN   TestAccCognitoIDPUser_attributes
=== PAUSE TestAccCognitoIDPUser_attributes
=== RUN   TestAccCognitoIDPUser_enabled
=== PAUSE TestAccCognitoIDPUser_enabled
=== RUN   TestAccCognitoIDPUser_v5560Regression
=== PAUSE TestAccCognitoIDPUser_v5560Regression
=== CONT  TestAccCognitoIDPUser_basic
=== CONT  TestAccCognitoIDPUser_attributes
=== CONT  TestAccCognitoIDPUser_v5560Regression
--- PASS: TestAccCognitoIDPUser_basic (27.75s)
=== CONT  TestAccCognitoIDPUser_temporaryPassword
--- PASS: TestAccCognitoIDPUser_attributes (35.87s)
=== CONT  TestAccCognitoIDPUser_password
--- PASS: TestAccCognitoIDPUser_v5560Regression (44.73s)
=== CONT  TestAccCognitoIDPUser_disappears
--- PASS: TestAccCognitoIDPUser_temporaryPassword (27.42s)
=== CONT  TestAccCognitoIDPUser_enabled
--- PASS: TestAccCognitoIDPUser_disappears (10.81s)
--- PASS: TestAccCognitoIDPUser_password (27.31s)
--- PASS: TestAccCognitoIDPUser_enabled (20.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	79.931s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[johnsonaj]

LGTM 🚀

% make testacc TESTARGS='-run=TestAccCognitoIDPUser_' PKG=cognitoidp

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/cognitoidp/... -v -count 1 -parallel 20  -run=TestAccCognitoIDPUser_ -timeout 360m
--- PASS: TestAccCognitoIDPUser_disappears (21.18s)
--- PASS: TestAccCognitoIDPUser_basic (23.64s)
--- PASS: TestAccCognitoIDPUser_enabled (35.49s)
--- PASS: TestAccCognitoIDPUser_attributes (36.57s)
--- PASS: TestAccCognitoIDPUser_v5560Regression (37.61s)
--- PASS: TestAccCognitoIDPUser_password (46.75s)
--- PASS: TestAccCognitoIDPUser_temporaryPassword (46.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	52.444s

[github-actions]

This functionality has been released in v5.56.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.