Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New DataSource] List the Records in Route 53 #38186

Merged
7 commits merged into from
Jan 6, 2025

Conversation

Siddarthyuvaraj
Copy link
Contributor

@Siddarthyuvaraj Siddarthyuvaraj commented Jun 28, 2024

Description

aws_route53_record data source added.
Acceptance tests added for aws_route53_record data source
Website documentation added for aws_route53_record data source

Relations
Closes #31768
Closes #24045.
Closes #27851.
Closes #31703.

@Siddarthyuvaraj Siddarthyuvaraj requested a review from a team as a code owner June 28, 2024 18:11
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. generators Relates to code generators. labels Jun 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 28, 2024
Copy link

Hey @Siddarthyuvaraj 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@Siddarthyuvaraj Siddarthyuvaraj changed the title [New DataSource] List of Records in Route 53 [New DataSource] List the Records in Route 53 Jun 28, 2024
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 2, 2024
website/docs/d/route53_record.html.markdown Outdated Show resolved Hide resolved
website/docs/d/route53_record.html.markdown Outdated Show resolved Hide resolved
@Siddarthyuvaraj
Copy link
Contributor Author

Hi @erz4

I have made the changes that are suggested by you. Please review the changes and let me know.

Thank you

@Siddarthyuvaraj
Copy link
Contributor Author

Hi @justinretzolk , @erz4 ,

Any update on this PR. Any idea when it will be merged as its already been approved.

Thank you

@Siddarthyuvaraj
Copy link
Contributor Author

Hi @ewbankkit

Is this PR is good to merge? This is already been approved.

Thank you

@Siddarthyuvaraj
Copy link
Contributor Author

Hi @erz4 , @justinretzolk

Can this PR be prioritized?

Thank you

@justinretzolk
Copy link
Member

Hey @Siddarthyuvaraj 👋 Thanks for checking in here, and apologies that I'd missed your previous pings! I can't speak to when this will be prioritized just yet, unfortuantely. We base our prioritization on the count of 👍 reactions and a few other considerations. You can find a bit more information in our prioritization guide, if you're interested.

@samarthkathal
Copy link

hey @justinretzolk can this PR be merged? I would like to use this data source for my use-case where I am migrating existing DNS records from 1 account to another.
Thanks!

@ewbankkit
Copy link
Contributor

@Siddarthyuvaraj Thanks for the contribution 🎉 👏.
In order to get this merged for this week's release we completed the work in #40716.

@ewbankkit ewbankkit closed this pull request by merging all changes into hashicorp:main in 8bef658 Jan 6, 2025
@github-actions github-actions bot added this to the v5.83.0 milestone Jan 6, 2025
Copy link

github-actions bot commented Jan 9, 2025

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/route53 Issues and PRs that pertain to the route53 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
5 participants