Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tags support to aws_ssm_association #38271

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: Add tags support to aws_ssm_association #38271

merged 1 commit into from
Jul 8, 2024

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jul 7, 2024

Description

This PR is to add tags support to the aws_ssm_association resource.

Relations

Closes #33904

References

Referred to the API reference for specs.

Output from Acceptance Testing

$ make testacc TESTS=TestAccSSMAssociation_ PKG=ssm
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMAssociation_'  -timeout 360m
=== RUN   TestAccSSMAssociation_tags
=== PAUSE TestAccSSMAssociation_tags
=== RUN   TestAccSSMAssociation_tags_null
=== PAUSE TestAccSSMAssociation_tags_null
=== RUN   TestAccSSMAssociation_tags_AddOnUpdate
=== PAUSE TestAccSSMAssociation_tags_AddOnUpdate
=== RUN   TestAccSSMAssociation_tags_EmptyTag_OnCreate
=== PAUSE TestAccSSMAssociation_tags_EmptyTag_OnCreate
=== RUN   TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccSSMAssociation_tags_DefaultTags_providerOnly
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_providerOnly
=== RUN   TestAccSSMAssociation_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_nonOverlapping
=== RUN   TestAccSSMAssociation_tags_DefaultTags_overlapping
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_overlapping
=== RUN   TestAccSSMAssociation_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccSSMAssociation_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccSSMAssociation_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccSSMAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccSSMAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccSSMAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccSSMAssociation_tags_ComputedTag_OnCreate
=== PAUSE TestAccSSMAssociation_tags_ComputedTag_OnCreate
=== RUN   TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccSSMAssociation_basic
=== PAUSE TestAccSSMAssociation_basic
=== RUN   TestAccSSMAssociation_disappears
=== PAUSE TestAccSSMAssociation_disappears
=== RUN   TestAccSSMAssociation_disappears_document
=== PAUSE TestAccSSMAssociation_disappears_document
=== RUN   TestAccSSMAssociation_applyOnlyAtCronInterval
=== PAUSE TestAccSSMAssociation_applyOnlyAtCronInterval
=== RUN   TestAccSSMAssociation_withTargets
=== PAUSE TestAccSSMAssociation_withTargets
=== RUN   TestAccSSMAssociation_withParameters
=== PAUSE TestAccSSMAssociation_withParameters
=== RUN   TestAccSSMAssociation_withAssociationName
=== PAUSE TestAccSSMAssociation_withAssociationName
=== RUN   TestAccSSMAssociation_withAssociationNameAndScheduleExpression
=== PAUSE TestAccSSMAssociation_withAssociationNameAndScheduleExpression
=== RUN   TestAccSSMAssociation_withDocumentVersion
=== PAUSE TestAccSSMAssociation_withDocumentVersion
=== RUN   TestAccSSMAssociation_withOutputLocation
=== PAUSE TestAccSSMAssociation_withOutputLocation
=== RUN   TestAccSSMAssociation_withOutputLocation_s3Region
=== PAUSE TestAccSSMAssociation_withOutputLocation_s3Region
=== RUN   TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout
=== PAUSE TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout
=== RUN   TestAccSSMAssociation_withAutomationTargetParamName
=== PAUSE TestAccSSMAssociation_withAutomationTargetParamName
=== RUN   TestAccSSMAssociation_withScheduleExpression
=== PAUSE TestAccSSMAssociation_withScheduleExpression
=== RUN   TestAccSSMAssociation_withComplianceSeverity
=== PAUSE TestAccSSMAssociation_withComplianceSeverity
=== RUN   TestAccSSMAssociation_rateControl
=== PAUSE TestAccSSMAssociation_rateControl
=== RUN   TestAccSSMAssociation_syncCompliance
=== PAUSE TestAccSSMAssociation_syncCompliance
=== CONT  TestAccSSMAssociation_tags
=== CONT  TestAccSSMAssociation_basic
=== CONT  TestAccSSMAssociation_withDocumentVersion
=== CONT  TestAccSSMAssociation_withOutputLocation
=== CONT  TestAccSSMAssociation_withParameters
=== CONT  TestAccSSMAssociation_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccSSMAssociation_rateControl
=== CONT  TestAccSSMAssociation_withComplianceSeverity
=== CONT  TestAccSSMAssociation_withScheduleExpression
=== CONT  TestAccSSMAssociation_withAutomationTargetParamName
=== CONT  TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout
=== CONT  TestAccSSMAssociation_withOutputLocation_s3Region
=== CONT  TestAccSSMAssociation_withAssociationNameAndScheduleExpression
=== CONT  TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccSSMAssociation_tags_ComputedTag_OnCreate
=== CONT  TestAccSSMAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccSSMAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccSSMAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccSSMAssociation_syncCompliance
--- PASS: TestAccSSMAssociation_withDocumentVersion (42.61s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout (47.96s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccSSMAssociation_syncCompliance (53.49s)
=== CONT  TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccSSMAssociation_tags_DefaultTags_nullNonOverlappingResourceTag (57.13s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_overlapping
--- PASS: TestAccSSMAssociation_tags_DefaultTags_emptyProviderOnlyTag (57.56s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_nonOverlapping
--- PASS: TestAccSSMAssociation_tags_DefaultTags_nullOverlappingResourceTag (61.16s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_providerOnly
--- PASS: TestAccSSMAssociation_withScheduleExpression (67.78s)
=== CONT  TestAccSSMAssociation_withAssociationName
--- PASS: TestAccSSMAssociation_rateControl (68.37s)
=== CONT  TestAccSSMAssociation_tags_EmptyTag_OnCreate
--- PASS: TestAccSSMAssociation_tags_ComputedTag_OnCreate (71.58s)
=== CONT  TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (72.26s)
=== CONT  TestAccSSMAssociation_tags_AddOnUpdate
--- PASS: TestAccSSMAssociation_withComplianceSeverity (73.45s)
=== CONT  TestAccSSMAssociation_tags_null
--- PASS: TestAccSSMAssociation_withParameters (80.05s)
=== CONT  TestAccSSMAssociation_disappears_document
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (103.35s)
=== CONT  TestAccSSMAssociation_withTargets
--- PASS: TestAccSSMAssociation_tags_DefaultTags_emptyResourceTag (63.90s)
=== CONT  TestAccSSMAssociation_disappears
--- PASS: TestAccSSMAssociation_tags_DefaultTags_updateToProviderOnly (108.55s)
=== CONT  TestAccSSMAssociation_applyOnlyAtCronInterval
--- PASS: TestAccSSMAssociation_withOutputLocation (115.92s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (137.29s)
--- PASS: TestAccSSMAssociation_tags_DefaultTags_updateToResourceOnly (92.92s)
--- PASS: TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Replace (141.20s)
--- PASS: TestAccSSMAssociation_tags_null (68.78s)
--- PASS: TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Add (143.14s)
--- PASS: TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Replace (90.23s)
--- PASS: TestAccSSMAssociation_withAssociationName (77.64s)
--- PASS: TestAccSSMAssociation_basic (153.23s)
--- PASS: TestAccSSMAssociation_tags_AddOnUpdate (83.85s)
--- PASS: TestAccSSMAssociation_tags_EmptyTag_OnCreate (90.32s)
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (60.11s)
--- PASS: TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Add (111.10s)
--- PASS: TestAccSSMAssociation_withTargets (81.83s)
--- PASS: TestAccSSMAssociation_tags (187.07s)
--- PASS: TestAccSSMAssociation_tags_DefaultTags_nonOverlapping (129.66s)
--- PASS: TestAccSSMAssociation_tags_DefaultTags_overlapping (130.37s)
--- PASS: TestAccSSMAssociation_tags_DefaultTags_providerOnly (141.84s)
--- PASS: TestAccSSMAssociation_disappears_document (138.71s)
--- PASS: TestAccSSMAssociation_disappears (125.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        232.273s

$

@acwwat acwwat requested a review from a team as a code owner July 7, 2024 08:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ssm Issues and PRs that pertain to the ssm service. generators Relates to code generators. labels Jul 7, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jul 7, 2024
@acwwat acwwat force-pushed the f-aws_ssm_assoication-add_tags_support branch from e4e7a78 to 66c439a Compare July 7, 2024 08:16
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. tags Pertains to resource tagging. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 8, 2024
@ewbankkit ewbankkit self-assigned this Jul 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 8, 2024
ewbankkit
ewbankkit approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSMAssociation_' PKG=ssm ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/ssm/... -v -count 1 -parallel 3  -run=TestAccSSMAssociation_ -timeout 360m
=== RUN   TestAccSSMAssociation_tags
=== PAUSE TestAccSSMAssociation_tags
=== RUN   TestAccSSMAssociation_tags_null
=== PAUSE TestAccSSMAssociation_tags_null
=== RUN   TestAccSSMAssociation_tags_AddOnUpdate
=== PAUSE TestAccSSMAssociation_tags_AddOnUpdate
=== RUN   TestAccSSMAssociation_tags_EmptyTag_OnCreate
=== PAUSE TestAccSSMAssociation_tags_EmptyTag_OnCreate
=== RUN   TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccSSMAssociation_tags_DefaultTags_providerOnly
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_providerOnly
=== RUN   TestAccSSMAssociation_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_nonOverlapping
=== RUN   TestAccSSMAssociation_tags_DefaultTags_overlapping
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_overlapping
=== RUN   TestAccSSMAssociation_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccSSMAssociation_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccSSMAssociation_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccSSMAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccSSMAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccSSMAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccSSMAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccSSMAssociation_tags_ComputedTag_OnCreate
=== PAUSE TestAccSSMAssociation_tags_ComputedTag_OnCreate
=== RUN   TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccSSMAssociation_basic
=== PAUSE TestAccSSMAssociation_basic
=== RUN   TestAccSSMAssociation_disappears
=== PAUSE TestAccSSMAssociation_disappears
=== RUN   TestAccSSMAssociation_disappears_document
=== PAUSE TestAccSSMAssociation_disappears_document
=== RUN   TestAccSSMAssociation_applyOnlyAtCronInterval
=== PAUSE TestAccSSMAssociation_applyOnlyAtCronInterval
=== RUN   TestAccSSMAssociation_withTargets
=== PAUSE TestAccSSMAssociation_withTargets
=== RUN   TestAccSSMAssociation_withParameters
=== PAUSE TestAccSSMAssociation_withParameters
=== RUN   TestAccSSMAssociation_withAssociationName
=== PAUSE TestAccSSMAssociation_withAssociationName
=== RUN   TestAccSSMAssociation_withAssociationNameAndScheduleExpression
=== PAUSE TestAccSSMAssociation_withAssociationNameAndScheduleExpression
=== RUN   TestAccSSMAssociation_withDocumentVersion
=== PAUSE TestAccSSMAssociation_withDocumentVersion
=== RUN   TestAccSSMAssociation_withOutputLocation
=== PAUSE TestAccSSMAssociation_withOutputLocation
=== RUN   TestAccSSMAssociation_withOutputLocation_s3Region
=== PAUSE TestAccSSMAssociation_withOutputLocation_s3Region
=== RUN   TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout
=== PAUSE TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout
=== RUN   TestAccSSMAssociation_withAutomationTargetParamName
=== PAUSE TestAccSSMAssociation_withAutomationTargetParamName
=== RUN   TestAccSSMAssociation_withScheduleExpression
=== PAUSE TestAccSSMAssociation_withScheduleExpression
=== RUN   TestAccSSMAssociation_withComplianceSeverity
=== PAUSE TestAccSSMAssociation_withComplianceSeverity
=== RUN   TestAccSSMAssociation_rateControl
=== PAUSE TestAccSSMAssociation_rateControl
=== RUN   TestAccSSMAssociation_syncCompliance
=== PAUSE TestAccSSMAssociation_syncCompliance
=== CONT  TestAccSSMAssociation_tags
=== CONT  TestAccSSMAssociation_basic
=== CONT  TestAccSSMAssociation_withOutputLocation
--- PASS: TestAccSSMAssociation_withOutputLocation (37.31s)
=== CONT  TestAccSSMAssociation_withParameters
--- PASS: TestAccSSMAssociation_tags (46.12s)
=== CONT  TestAccSSMAssociation_withDocumentVersion
--- PASS: TestAccSSMAssociation_withDocumentVersion (12.16s)
=== CONT  TestAccSSMAssociation_withAssociationNameAndScheduleExpression
--- PASS: TestAccSSMAssociation_withParameters (21.07s)
=== CONT  TestAccSSMAssociation_withAssociationName
--- PASS: TestAccSSMAssociation_withAssociationName (19.97s)
=== CONT  TestAccSSMAssociation_applyOnlyAtCronInterval
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (22.24s)
=== CONT  TestAccSSMAssociation_withTargets
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (20.14s)
=== CONT  TestAccSSMAssociation_withScheduleExpression
--- PASS: TestAccSSMAssociation_withTargets (27.51s)
=== CONT  TestAccSSMAssociation_syncCompliance
--- PASS: TestAccSSMAssociation_withScheduleExpression (20.05s)
=== CONT  TestAccSSMAssociation_rateControl
--- PASS: TestAccSSMAssociation_syncCompliance (15.72s)
=== CONT  TestAccSSMAssociation_withComplianceSeverity
--- PASS: TestAccSSMAssociation_basic (126.95s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccSSMAssociation_rateControl (20.10s)
=== CONT  TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccSSMAssociation_withComplianceSeverity (19.93s)
=== CONT  TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccSSMAssociation_tags_DefaultTags_updateToProviderOnly (22.35s)
=== CONT  TestAccSSMAssociation_tags_ComputedTag_OnCreate
--- PASS: TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Replace (25.56s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccSSMAssociation_tags_ComputedTag_OnCreate (16.59s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccSSMAssociation_tags_ComputedTag_OnUpdate_Add (25.33s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccSSMAssociation_tags_DefaultTags_nullNonOverlappingResourceTag (13.49s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccSSMAssociation_tags_DefaultTags_nullOverlappingResourceTag (13.59s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccSSMAssociation_tags_DefaultTags_emptyProviderOnlyTag (13.89s)
=== CONT  TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccSSMAssociation_tags_DefaultTags_emptyResourceTag (13.78s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_overlapping
--- PASS: TestAccSSMAssociation_tags_DefaultTags_updateToResourceOnly (21.80s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_nonOverlapping
--- PASS: TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Replace (21.79s)
=== CONT  TestAccSSMAssociation_tags_DefaultTags_providerOnly
--- PASS: TestAccSSMAssociation_tags_DefaultTags_overlapping (36.99s)
=== CONT  TestAccSSMAssociation_tags_EmptyTag_OnCreate
--- PASS: TestAccSSMAssociation_tags_DefaultTags_nonOverlapping (36.79s)
=== CONT  TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccSSMAssociation_tags_EmptyTag_OnCreate (24.63s)
=== CONT  TestAccSSMAssociation_tags_AddOnUpdate
--- PASS: TestAccSSMAssociation_tags_DefaultTags_providerOnly (49.15s)
=== CONT  TestAccSSMAssociation_disappears_document
--- PASS: TestAccSSMAssociation_tags_EmptyTag_OnUpdate_Add (32.54s)
=== CONT  TestAccSSMAssociation_tags_null
--- PASS: TestAccSSMAssociation_tags_AddOnUpdate (21.73s)
=== CONT  TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout
--- PASS: TestAccSSMAssociation_tags_null (16.76s)
=== CONT  TestAccSSMAssociation_withAutomationTargetParamName
--- PASS: TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout (15.79s)
=== CONT  TestAccSSMAssociation_disappears
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (49.29s)
=== CONT  TestAccSSMAssociation_withOutputLocation_s3Region
--- PASS: TestAccSSMAssociation_disappears_document (117.71s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (42.07s)
--- PASS: TestAccSSMAssociation_disappears (119.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	414.557s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ce6bff1 into hashicorp:main Jul 8, 2024
83 checks passed
@github-actions github-actions bot added this to the v5.58.0 milestone Jul 8, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 12, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the f-aws_ssm_assoication-add_tags_support branch July 19, 2024 02:49
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/ssm Issues and PRs that pertain to the ssm service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.58.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: SSM Association Resource Tagging
3 participants
@acwwat @ewbankkit @justinretzolk