fix: Remove extra closing bracket in Tags annotation for aws_ecr_repository data source

[acwwat]

Description

This PR is to fix the issue where tags are not set/loaded by the aws_ecr_repository data source because of an extra ) in the @Tags annotation comment that caused bad code generation.

The original test case is also not catching the issue since it's comparing the tags map attribute between the resource and data source directly. It seems to be related to how the TestCheckResourceAttrPair() function works, so instead I've changed it to compare the map lengths instead for more proper validation (short of comparing the two tags direcrtly).

Relations

Closes #38155

References

n/a

Output from Acceptance Testing

$ make testacc TESTS=TestAccECRRepositoryDataSource_ PKG=ecr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRRepositoryDataSource_'  -timeout 360m
=== RUN   TestAccECRRepositoryDataSource_basic
=== PAUSE TestAccECRRepositoryDataSource_basic
=== RUN   TestAccECRRepositoryDataSource_encryption
=== PAUSE TestAccECRRepositoryDataSource_encryption
=== RUN   TestAccECRRepositoryDataSource_nonExistent
=== PAUSE TestAccECRRepositoryDataSource_nonExistent
=== CONT  TestAccECRRepositoryDataSource_basic
=== CONT  TestAccECRRepositoryDataSource_nonExistent
=== CONT  TestAccECRRepositoryDataSource_encryption
--- PASS: TestAccECRRepositoryDataSource_nonExistent (3.97s)
--- PASS: TestAccECRRepositoryDataSource_basic (18.75s)
--- PASS: TestAccECRRepositoryDataSource_encryption (21.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        22.071s

$

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECRRepositoryDataSource_' PKG=ecr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/ecr/... -v -count 1 -parallel 20  -run=TestAccECRRepositoryDataSource_ -timeout 360m
=== RUN   TestAccECRRepositoryDataSource_basic
=== PAUSE TestAccECRRepositoryDataSource_basic
=== RUN   TestAccECRRepositoryDataSource_encryption
=== PAUSE TestAccECRRepositoryDataSource_encryption
=== RUN   TestAccECRRepositoryDataSource_nonExistent
=== PAUSE TestAccECRRepositoryDataSource_nonExistent
=== CONT  TestAccECRRepositoryDataSource_basic
=== CONT  TestAccECRRepositoryDataSource_nonExistent
=== CONT  TestAccECRRepositoryDataSource_encryption
--- PASS: TestAccECRRepositoryDataSource_nonExistent (2.88s)
--- PASS: TestAccECRRepositoryDataSource_basic (11.90s)
--- PASS: TestAccECRRepositoryDataSource_encryption (13.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	18.609s

[ewbankkit]

@acwwat Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.