feat: Add resource filtering support to aws_oam_link #38277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XL
terraform-aws-provider
bot
added
needs-triage
acwwat
force-pushed
the
f-aws_oam_link-add-filtering-support
branch
from
cd87309
to
58ce1f2
Compare
acwwat
changed the title
acwwat
force-pushed
the
f-aws_oam_link-add-filtering-support
branch
3 times, most recently
from
b0208a0
to
639e2a8
Compare
acwwat
changed the title
acwwat
force-pushed
the
f-aws_oam_link-add-filtering-support
branch
from
639e2a8
to
3ece6c5
Compare
acwwat
force-pushed
the
f-aws_oam_link-add-filtering-support
branch
from
3ece6c5
to
542711d
Compare
ewbankkit
removed
the
needs-triage
ewbankkit
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccObservabilityAccessManager_serial/Link' PKG=oam
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/oam/... -v -count 1 -parallel 20 -run=TestAccObservabilityAccessManager_serial/Link -timeout 360m
=== RUN TestAccObservabilityAccessManager_serial
=== PAUSE TestAccObservabilityAccessManager_serial
=== CONT TestAccObservabilityAccessManager_serial
=== RUN TestAccObservabilityAccessManager_serial/Link
=== RUN TestAccObservabilityAccessManager_serial/Link/basic
=== RUN TestAccObservabilityAccessManager_serial/Link/disappears
=== RUN TestAccObservabilityAccessManager_serial/Link/update
=== RUN TestAccObservabilityAccessManager_serial/Link/tags
=== RUN TestAccObservabilityAccessManager_serial/Link/logGroupConfiguration
=== RUN TestAccObservabilityAccessManager_serial/Link/metricConfiguration
=== RUN TestAccObservabilityAccessManager_serial/LinkDataSource
=== RUN TestAccObservabilityAccessManager_serial/LinkDataSource/basic
=== RUN TestAccObservabilityAccessManager_serial/LinkDataSource/logGroupConfiguration
=== RUN TestAccObservabilityAccessManager_serial/LinkDataSource/metricConfiguration
=== RUN TestAccObservabilityAccessManager_serial/LinksDataSource
=== RUN TestAccObservabilityAccessManager_serial/LinksDataSource/basic
--- PASS: TestAccObservabilityAccessManager_serial (229.87s)
--- PASS: TestAccObservabilityAccessManager_serial/Link (166.12s)
--- PASS: TestAccObservabilityAccessManager_serial/Link/basic (20.96s)
--- PASS: TestAccObservabilityAccessManager_serial/Link/disappears (15.79s)
--- PASS: TestAccObservabilityAccessManager_serial/Link/update (29.02s)
--- PASS: TestAccObservabilityAccessManager_serial/Link/tags (40.28s)
--- PASS: TestAccObservabilityAccessManager_serial/Link/logGroupConfiguration (29.66s)
--- PASS: TestAccObservabilityAccessManager_serial/Link/metricConfiguration (30.42s)
--- PASS: TestAccObservabilityAccessManager_serial/LinkDataSource (47.55s)
--- PASS: TestAccObservabilityAccessManager_serial/LinkDataSource/basic (15.69s)
--- PASS: TestAccObservabilityAccessManager_serial/LinkDataSource/logGroupConfiguration (15.90s)
--- PASS: TestAccObservabilityAccessManager_serial/LinkDataSource/metricConfiguration (15.96s)
--- PASS: TestAccObservabilityAccessManager_serial/LinksDataSource (16.19s)
--- PASS: TestAccObservabilityAccessManager_serial/LinksDataSource/basic (16.19s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/oam 234.396s
|
@acwwat Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add resource filtering support to the
aws_oam_linkresource and data source.During testing, it is observed that an OAM sink is a global object and thus can only be created once, so parallel tests would break. I've made the change to run all OAM acceptance tests in serial instead.
There also seems to be an AWS API issue where
link_configurationcannot be unset via an update. I've tried to work around the issue with different permutations of settinglink_configuration,log_group_configurationandmetric_configuration, none of which worked. For now, I have to treat this as an upstream problem that should be resolved in the future, so that it doesn't block this feature from being merged.Relations
Closes #37515
References
Referred to the API reference for specs.
Output from Acceptance Testing