New resource: aws_servicecatalogappregistry_attribute_group_association
#38290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XL
terraform-aws-provider
bot
added
needs-triage
drewtul
changed the title
aws_application_attribute_group_associationaws_servicecatalogappregistry_application_attribute_group_association
justinretzolk
added
new-resource
drewtul
force-pushed
the
f-sc-appregistry-app-ag-association
branch
from
e685e66 to
30c605b
Compare
drewtul
force-pushed
the
f-sc-appregistry-app-ag-association
branch
from
8220636 to
7e1d630
Compare
…on(doc): fix import section
…esource name Updates the resource name to `aws_servicecatalogappregistry_attribute_group_association` to correspond with the name of the AWS API, `AssociateAttributeGroup`.
…ttribute Removes the `id` attribute in favor of splitting the provided identifier on import into the requisite parts. Also refactors the attribute group association finder function and re-uses it across acceptance test helper functions. ```console % make testacc PKG=servicecatalogappregistry TESTS=TestAccServiceCatalogAppRegistryAttributeGroupAssociation_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.3 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryAttributeGroupAssociation_' -timeout 360m 2024/12/09 14:07:58 Initializing Terraform AWS Provider... --- PASS: TestAccServiceCatalogAppRegistryAttributeGroupAssociation_disappears (14.56s) --- PASS: TestAccServiceCatalogAppRegistryAttributeGroupAssociation_basic (15.44s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry 20.539s ```
…lf-contained test config
…mplify test config
jar-b
previously approved these changes
Dec 9, 2024
There was a problem hiding this comment.
LGTM 🎉
% make testacc PKG=servicecatalogappregistry TESTS=TestAccServiceCatalogAppRegistryAttributeGroupAssociation_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryAttributeGroupAssociation_' -timeout 360m
2024/12/09 14:37:32 Initializing Terraform AWS Provider...
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupAssociation_disappears (13.50s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupAssociation_basic (15.11s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry 20.294s
|
Thanks for your contribution, @drewtul! 👍 I changed the resource name to |
YakDriver
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
% make testacc PKG=servicecatalogappregistry TESTS=TestAccServiceCatalogAppRegistryAttributeGroupAssociation_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryAttributeGroupAssociation_' -timeout 360m
2024/12/09 15:45:42 Initializing Terraform AWS Provider...
=== RUN TestAccServiceCatalogAppRegistryAttributeGroupAssociation_basic
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupAssociation_basic
=== RUN TestAccServiceCatalogAppRegistryAttributeGroupAssociation_disappears
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupAssociation_disappears
=== CONT TestAccServiceCatalogAppRegistryAttributeGroupAssociation_basic
=== CONT TestAccServiceCatalogAppRegistryAttributeGroupAssociation_disappears
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupAssociation_disappears (13.24s)
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupAssociation_basic (14.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry 18.947s
jar-b
changed the title
aws_servicecatalogappregistry_application_attribute_group_associationaws_servicecatalogappregistry_attribute_group_association
|
This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New resource to associate applications with attribute groups.
Relations
Depends on #38243
References
Output from Acceptance Testing