Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all errors are checked during read, not just tfresource.NotFound #38292

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Ensure that all errors are checked during read, not just tfresource.NotFound #38292

merged 5 commits into from
Jul 9, 2024

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jul 8, 2024

Description

In a number of cases, only tfresource.NotFound is checked, but other errors are not checked.

Relations

Closes #38138

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. service/rds Issues and PRs that pertain to the rds service. service/directconnect Issues and PRs that pertain to the directconnect service. service/opsworks Issues and PRs that pertain to the opsworks service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ram Issues and PRs that pertain to the ram service. linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code service/ssmincidents Issues and PRs that pertain to the ssmincidents service. service/vpc Issues and PRs that pertain to the vpc service. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

ewbankkit
ewbankkit approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

justinretzolk
justinretzolk approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/semgrep-ci.yml
@@ -24,15 +24,42 @@ env:
SEMGREP_ARGS: --error --quiet

jobs:
semgrep-validate:
Copy link
Member

@justinretzolk justinretzolk Jul 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we could combine these into steps of a single job, rather than distinct ones, but it's not something I'd hold off on merging for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered validating all of the Semgrep files in this job, and then making all the jobs depend on it, but figured this was fewer changes

@gdavison gdavison merged commit c63ae32 into main Jul 9, 2024
42 checks passed
@gdavison gdavison deleted the b-err-only-notfound branch July 9, 2024 19:04
@github-actions github-actions bot added this to the v5.58.0 milestone Jul 9, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jul 9, 2024
Update CHANGELOG.md for #38292
7169a3f
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 12, 2024
@ewbankkit ewbankkit mentioned this pull request Jul 24, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinretzolk justinretzolk justinretzolk approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

@breathingdust breathingdust Awaiting requested review from breathingdust breathingdust is a code owner

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/directconnect Issues and PRs that pertain to the directconnect service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. service/opsworks Issues and PRs that pertain to the opsworks service. service/ram Issues and PRs that pertain to the ram service. service/rds Issues and PRs that pertain to the rds service. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.58.0
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_opensearchserverless_collection got AutoFlEx error
3 participants
@gdavison @ewbankkit @justinretzolk