-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aws_cloudwatch_log_account_policy resource #38328
add aws_cloudwatch_log_account_policy resource #38328
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @chrisbrowning 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
… Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below]' and 'MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLogsAccountPolicy_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/logs/... -v -count 1 -parallel 3 -run=TestAccLogsAccountPolicy_ -timeout 360m
=== RUN TestAccLogsAccountPolicy_basicSubscriptionFilter
=== PAUSE TestAccLogsAccountPolicy_basicSubscriptionFilter
=== RUN TestAccLogsAccountPolicy_basicDataProtection
=== PAUSE TestAccLogsAccountPolicy_basicDataProtection
=== RUN TestAccLogsAccountPolicy_disappears
=== PAUSE TestAccLogsAccountPolicy_disappears
=== RUN TestAccLogsAccountPolicy_selectionCriteria
=== PAUSE TestAccLogsAccountPolicy_selectionCriteria
=== CONT TestAccLogsAccountPolicy_basicSubscriptionFilter
=== CONT TestAccLogsAccountPolicy_disappears
=== CONT TestAccLogsAccountPolicy_selectionCriteria
--- PASS: TestAccLogsAccountPolicy_disappears (11.99s)
=== CONT TestAccLogsAccountPolicy_basicDataProtection
--- PASS: TestAccLogsAccountPolicy_basicDataProtection (10.97s)
--- PASS: TestAccLogsAccountPolicy_basicSubscriptionFilter (27.06s)
--- PASS: TestAccLogsAccountPolicy_selectionCriteria (38.83s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/logs 43.828s
@chrisbrowning Thanks for the contribution 🎉 👏. |
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the
aws_cloudwatch_log_account_policy
resource, which can create account-level subscription filters and/or data protection policies.Relations
Closes #35278
References
Output from Acceptance Testing