Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add event_bridge_destination block for aws_sesv2_configuration_set_event_destination #38458

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jul 21, 2024

Description

This PR is to add the event_destination.event_bridge_destination block to the aws_sesv2_configuration_set_event_destination resource to support tracking email sending activity by delivering sending events to EventBridge.

I opted to use event_bridge_destination instead of eventbridge_destination since the AWSCC provider also uses event_bridge_destination as the arg/block name.

Relations

Closes #38021

References

Referred to EventDestinationDefinition for specs.

Output from Acceptance Testing

$ make testacc TESTS=TestAccSESV2ConfigurationSetEventDestination_ PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2ConfigurationSetEventDestination_'  -timeout 360m
=== RUN   TestAccSESV2ConfigurationSetEventDestination_basic
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_basic
=== RUN   TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_disappears
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_disappears
=== CONT  TestAccSESV2ConfigurationSetEventDestination_basic
=== CONT  TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== CONT  TestAccSESV2ConfigurationSetEventDestination_disappears
=== CONT  TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination
=== CONT  TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== CONT  TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== CONT  TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_disappears (21.88s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination (25.82s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination (36.38s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_basic (36.57s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_snsDestination (38.07s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_pinpointDestination (38.69s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination (114.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      115.230s

$

@acwwat acwwat requested a review from a team as a code owner July 21, 2024 20:16
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/L Managed by automation to categorize the size of a PR. labels Jul 21, 2024
@acwwat acwwat force-pushed the f-aws_sesv2_configuration_set_event_destination-add_event_bridge_destination_block branch from ea460c9 to dceb362 Compare July 21, 2024 20:18
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=sesv2 TESTS=TestAccSESV2ConfigurationSetEventDestination_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2ConfigurationSetEventDestination_'  -timeout 360m

--- PASS: TestAccSESV2ConfigurationSetEventDestination_disappears (13.36s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination (15.78s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination (22.22s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_basic (22.68s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_pinpointDestination (23.49s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_snsDestination (24.29s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination (106.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      112.300s

@jar-b
Copy link
Member

jar-b commented Jul 22, 2024

Thanks for your contribution, @acwwat! 🚀

@jar-b jar-b merged commit ea123a0 into hashicorp:main Jul 22, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.60.0 milestone Jul 22, 2024
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the f-aws_sesv2_configuration_set_event_destination-add_event_bridge_destination_block branch July 27, 2024 02:09
@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: SES - Add eventbridge as event destination
3 participants