Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: enable restore to point in time on aws_rds_cluster based on cluster_resource_id #38549

Closed
aristosvo opened this issue Jul 26, 2024 · 4 comments · Fixed by #38540
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@aristosvo
Copy link
Contributor

aristosvo commented Jul 26, 2024

Description

The resource aws_rds_cluster has multiple backup restore possibilities, restore from snaphot and restore from an existing cluster. The lacking feature is the restore from an automated backup which is retained after cluster deletion.

On a resource level, aws_rds_cluster.restore_to_point_in_time has already a source_cluster_identifier parameter. This parameter has one major drawback, as specified in the AWS SDK:

Must match the identifier of an existing DBCluster.

This is not the case for the source_cluster_resource_id (example value: cluster-FT2Y56NA7X7JDBKX7GNV5WX3FX), which is unique (you can create, delete and recreate a cluster with the same ARN, which will have different resource IDs). Restores based on a retained automated backup of a deleted database cluster is only possible with source_cluster_resource_id.

Affected Resource(s) and/or Data Source(s)

  • aws_rds_cluster

Potential Terraform Configuration

resource "aws_rds_cluster" "restore" {
...
  restore_to_point_in_time {
    source_cluster_resource_id = aws_rds_cluster.test.cluster_resource_id
    restore_type               = "full-copy"
    use_latest_restorable_time = true
  }
...
}

References

Would you like to implement a fix?

Yes

@aristosvo aristosvo added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 26, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label Jul 26, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 26, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 26, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.61.0 milestone Jul 29, 2024
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
2 participants