Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log_configuration.include_execution_data arg for aws_pipes_pipe #38569

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jul 27, 2024

Description

This PR is to add the include_execution_data argument to the log_configuration block for the aws_pipes_pipe resource.

While running the acceptance tests, I found that the TestAccPipesPipe_rabbitMQSourceEventBusTarget failed due a deprecated version of RabbitMQ version. I've updated the version to 3.12.13 to fix the test case as part of this PR.

Relations

Closes #38565

References

Referred to PipeLogConfiguration for specs.

Output from Acceptance Testing

$ make testacc TESTS=TestAccPipesPipe_ PKG=pipes
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/pipes/... -v -count 1 -parallel 20 -run='TestAccPipesPipe_'  -timeout 360m
=== RUN   TestAccPipesPipe_basicSQS
=== PAUSE TestAccPipesPipe_basicSQS
=== RUN   TestAccPipesPipe_disappears
=== PAUSE TestAccPipesPipe_disappears
=== RUN   TestAccPipesPipe_description
=== PAUSE TestAccPipesPipe_description
=== RUN   TestAccPipesPipe_desiredState
=== PAUSE TestAccPipesPipe_desiredState
=== RUN   TestAccPipesPipe_enrichment
=== PAUSE TestAccPipesPipe_enrichment
=== RUN   TestAccPipesPipe_enrichmentParameters
=== PAUSE TestAccPipesPipe_enrichmentParameters
=== RUN   TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
=== PAUSE TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
=== RUN   TestAccPipesPipe_update_logConfiguration_cloudwatchLogsLogDestination
=== PAUSE TestAccPipesPipe_update_logConfiguration_cloudwatchLogsLogDestination
=== RUN   TestAccPipesPipe_logConfiguration_includeExecutionData
=== PAUSE TestAccPipesPipe_logConfiguration_includeExecutionData
=== RUN   TestAccPipesPipe_sourceParameters_filterCriteria
=== PAUSE TestAccPipesPipe_sourceParameters_filterCriteria
=== RUN   TestAccPipesPipe_nameGenerated
=== PAUSE TestAccPipesPipe_nameGenerated
=== RUN   TestAccPipesPipe_namePrefix
=== PAUSE TestAccPipesPipe_namePrefix
=== RUN   TestAccPipesPipe_roleARN
=== PAUSE TestAccPipesPipe_roleARN
=== RUN   TestAccPipesPipe_tags
=== PAUSE TestAccPipesPipe_tags
=== RUN   TestAccPipesPipe_targetUpdate
=== PAUSE TestAccPipesPipe_targetUpdate
=== RUN   TestAccPipesPipe_targetParameters_inputTemplate
=== PAUSE TestAccPipesPipe_targetParameters_inputTemplate
=== RUN   TestAccPipesPipe_kinesisSourceAndTarget
=== PAUSE TestAccPipesPipe_kinesisSourceAndTarget
=== RUN   TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== PAUSE TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== RUN   TestAccPipesPipe_activeMQSourceStepFunctionTarget
=== PAUSE TestAccPipesPipe_activeMQSourceStepFunctionTarget
=== RUN   TestAccPipesPipe_rabbitMQSourceEventBusTarget
=== PAUSE TestAccPipesPipe_rabbitMQSourceEventBusTarget
=== RUN   TestAccPipesPipe_mskSourceHTTPTarget
    pipe_test.go:1106: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_mskSourceHTTPTarget (0.00s)
=== RUN   TestAccPipesPipe_selfManagedKafkaSourceLambdaFunctionTarget
    pipe_test.go:1182: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_selfManagedKafkaSourceLambdaFunctionTarget (0.00s)
=== RUN   TestAccPipesPipe_sqsSourceRedshiftTarget
=== PAUSE TestAccPipesPipe_sqsSourceRedshiftTarget
=== RUN   TestAccPipesPipe_SourceSageMakerTarget
    pipe_test.go:1329: aws_sagemaker_pipeline resource not yet implemented
--- SKIP: TestAccPipesPipe_SourceSageMakerTarget (0.00s)
=== RUN   TestAccPipesPipe_sqsSourceBatchJobTarget
=== PAUSE TestAccPipesPipe_sqsSourceBatchJobTarget
=== RUN   TestAccPipesPipe_sqsSourceECSTaskTarget
    pipe_test.go:1480: ValidationException: [numeric instance is lower than the required minimum (minimum: 1, found: 0)]
--- SKIP: TestAccPipesPipe_sqsSourceECSTaskTarget (0.00s)
=== CONT  TestAccPipesPipe_basicSQS
=== CONT  TestAccPipesPipe_namePrefix
=== CONT  TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== CONT  TestAccPipesPipe_targetUpdate
=== CONT  TestAccPipesPipe_tags
=== CONT  TestAccPipesPipe_logConfiguration_includeExecutionData
=== CONT  TestAccPipesPipe_update_logConfiguration_cloudwatchLogsLogDestination
=== CONT  TestAccPipesPipe_desiredState
=== CONT  TestAccPipesPipe_kinesisSourceAndTarget
=== CONT  TestAccPipesPipe_enrichmentParameters
=== CONT  TestAccPipesPipe_sqsSourceRedshiftTarget
=== CONT  TestAccPipesPipe_roleARN
=== CONT  TestAccPipesPipe_rabbitMQSourceEventBusTarget
=== CONT  TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
=== CONT  TestAccPipesPipe_enrichment
=== CONT  TestAccPipesPipe_nameGenerated
=== CONT  TestAccPipesPipe_description
=== CONT  TestAccPipesPipe_targetParameters_inputTemplate
=== CONT  TestAccPipesPipe_disappears
=== CONT  TestAccPipesPipe_sourceParameters_filterCriteria
=== CONT  TestAccPipesPipe_sqsSourceBatchJobTarget
--- PASS: TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget (60.48s)
=== CONT  TestAccPipesPipe_activeMQSourceStepFunctionTarget
--- PASS: TestAccPipesPipe_kinesisSourceAndTarget (97.03s)
--- PASS: TestAccPipesPipe_disappears (99.43s)
--- PASS: TestAccPipesPipe_nameGenerated (99.76s)
--- PASS: TestAccPipesPipe_basicSQS (100.45s)
--- PASS: TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination (104.93s)
--- PASS: TestAccPipesPipe_namePrefix (106.40s)
--- PASS: TestAccPipesPipe_tags (135.28s)
--- PASS: TestAccPipesPipe_enrichmentParameters (137.39s)
--- PASS: TestAccPipesPipe_update_logConfiguration_cloudwatchLogsLogDestination (139.14s)
--- PASS: TestAccPipesPipe_roleARN (150.15s)
--- PASS: TestAccPipesPipe_enrichment (158.55s)
--- PASS: TestAccPipesPipe_targetUpdate (159.35s)
--- PASS: TestAccPipesPipe_targetParameters_inputTemplate (165.20s)
--- PASS: TestAccPipesPipe_description (177.29s)
--- PASS: TestAccPipesPipe_desiredState (179.34s)
--- PASS: TestAccPipesPipe_sqsSourceBatchJobTarget (165.45s)
--- PASS: TestAccPipesPipe_logConfiguration_includeExecutionData (190.80s)
--- PASS: TestAccPipesPipe_sourceParameters_filterCriteria (219.84s)
--- PASS: TestAccPipesPipe_sqsSourceRedshiftTarget (239.11s)
--- PASS: TestAccPipesPipe_rabbitMQSourceEventBusTarget (722.28s)
--- PASS: TestAccPipesPipe_activeMQSourceStepFunctionTarget (1016.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pipes      1077.299s

$

@acwwat acwwat requested a review from a team as a code owner July 27, 2024 02:03
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/pipes Issues and PRs that pertain to the pipes service. size/L Managed by automation to categorize the size of a PR. labels Jul 27, 2024
@acwwat acwwat force-pushed the f-aws_pipes_pipe-add_include_execution_data_arg branch from 0845949 to c0eee72 Compare July 27, 2024 02:05
@ewbankkit ewbankkit self-assigned this Jul 29, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccPipesPipe_logConfiguration\|TestAccPipesPipe_basic' PKG=pipes ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/pipes/... -v -count 1 -parallel 3  -run=TestAccPipesPipe_logConfiguration\|TestAccPipesPipe_basic -timeout 360m
=== RUN   TestAccPipesPipe_basicSQS
=== PAUSE TestAccPipesPipe_basicSQS
=== RUN   TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
=== PAUSE TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
=== RUN   TestAccPipesPipe_logConfiguration_includeExecutionData
=== PAUSE TestAccPipesPipe_logConfiguration_includeExecutionData
=== CONT  TestAccPipesPipe_basicSQS
=== CONT  TestAccPipesPipe_logConfiguration_includeExecutionData
=== CONT  TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
--- PASS: TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination (79.52s)
--- PASS: TestAccPipesPipe_basicSQS (89.72s)
--- PASS: TestAccPipesPipe_logConfiguration_includeExecutionData (136.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pipes	141.816s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0df57b7 into hashicorp:main Jul 29, 2024
47 checks passed
@github-actions github-actions bot added this to the v5.61.0 milestone Jul 29, 2024
@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
@acwwat acwwat deleted the f-aws_pipes_pipe-add_include_execution_data_arg branch July 30, 2024 05:04
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/pipes Issues and PRs that pertain to the pipes service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Allow including execution info for Eventbridge pipe log configuation
3 participants