-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add log_configuration.include_execution_data arg for aws_pipes_pipe #38569
feat: add log_configuration.include_execution_data arg for aws_pipes_pipe #38569
Conversation
Community NoteVoting for Prioritization
For Submitters
|
0845949
to
c0eee72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccPipesPipe_logConfiguration\|TestAccPipesPipe_basic' PKG=pipes ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/pipes/... -v -count 1 -parallel 3 -run=TestAccPipesPipe_logConfiguration\|TestAccPipesPipe_basic -timeout 360m
=== RUN TestAccPipesPipe_basicSQS
=== PAUSE TestAccPipesPipe_basicSQS
=== RUN TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
=== PAUSE TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
=== RUN TestAccPipesPipe_logConfiguration_includeExecutionData
=== PAUSE TestAccPipesPipe_logConfiguration_includeExecutionData
=== CONT TestAccPipesPipe_basicSQS
=== CONT TestAccPipesPipe_logConfiguration_includeExecutionData
=== CONT TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination
--- PASS: TestAccPipesPipe_logConfiguration_cloudwatchLogsLogDestination (79.52s)
--- PASS: TestAccPipesPipe_basicSQS (89.72s)
--- PASS: TestAccPipesPipe_logConfiguration_includeExecutionData (136.98s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/pipes 141.816s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the
include_execution_data
argument to thelog_configuration
block for theaws_pipes_pipe
resource.While running the acceptance tests, I found that the
TestAccPipesPipe_rabbitMQSourceEventBusTarget
failed due a deprecated version of RabbitMQ version. I've updated the version to 3.12.13 to fix the test case as part of this PR.Relations
Closes #38565
References
Referred to PipeLogConfiguration for specs.
Output from Acceptance Testing