Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add upgrade_policy config block for aws_eks_cluster #38573

Merged

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jul 28, 2024

Description

This PR is to add the upgrade_policy configuration block to the aws_eks_cluster resource and data source.

Relations

Closes #38510

References

Referred to UpgradePolicyRequest for specs.

Output from Acceptance Testing

Resource:

$ make testacc TESTS="TestAccEKSCluster_basic|TestAccEKSCluster_upgradePolicy" PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_basic|TestAccEKSCluster_upgradePolicy'  -timeout 360m
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_upgradePolicy
=== PAUSE TestAccEKSCluster_upgradePolicy
=== CONT  TestAccEKSCluster_basic
=== CONT  TestAccEKSCluster_upgradePolicy
--- PASS: TestAccEKSCluster_upgradePolicy (673.72s)
--- PASS: TestAccEKSCluster_basic (761.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        761.691s

$

Data source:

$ make testacc TESTS="TestAccEKSClusterDataSource" PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSClusterDataSource'  -timeout 360m
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== CONT  TestAccEKSClusterDataSource_basic
=== CONT  TestAccEKSClusterDataSource_outpost
    cluster_data_source_test.go:77: skipping since no Outposts found
--- SKIP: TestAccEKSClusterDataSource_outpost (1.20s)
--- PASS: TestAccEKSClusterDataSource_basic (711.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        711.458s

$

@acwwat acwwat requested a review from a team as a code owner July 28, 2024 05:39
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/eks Issues and PRs that pertain to the eks service. size/L Managed by automation to categorize the size of a PR. labels Jul 28, 2024
@acwwat acwwat force-pushed the f-aws_eks_cluster-add_upgrade_policy_arg branch from 6e15ce3 to 37a3f4a Compare July 28, 2024 05:41
@acwwat acwwat force-pushed the f-aws_eks_cluster-add_upgrade_policy_arg branch from 37a3f4a to ff50f7b Compare July 28, 2024 05:45
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 29, 2024
@ewbankkit ewbankkit self-assigned this Jul 29, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSCluster_basic\|TestAccEKSCluster_upgradePolicy\|TestAccEKSClusterDataSource_basic' PKG=eks 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSCluster_basic\|TestAccEKSCluster_upgradePolicy\|TestAccEKSClusterDataSource_basic -timeout 360m
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_upgradePolicy
=== PAUSE TestAccEKSCluster_upgradePolicy
=== CONT  TestAccEKSClusterDataSource_basic
=== CONT  TestAccEKSCluster_upgradePolicy
=== CONT  TestAccEKSCluster_basic
--- PASS: TestAccEKSClusterDataSource_basic (657.79s)
--- PASS: TestAccEKSCluster_basic (688.11s)
--- PASS: TestAccEKSCluster_upgradePolicy (753.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	757.725s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f824dab into hashicorp:main Jul 29, 2024
47 checks passed
@github-actions github-actions bot added this to the v5.61.0 milestone Jul 29, 2024
@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
@acwwat acwwat deleted the f-aws_eks_cluster-add_upgrade_policy_arg branch July 30, 2024 05:04
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/eks Issues and PRs that pertain to the eks service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support setting upgrade policy for EKS clusters
3 participants