Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/add slot type attribute #38698

Merged
merged 9 commits into from
Aug 8, 2024
Merged

f/add slot type attribute #38698

merged 9 commits into from
Aug 8, 2024

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Aug 6, 2024

Description

Add sub_slot_type to slot resource

Relations

Closes #35514

References

Output from Acceptance Testing

> make testacc TESTARGS='-run=TestAccLexV2ModelsSlot_' PKG=lexv2models
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/lexv2models/... -v -count 1 -parallel 20  -run=TestAccLexV2ModelsSlot_ -timeout 360m
=== RUN   TestAccLexV2ModelsSlot_basic
=== PAUSE TestAccLexV2ModelsSlot_basic
=== RUN   TestAccLexV2ModelsSlot_updateMultipleValuesSetting
=== PAUSE TestAccLexV2ModelsSlot_updateMultipleValuesSetting
=== RUN   TestAccLexV2ModelsSlot_obfuscationSetting
=== PAUSE TestAccLexV2ModelsSlot_obfuscationSetting
=== RUN   TestAccLexV2ModelsSlot_subSlotSetting
=== PAUSE TestAccLexV2ModelsSlot_subSlotSetting
=== RUN   TestAccLexV2ModelsSlot_disappears
=== PAUSE TestAccLexV2ModelsSlot_disappears
=== CONT  TestAccLexV2ModelsSlot_basic
=== CONT  TestAccLexV2ModelsSlot_obfuscationSetting
=== CONT  TestAccLexV2ModelsSlot_subSlotSetting
=== CONT  TestAccLexV2ModelsSlot_disappears
=== CONT  TestAccLexV2ModelsSlot_updateMultipleValuesSetting
--- PASS: TestAccLexV2ModelsSlot_obfuscationSetting (40.74s)
--- PASS: TestAccLexV2ModelsSlot_disappears (42.43s)
--- PASS: TestAccLexV2ModelsSlot_basic (44.72s)
--- PASS: TestAccLexV2ModelsSlot_subSlotSetting (47.11s)
--- PASS: TestAccLexV2ModelsSlot_updateMultipleValuesSetting (54.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        59.860s

...

Copy link

github-actions bot commented Aug 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lexv2models Issues and PRs that pertain to the lexv2models service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@nam054 nam054 marked this pull request as ready for review August 6, 2024 21:46
@nam054 nam054 requested a review from a team as a code owner August 6, 2024 21:46
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few nits.

internal/service/lexv2models/slot_test.go Outdated Show resolved Hide resolved
internal/service/lexv2models/slot.go Outdated Show resolved Hide resolved
internal/service/lexv2models/slot.go Outdated Show resolved Hide resolved
internal/service/lexv2models/slot.go Show resolved Hide resolved
internal/service/lexv2models/slot_test.go Outdated Show resolved Hide resolved
@YakDriver YakDriver self-assigned this Aug 7, 2024
@nam054 nam054 merged commit 4813387 into main Aug 8, 2024
35 checks passed
@nam054 nam054 deleted the f-slot_recursive_attr branch August 8, 2024 04:38
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 8, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Aug 8, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/lexv2models Issues and PRs that pertain to the lexv2models service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: lexv2models/slot Needs sub_slot_setting
2 participants