-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon Managed Grafana new licensing model #38743
Amazon Managed Grafana new licensing model #38743
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @carlosrodgut 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
be12fea
to
ef5793f
Compare
Hi team, That is my first PR on a Hashicorp repository. Is that still required? |
ef5793f
to
a3f9cf5
Compare
… with GrafanaToken (GrafanaLabs).
… generated on GrafanaLabs side.
a3f9cf5
to
17dcda3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGrafana_serial/LicenseAssociation' PKG=grafana
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/grafana/... -v -count 1 -parallel 20 -run=TestAccGrafana_serial/LicenseAssociation -timeout 360m
=== RUN TestAccGrafana_serial
=== PAUSE TestAccGrafana_serial
=== CONT TestAccGrafana_serial
=== RUN TestAccGrafana_serial/LicenseAssociation
=== RUN TestAccGrafana_serial/LicenseAssociation/enterpriseFreeTrial
license_association_test.go:26: ENTERPRISE_FREE_TRIAL has been deprecated and is no longer offered
=== RUN TestAccGrafana_serial/LicenseAssociation/enterpriseGrafanaToken
license_association_test.go:67: Grafana token is invalid
--- PASS: TestAccGrafana_serial (0.00s)
--- PASS: TestAccGrafana_serial/LicenseAssociation (0.00s)
--- SKIP: TestAccGrafana_serial/LicenseAssociation/enterpriseFreeTrial (0.00s)
--- SKIP: TestAccGrafana_serial/LicenseAssociation/enterpriseGrafanaToken (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/grafana 4.961s
@carlosrodgut Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Introduce the
Amazon Managed Grafana
new licensing model that requires aGrafanaToken
generated on GrafanaLabs side.The
GrafanaToken
grants access to a set of Grafana Enterprise Plugins.Relations
Closes #38535
References
Output from Acceptance Testing