-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_quicksight_account_subscription: fix panic reading nil account info #38752
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
…info Previously the read operation did not handle an `EmptyResultError` prior to attempting to reference fields from the output. The additional handling added in this change will prevent dereferencing of a nil output. ```console % make testacc PKG=quicksight TESTS="TestAccQuickSight_serial/AccountSubscription" make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSight_serial/AccountSubscription' -timeout 360m ? github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema [no test files] --- PASS: TestAccQuickSight_serial (329.40s) --- PASS: TestAccQuickSight_serial/AccountSubscription (329.40s) --- PASS: TestAccQuickSight_serial/AccountSubscription/disappears (163.87s) --- PASS: TestAccQuickSight_serial/AccountSubscription/basic (165.53s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 335.228s ```
54e6995
to
922695a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Previously the read operation did not handle an
EmptyResultError
prior to attempting to reference fields from the output. The additional handling added in this change will prevent dereferencing of a nil output.Relations
Closes #38637
Closes #33133
References
Output from Acceptance Testing