Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new resource aws_bedrock_guardrail #38757

Merged
merged 25 commits into from
Aug 12, 2024

Conversation

sasidhar-aws
Copy link
Contributor

@sasidhar-aws sasidhar-aws commented Aug 7, 2024

Description

Add a new resource allowing to create bedrock guardrails

Relations

Closes #37086

References

Guardrails for Amazon Bedrock is generally available with new safety & privacy controls
Announcement
Blog post

Output from Acceptance Testing

make testacc TESTS=TestAccBedrockGuardrail PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockGuardrail' -timeout 360m
=== RUN  TestAccBedrockGuardrail_basic
=== PAUSE TestAccBedrockGuardrail_basic
=== RUN  TestAccBedrockGuardrail_disappears
=== PAUSE TestAccBedrockGuardrail_disappears
=== RUN  TestAccBedrockGuardrail_kmsKey
--- PASS: TestAccBedrockGuardrail_kmsKey (296.55s)
=== RUN  TestAccBedrockGuardrail_tags
--- PASS: TestAccBedrockGuardrail_tags (444.27s)
=== RUN  TestAccBedrockGuardrail_update
--- PASS: TestAccBedrockGuardrail_update (310.86s)
=== CONT TestAccBedrockGuardrail_basic
=== CONT TestAccBedrockGuardrail_disappears
--- PASS: TestAccBedrockGuardrail_disappears (70.95s)
--- PASS: TestAccBedrockGuardrail_basic (85.99s)
PASS
ok 	[github.com/hashicorp/terraform-provider-aws/internal/service/bedrock](http://github.com/hashicorp/terraform-provider-aws/internal/service/bedrock)	1151.621s

...

@sasidhar-aws sasidhar-aws requested a review from a team as a code owner August 7, 2024 23:08
Copy link

github-actions bot commented Aug 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/bedrock Issues and PRs that pertain to the bedrock service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Aug 7, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Aug 9, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=bedrock TESTS=TestAccBedrockGuardrail_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockGuardrail_'  -timeout 360m

--- PASS: TestAccBedrockGuardrail_disappears (14.35s)
--- PASS: TestAccBedrockGuardrail_basic (16.84s)
--- PASS: TestAccBedrockGuardrail_kmsKey (21.86s)
--- PASS: TestAccBedrockGuardrail_tags (31.87s)
--- PASS: TestAccBedrockGuardrail_update (38.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    44.090s

@jar-b
Copy link
Member

jar-b commented Aug 12, 2024

Thanks for your contribution, @sasidhar-aws! 👍

@jar-b jar-b merged commit bfd41e2 into hashicorp:main Aug 12, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 12, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. service/bedrock Issues and PRs that pertain to the bedrock service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guardrails for Amazon Bedrock
2 participants