-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_grafana_workspace: fix expander panics #38775
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
The expanders for the `network_access_control` and `vpc_configuration` arguments did not check for a list of one nil item, resulting in a failed type assertion and panic when a single, empty configuration is provided. ```console % make testacc PKG=grafana TESTS=TestAccGrafana_serial/Workspace make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/grafana/... -v -count 1 -parallel 20 -run='TestAccGrafana_serial/Workspace' -timeout 360m --- PASS: TestAccGrafana_serial (6114.72s) --- PASS: TestAccGrafana_serial/Workspace (6114.72s) --- PASS: TestAccGrafana_serial/Workspace/saml (350.87s) --- PASS: TestAccGrafana_serial/Workspace/permissionType (402.51s) --- PASS: TestAccGrafana_serial/Workspace/tags (371.33s) --- PASS: TestAccGrafana_serial/Workspace/configuration (675.03s) --- PASS: TestAccGrafana_serial/Workspace/networkAccess (709.10s) --- SKIP: TestAccGrafana_serial/Workspace/sso (0.57s) --- PASS: TestAccGrafana_serial/Workspace/disappears (416.76s) --- SKIP: TestAccGrafana_serial/Workspace/organization (0.89s) --- PASS: TestAccGrafana_serial/Workspace/dataSources (347.22s) --- PASS: TestAccGrafana_serial/Workspace/notificationDestinations (397.44s) --- PASS: TestAccGrafana_serial/Workspace/vpc (1222.79s) --- PASS: TestAccGrafana_serial/Workspace/version (1220.20s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/grafana 6120.565s ```
36caf5a
to
e279605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The expanders for the
network_access_control
andvpc_configuration
arguments did not check for a list of one nil item, resulting in a failed type assertion and panic when a single, empty configuration is provided.Relations
Closes #38264
Output from Acceptance Testing