Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: r/aws_glue_job: Add support for job run queuing #38991

Closed
jar-b opened this issue Aug 22, 2024 · 6 comments · Fixed by #39027
Closed

[Enhancement]: r/aws_glue_job: Add support for job run queuing #38991

jar-b opened this issue Aug 22, 2024 · 6 comments · Fixed by #39027
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/glue Issues and PRs that pertain to the glue service.
Milestone

Comments

@jar-b
Copy link
Member

jar-b commented Aug 22, 2024

Description

To support job run queuing, add an optional job_run_queuing_enabled argument to the Glue job resource.

https://github.com/aws/aws-sdk-go-v2/blob/38fe812f7abf976b6b1a5122c0c3bf303502cfc5/service/glue/api_op_CreateJob.go#L136-L143

Affected Resource(s) and/or Data Source(s)

  • aws_glue_job

Potential Terraform Configuration

resource "aws_glue_job" "example" {
  ### additional configuration ###

  job_run_queuing_enabled = true
}

References

Would you like to implement a fix?

None

@jar-b jar-b added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 22, 2024
@github-actions github-actions bot added the service/glue Issues and PRs that pertain to the glue service. label Aug 22, 2024
@jar-b jar-b added the good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. label Aug 22, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@mahadzaryab1
Copy link
Contributor

mahadzaryab1 commented Aug 25, 2024

@jar-b I've got a PR open at #39027. Do you know how I can test my changes (I'm new to this project).

@jar-b
Copy link
Member Author

jar-b commented Aug 26, 2024

Hey @mahadzaryab1 , thanks for picking this up! The contributor guide has information on acceptance testing here:
https://hashicorp.github.io/terraform-provider-aws/running-and-writing-acceptance-tests/

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.65.0 milestone Aug 29, 2024
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants