Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_rds_cluster: Fix Data API for serverlessv2 #38997

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 22, 2024

Description

The AWS documentation clarifies this detail, but it's not mentioned in the Go SDK documentation. There are two methods to enable the HTTP endpoint (Data API): a newer method and an older method. The newer method, which applies to both provisioned and serverlessv2 engine modes, involves using the EnableHTTPEndpoint and DisableHTTPEndpoint operations. The older method involves modifying the DB cluster and setting the EnableHttpEndpoint field. Before this pull request, we were only using the older method.

Relations

Closes terraform-aws-modules/terraform-aws-rds-aurora#464
Closes #37125

References

Output from Acceptance Testing

% make t T=TestAccRDSCluster_enableHTTPEndpoint K=rds            
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_enableHTTPEndpoint'  -timeout 360m
=== RUN   TestAccRDSCluster_enableHTTPEndpoint
=== PAUSE TestAccRDSCluster_enableHTTPEndpoint
=== RUN   TestAccRDSCluster_enableHTTPEndpointProvisioned
=== PAUSE TestAccRDSCluster_enableHTTPEndpointProvisioned
=== CONT  TestAccRDSCluster_enableHTTPEndpoint
=== CONT  TestAccRDSCluster_enableHTTPEndpointProvisioned
--- PASS: TestAccRDSCluster_enableHTTPEndpointProvisioned (274.08s)
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (354.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	359.909s

@YakDriver YakDriver requested a review from a team as a code owner August 22, 2024 16:55
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 22, 2024
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Aug 22, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YakDriver YakDriver merged commit 1bd56af into main Aug 22, 2024
51 checks passed
@YakDriver YakDriver deleted the b-rds-cluster-enable-http-endpoint branch August 22, 2024 17:36
@github-actions github-actions bot added this to the v5.64.0 milestone Aug 22, 2024
Copy link

This functionality has been released in v5.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 22, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants