Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_amplify_app: fix crash updating auto_branch_creation_config #39041

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 26, 2024

Description

The update operation was missing the appropriate checks to ensure nil values were not passed into the expander function.

Relations

Closes #29691

Output from Acceptance Testing

% make testacc PKG=amplify TESTS=TestAccAmplify_serial/App
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/amplify/... -v -count 1 -parallel 20 -run='TestAccAmplify_serial/App'  -timeout 360m

--- FAIL: TestAccAmplify_serial (7326.08s)
    --- FAIL: TestAccAmplify_serial/App (7326.08s)
        --- PASS: TestAccAmplify_serial/App/tags (5258.13s)
            --- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnCreate (292.74s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_providerOnly (311.60s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nonOverlapping (302.30s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nullOverlappingResourceTag (282.80s)
            --- PASS: TestAccAmplify_serial/App/tags/basic (310.23s)
            --- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnUpdate_Add (299.40s)
            --- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnUpdate_Replace (289.53s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_overlapping (303.28s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_updateToProviderOnly (290.14s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_emptyResourceTag (282.28s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nullNonOverlappingResourceTag (283.03s)
            --- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnCreate (293.87s)
            --- PASS: TestAccAmplify_serial/App/tags/null (284.63s)
            --- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnUpdate_Replace (292.53s)
            --- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnUpdate_Add (291.90s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_updateToResourceOnly (288.73s)
            --- PASS: TestAccAmplify_serial/App/tags/AddOnUpdate (289.13s)
        --- FAIL: TestAccAmplify_serial/App/AutoBranchCreationConfig (14.44s)
        --- FAIL: TestAccAmplify_serial/App/BasicAuthCredentials (6.04s)
        --- FAIL: TestAccAmplify_serial/App/EnvironmentVariables (19.97s)
        --- SKIP: TestAccAmplify_serial/App/Repository (0.00s)
        --- PASS: TestAccAmplify_serial/App/basic (280.71s)
        --- PASS: TestAccAmplify_serial/App/BuildSpec (292.99s)
        --- PASS: TestAccAmplify_serial/App/CustomRules (295.51s)
        --- PASS: TestAccAmplify_serial/App/Description (294.85s)
        --- PASS: TestAccAmplify_serial/App/IamServiceRole (296.00s)
        --- PASS: TestAccAmplify_serial/App/Name (287.57s)
        --- PASS: TestAccAmplify_serial/App/disappears (279.85s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/amplify    7332.066s

Test failures are pre-existing and present in CI, not a related to this change.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/amplify Issues and PRs that pertain to the amplify service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 26, 2024
The update operation was missing the appropriate checks to ensure nil values were not passed into the expander function.

```console
% make testacc PKG=amplify TESTS=TestAccAmplify_serial/App
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/amplify/... -v -count 1 -parallel 20 -run='TestAccAmplify_serial/App'  -timeout 360m

--- FAIL: TestAccAmplify_serial (7326.08s)
    --- FAIL: TestAccAmplify_serial/App (7326.08s)
        --- PASS: TestAccAmplify_serial/App/tags (5258.13s)
            --- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnCreate (292.74s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_providerOnly (311.60s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nonOverlapping (302.30s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nullOverlappingResourceTag (282.80s)
            --- PASS: TestAccAmplify_serial/App/tags/basic (310.23s)
            --- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnUpdate_Add (299.40s)
            --- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnUpdate_Replace (289.53s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_overlapping (303.28s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_updateToProviderOnly (290.14s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_emptyResourceTag (282.28s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nullNonOverlappingResourceTag (283.03s)
            --- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnCreate (293.87s)
            --- PASS: TestAccAmplify_serial/App/tags/null (284.63s)
            --- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnUpdate_Replace (292.53s)
            --- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnUpdate_Add (291.90s)
            --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_updateToResourceOnly (288.73s)
            --- PASS: TestAccAmplify_serial/App/tags/AddOnUpdate (289.13s)
        --- FAIL: TestAccAmplify_serial/App/AutoBranchCreationConfig (14.44s)
        --- FAIL: TestAccAmplify_serial/App/BasicAuthCredentials (6.04s)
        --- FAIL: TestAccAmplify_serial/App/EnvironmentVariables (19.97s)
        --- SKIP: TestAccAmplify_serial/App/Repository (0.00s)
        --- PASS: TestAccAmplify_serial/App/basic (280.71s)
        --- PASS: TestAccAmplify_serial/App/BuildSpec (292.99s)
        --- PASS: TestAccAmplify_serial/App/CustomRules (295.51s)
        --- PASS: TestAccAmplify_serial/App/Description (294.85s)
        --- PASS: TestAccAmplify_serial/App/IamServiceRole (296.00s)
        --- PASS: TestAccAmplify_serial/App/Name (287.57s)
        --- PASS: TestAccAmplify_serial/App/disappears (279.85s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/amplify    7332.066s
```

Test failures are pre-existing and present in CI, not a related to this change.
@jar-b jar-b added crash Results from or addresses a Terraform crash or kernel panic. bug Addresses a defect in current functionality. labels Aug 26, 2024
@jar-b jar-b marked this pull request as ready for review August 26, 2024 16:56
@jar-b jar-b requested a review from a team as a code owner August 26, 2024 16:56
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit d9702f7 into main Aug 26, 2024
50 checks passed
@jar-b jar-b deleted the b-amplify-crash branch August 26, 2024 19:59
@github-actions github-actions bot added this to the v5.65.0 milestone Aug 26, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Aug 26, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2024
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/amplify Issues and PRs that pertain to the amplify service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Modifying...Error: Plugin did not respond
2 participants