-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_amplify_app: fix crash updating auto_branch_creation_config
#39041
Conversation
Community NoteVoting for Prioritization
For Submitters
|
The update operation was missing the appropriate checks to ensure nil values were not passed into the expander function. ```console % make testacc PKG=amplify TESTS=TestAccAmplify_serial/App make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/amplify/... -v -count 1 -parallel 20 -run='TestAccAmplify_serial/App' -timeout 360m --- FAIL: TestAccAmplify_serial (7326.08s) --- FAIL: TestAccAmplify_serial/App (7326.08s) --- PASS: TestAccAmplify_serial/App/tags (5258.13s) --- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnCreate (292.74s) --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_providerOnly (311.60s) --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nonOverlapping (302.30s) --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nullOverlappingResourceTag (282.80s) --- PASS: TestAccAmplify_serial/App/tags/basic (310.23s) --- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnUpdate_Add (299.40s) --- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnUpdate_Replace (289.53s) --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_overlapping (303.28s) --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_updateToProviderOnly (290.14s) --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_emptyResourceTag (282.28s) --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nullNonOverlappingResourceTag (283.03s) --- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnCreate (293.87s) --- PASS: TestAccAmplify_serial/App/tags/null (284.63s) --- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnUpdate_Replace (292.53s) --- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnUpdate_Add (291.90s) --- PASS: TestAccAmplify_serial/App/tags/DefaultTags_updateToResourceOnly (288.73s) --- PASS: TestAccAmplify_serial/App/tags/AddOnUpdate (289.13s) --- FAIL: TestAccAmplify_serial/App/AutoBranchCreationConfig (14.44s) --- FAIL: TestAccAmplify_serial/App/BasicAuthCredentials (6.04s) --- FAIL: TestAccAmplify_serial/App/EnvironmentVariables (19.97s) --- SKIP: TestAccAmplify_serial/App/Repository (0.00s) --- PASS: TestAccAmplify_serial/App/basic (280.71s) --- PASS: TestAccAmplify_serial/App/BuildSpec (292.99s) --- PASS: TestAccAmplify_serial/App/CustomRules (295.51s) --- PASS: TestAccAmplify_serial/App/Description (294.85s) --- PASS: TestAccAmplify_serial/App/IamServiceRole (296.00s) --- PASS: TestAccAmplify_serial/App/Name (287.57s) --- PASS: TestAccAmplify_serial/App/disappears (279.85s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/amplify 7332.066s ``` Test failures are pre-existing and present in CI, not a related to this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The update operation was missing the appropriate checks to ensure nil values were not passed into the expander function.
Relations
Closes #29691
Output from Acceptance Testing
Test failures are pre-existing and present in CI, not a related to this change.