-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add notification_settings
to RolesAnywhere trust_anchor
#39108
feat: add notification_settings
to RolesAnywhere trust_anchor
#39108
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRolesAnywhere' PKG=rolesanywhere ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/rolesanywhere/... -v -count 1 -parallel 2 -run=TestAccRolesAnywhere -timeout 360m
=== RUN TestAccRolesAnywhereProfile_basic
=== PAUSE TestAccRolesAnywhereProfile_basic
=== RUN TestAccRolesAnywhereProfile_tags
=== PAUSE TestAccRolesAnywhereProfile_tags
=== RUN TestAccRolesAnywhereProfile_disappears
=== PAUSE TestAccRolesAnywhereProfile_disappears
=== RUN TestAccRolesAnywhereProfile_enabled
=== PAUSE TestAccRolesAnywhereProfile_enabled
=== RUN TestAccRolesAnywhereTrustAnchor_basic
=== PAUSE TestAccRolesAnywhereTrustAnchor_basic
=== RUN TestAccRolesAnywhereTrustAnchor_tags
=== PAUSE TestAccRolesAnywhereTrustAnchor_tags
=== RUN TestAccRolesAnywhereTrustAnchor_disappears
=== PAUSE TestAccRolesAnywhereTrustAnchor_disappears
=== RUN TestAccRolesAnywhereTrustAnchor_certificateBundle
=== PAUSE TestAccRolesAnywhereTrustAnchor_certificateBundle
=== RUN TestAccRolesAnywhereTrustAnchor_enabled
=== PAUSE TestAccRolesAnywhereTrustAnchor_enabled
=== CONT TestAccRolesAnywhereProfile_basic
=== CONT TestAccRolesAnywhereTrustAnchor_tags
--- PASS: TestAccRolesAnywhereProfile_basic (12.59s)
=== CONT TestAccRolesAnywhereProfile_enabled
--- PASS: TestAccRolesAnywhereTrustAnchor_tags (33.94s)
=== CONT TestAccRolesAnywhereTrustAnchor_basic
--- PASS: TestAccRolesAnywhereProfile_enabled (26.31s)
=== CONT TestAccRolesAnywhereProfile_disappears
--- PASS: TestAccRolesAnywhereProfile_disappears (9.95s)
=== CONT TestAccRolesAnywhereProfile_tags
--- PASS: TestAccRolesAnywhereTrustAnchor_basic (17.17s)
=== CONT TestAccRolesAnywhereTrustAnchor_certificateBundle
--- PASS: TestAccRolesAnywhereTrustAnchor_certificateBundle (11.12s)
=== CONT TestAccRolesAnywhereTrustAnchor_enabled
--- PASS: TestAccRolesAnywhereProfile_tags (28.17s)
=== CONT TestAccRolesAnywhereTrustAnchor_disappears
--- PASS: TestAccRolesAnywhereTrustAnchor_enabled (25.16s)
--- PASS: TestAccRolesAnywhereTrustAnchor_disappears (15.24s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rolesanywhere 97.502s
@DanielRieske Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the
notification_settings
attributes toaws_rolesanywhere_trust_anchor
and a general cleanup of the service.Notification settings has some unique behavior that the reviewer needs to be aware of
event
argument within the API default will be overwritten.This means that the field needs to be
computed
,forceNew
& differences for the computed arguments need to be suppressed so it does not trigger a force recreation.Also fixed a bug within
aws_rolesanywhere_profile
that whileroles_arns
is required an empty list is an acceptable value for the API. Made the argument optional and used our flex functions to create an empty list if unset.Relations
Closes #37532
Closes #39102
References
Output from Acceptance Testing