Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: use step function validation API in planning #39150

Closed
briantist opened this issue Sep 4, 2024 · 4 comments · Fixed by #39229
Closed

[Enhancement]: use step function validation API in planning #39150

briantist opened this issue Sep 4, 2024 · 4 comments · Fixed by #39229
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service.
Milestone

Comments

@briantist
Copy link

briantist commented Sep 4, 2024

Description

Now that there's a validation API for workflow definitions, it would be great if they were validated on plans so we could find errors sooner.

It could be possible to have an option to not validate which would reduce API calls and potentially perform better, but it seems like validation should be the default/expected behavior now that it's available.

Affected Resource(s) and/or Data Source(s)

  • aws_sfn_state_machine

Potential Terraform Configuration

Should "just work" without needing to change TF configuration.

References

No response

Would you like to implement a fix?

No

@briantist briantist added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/sfn Issues and PRs that pertain to the sfn service. needs-triage Waiting for first response or review from a maintainer. labels Sep 4, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Sep 5, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.67.0 milestone Sep 11, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service.
Projects
None yet
2 participants