Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Resource]: aws_lambda_function_recursion_config #39153

Merged
merged 16 commits into from
Sep 9, 2024
Merged

[New Resource]: aws_lambda_function_recursion_config #39153

merged 16 commits into from
Sep 9, 2024
+564 −0

Conversation

coderaycer
Copy link
Contributor

Description

This resource would allow practitioners to manage AWS Lambda function recursion configurations via Terraform.

Relations

Closes #38949

References

https://docs.aws.amazon.com/lambda/latest/api/API_PutFunctionRecursionConfig.html
https://docs.aws.amazon.com/lambda/latest/api/API_GetFunctionRecursionConfig.html

Output from Acceptance Testing

make testacc TESTS=TestAccLambdaRecursionConfig_ PKG=lambda
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaRecursionConfig_'  -timeout 360m
=== RUN   TestAccLambdaRecursionConfig_basic
=== PAUSE TestAccLambdaRecursionConfig_basic
=== RUN   TestAccLambdaRecursionConfig_update
=== PAUSE TestAccLambdaRecursionConfig_update
=== RUN   TestAccLambdaRecursionConfig_disappears
=== PAUSE TestAccLambdaRecursionConfig_disappears
=== CONT  TestAccLambdaRecursionConfig_basic
=== CONT  TestAccLambdaRecursionConfig_update
=== CONT  TestAccLambdaRecursionConfig_disappears
--- PASS: TestAccLambdaRecursionConfig_disappears (69.87s)
--- PASS: TestAccLambdaRecursionConfig_basic (81.14s)
--- PASS: TestAccLambdaRecursionConfig_update (98.18s)
PASS
ok

@coderaycer coderaycer requested a review from a team as a code owner September 4, 2024 21:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. labels Sep 4, 2024
@coderaycer coderaycer changed the title WIP [New Resource]: aws_lambda_function_recursion_config [New Resource]: aws_lambda_function_recursion_config Sep 4, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Sep 5, 2024
@jar-b
Merge branch 'main' into f-lambda-function-recursion-config
aefd919
@jar-b
r/aws_lambda_function_recursion_config: update resource name
cae1582 
```console
% make testacc PKG=lambda TESTS="TestAccLambdaFunctionRecursionConfig_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunctionRecursionConfig_'  -timeout 360m

--- PASS: TestAccLambdaFunctionRecursionConfig_basic (30.45s)
--- PASS: TestAccLambdaFunctionRecursionConfig_disappears (34.05s)
--- PASS: TestAccLambdaFunctionRecursionConfig_update (51.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     58.061s
```
@jar-b
chore: update changelog
c25c483
@jar-b
r/aws_lambda_function_recursion_config: remove waiters, timeouts
d94990d
@jar-b
r/aws_lambda_function_recursion_config: remove id attribute
9f6391f 
```console
% make testacc PKG=lambda TESTS="TestAccLambdaFunctionRecursionConfig_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunctionRecursionConfig_'  -timeout 360m

--- PASS: TestAccLambdaFunctionRecursionConfig_basic (30.09s)
--- PASS: TestAccLambdaFunctionRecursionConfig_disappears_Function (39.74s)
--- PASS: TestAccLambdaFunctionRecursionConfig_update (45.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     51.282s
```
jar-b
jar-b approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=lambda TESTS="TestAccLambdaFunctionRecursionConfig_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunctionRecursionConfig_'  -timeout 360m
=== RUN   TestAccLambdaFunctionRecursionConfig_basic
=== PAUSE TestAccLambdaFunctionRecursionConfig_basic
=== RUN   TestAccLambdaFunctionRecursionConfig_update
=== PAUSE TestAccLambdaFunctionRecursionConfig_update
=== RUN   TestAccLambdaFunctionRecursionConfig_disappears_Function
=== PAUSE TestAccLambdaFunctionRecursionConfig_disappears_Function
=== CONT  TestAccLambdaFunctionRecursionConfig_basic
=== CONT  TestAccLambdaFunctionRecursionConfig_disappears_Function
=== CONT  TestAccLambdaFunctionRecursionConfig_update
--- PASS: TestAccLambdaFunctionRecursionConfig_basic (30.09s)
--- PASS: TestAccLambdaFunctionRecursionConfig_disappears_Function (39.74s)
--- PASS: TestAccLambdaFunctionRecursionConfig_update (45.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     51.282s

@jar-b
Copy link
Member

jar-b commented Sep 9, 2024

Thanks for your contribution, @coderaycer! 👍

@jar-b jar-b merged commit b193a6a into hashicorp:main Sep 9, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 9, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.67.0
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_lambda_function_recursion_config
2 participants
@coderaycer @jar-b