r/aws_iam_role_policies_exclusive: new resource #39203
Merged
+703
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
jar-b
force-pushed
the
f-iam_role_policies_lock
branch
from
3d83aa1
to
8efde91
Compare
jar-b
force-pushed
the
f-iam_role_policies_lock
branch
2 times, most recently
from
12adef9
to
d43f0d7
Compare
This resource will enable exclusive management of inline policy assignments to an IAM role. This functions similar to the `inline_policy` blocks when defined on the `aws_iam_role` resource, but as a standalone resource. ```console % make testacc PKG=iam TESTS=TestAccIAMRolePoliciesExclusive_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.0 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMRolePoliciesExclusive_' -timeout 360m --- PASS: TestAccIAMRolePoliciesExclusive_empty (13.72s) --- PASS: TestAccIAMRolePoliciesExclusive_disappears_Role (13.72s) --- PASS: TestAccIAMRolePoliciesExclusive_basic (15.84s) --- PASS: TestAccIAMRolePoliciesExclusive_multiple (24.25s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 30.454s ```
jar-b
force-pushed
the
f-iam_role_policies_lock
branch
from
d43f0d7
to
7bb1c2b
Compare
With the introduction of the `aws_iam_role_policies_exclusive` resource, the provider now has parity with the behavior of the existing `inline_policy` argument. To encourage a single pattern for managing inline policy associations, the inline argument on the role resource is now deprecated. Due to this resources popularity it is undetermined whether the argument will be fully removed in a future major version, but the deprecation warning allows maintainers to direct users to a preferred pattern.
jar-b
force-pushed
the
f-iam_role_policies_lock
branch
from
7bb1c2b
to
322dbf3
Compare
YakDriver
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
I'd add more tests and not use "lock." Otherwise, looks good!
% make t T=TestAccIAMRolePoliciesExclusive_ K=iam
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMRolePoliciesExclusive_' -timeout 360m
=== RUN TestAccIAMRolePoliciesExclusive_basic
=== PAUSE TestAccIAMRolePoliciesExclusive_basic
=== RUN TestAccIAMRolePoliciesExclusive_disappears_Role
=== PAUSE TestAccIAMRolePoliciesExclusive_disappears_Role
=== RUN TestAccIAMRolePoliciesExclusive_multiple
=== PAUSE TestAccIAMRolePoliciesExclusive_multiple
=== RUN TestAccIAMRolePoliciesExclusive_empty
=== PAUSE TestAccIAMRolePoliciesExclusive_empty
=== CONT TestAccIAMRolePoliciesExclusive_basic
=== CONT TestAccIAMRolePoliciesExclusive_multiple
=== CONT TestAccIAMRolePoliciesExclusive_empty
=== CONT TestAccIAMRolePoliciesExclusive_disappears_Role
--- PASS: TestAccIAMRolePoliciesExclusive_disappears_Role (17.93s)
--- PASS: TestAccIAMRolePoliciesExclusive_empty (18.03s)
--- PASS: TestAccIAMRolePoliciesExclusive_basic (19.61s)
--- PASS: TestAccIAMRolePoliciesExclusive_multiple (30.24s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 35.400sAdds tests to cover out of band additions and removals of inline policies. ```console % make testacc PKG=iam TESTS=TestAccIAMRolePoliciesExclusive_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMRolePoliciesExclusive_' -timeout 360m --- PASS: TestAccIAMRolePoliciesExclusive_empty (15.28s) --- PASS: TestAccIAMRolePoliciesExclusive_disappears_Role (15.33s) --- PASS: TestAccIAMRolePoliciesExclusive_basic (17.58s) --- PASS: TestAccIAMRolePoliciesExclusive_outOfBandAddition (24.33s) --- PASS: TestAccIAMRolePoliciesExclusive_outOfBandRemoval (24.34s) --- PASS: TestAccIAMRolePoliciesExclusive_multiple (26.37s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 32.643s ```
13 tasks
github-actions
bot
removed
the
prioritized
|
This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This was referenced Sep 20, 2024
Closed
This was referenced Sep 26, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resource will enable exclusive management of inline policy assignments to an IAM role. This functions similar to the
inline_policyblocks when defined on theaws_iam_roleresource, but as a standalone resource.Relations
Relates #22336
Relates #39204
References
Output from Acceptance Testing