Add hsm2m.medium as valid type for hsm_type on aws_cloudhsm_v2_cluster

[prestonprice57]

Description

Add hsm2m.medium as a valid hsm_type on aws_cloudhsm_v2_cluster. This new type has recently been released by Amazon.
Add mode as a property on aws_cloudhsm_v2_cluster. This property is required if hsm_type=hsm2m.medium

Relations

Closes 39018

References

AWS Blog announcement
AWS Docs

Output from Acceptance Testing

make testacc TESTS=TestAccCloudHSMV2 PKG=cloudhsmv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/cloudhsmv2/... -v -count 1 -parallel 20 -run='TestAccCloudHSMV2'  -timeout 360m
=== RUN   TestAccCloudHSMV2_serial
=== PAUSE TestAccCloudHSMV2_serial
=== CONT  TestAccCloudHSMV2_serial
=== RUN   TestAccCloudHSMV2_serial/Cluster
=== RUN   TestAccCloudHSMV2_serial/Cluster/basic
=== RUN   TestAccCloudHSMV2_serial/Cluster/disappears
=== RUN   TestAccCloudHSMV2_serial/Cluster/tags
=== RUN   TestAccCloudHSMV2_serial/Cluster/hsmType
=== RUN   TestAccCloudHSMV2_serial/Hsm
=== RUN   TestAccCloudHSMV2_serial/Hsm/availabilityZone
=== RUN   TestAccCloudHSMV2_serial/Hsm/basic
=== RUN   TestAccCloudHSMV2_serial/Hsm/disappears
=== RUN   TestAccCloudHSMV2_serial/Hsm/ipAddress
=== RUN   TestAccCloudHSMV2_serial/DataSource
=== RUN   TestAccCloudHSMV2_serial/DataSource/basic
--- PASS: TestAccCloudHSMV2_serial (5083.50s)
    --- PASS: TestAccCloudHSMV2_serial/Cluster (866.97s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/basic (242.38s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/disappears (265.64s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/tags (268.54s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/hsmType (90.39s)
    --- PASS: TestAccCloudHSMV2_serial/Hsm (3981.76s)
        --- PASS: TestAccCloudHSMV2_serial/Hsm/availabilityZone (1017.99s)
        --- PASS: TestAccCloudHSMV2_serial/Hsm/basic (1016.96s)
        --- PASS: TestAccCloudHSMV2_serial/Hsm/disappears (1003.89s)
        --- PASS: TestAccCloudHSMV2_serial/Hsm/ipAddress (942.91s)
    --- PASS: TestAccCloudHSMV2_serial/DataSource (234.78s)
        --- PASS: TestAccCloudHSMV2_serial/DataSource/basic (234.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2	5092.937s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[github-actions]

Welcome @prestonprice57 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccCloudHSMV2_serial/Cluster' PKG=cloudhsmv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/cloudhsmv2/... -v -count 1 -parallel 20  -run=TestAccCloudHSMV2_serial/Cluster -timeout 720m
=== RUN   TestAccCloudHSMV2_serial
=== PAUSE TestAccCloudHSMV2_serial
=== CONT  TestAccCloudHSMV2_serial
=== RUN   TestAccCloudHSMV2_serial/Cluster
=== RUN   TestAccCloudHSMV2_serial/Cluster/basic
=== RUN   TestAccCloudHSMV2_serial/Cluster/disappears
=== RUN   TestAccCloudHSMV2_serial/Cluster/tags
=== RUN   TestAccCloudHSMV2_serial/Cluster/hsmType
--- PASS: TestAccCloudHSMV2_serial (842.01s)
    --- PASS: TestAccCloudHSMV2_serial/Cluster (842.01s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/basic (234.07s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/disappears (262.04s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/tags (264.53s)
        --- PASS: TestAccCloudHSMV2_serial/Cluster/hsmType (81.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2	847.092s

[ewbankkit]

@prestonprice57 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!