fix: Fix check_certificate_revocation_status block being ignored due to autoflex issue for aws_networkfirewall_tls_inspection_configuration

[acwwat]

Description

This PR is to fix an issue with the aws_networkfirewall_tls_inspection_configuration resource where the check_certificate_revovation_status block is ignored by resource creation because of a typo in the model field name (extra 's' in the name) that caused autoflex to skip it. As a result, the certificate revocation status settings are not applied.

The test case TestAccNetworkFirewallTLSInspectionConfiguration_checkCertificateRevocationStatus is also passing so that gives a false positive. After fixing the autoflex issue, the test case fails because the TF configuration is also incorrect. This issue is also fixed with the PR.

Relations

Closes #38690

References

Referred to CreateTLSInspectionConfiguration for specs.

Output from Acceptance Testing

$ make testacc TESTS=TestAccNetworkFirewallTLSInspectionConfiguration_ PKG=networkfirewall
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallTLSInspectionConfiguration_'  -timeout 360m
=== RUN   TestAccNetworkFirewallTLSInspectionConfiguration_basic
=== PAUSE TestAccNetworkFirewallTLSInspectionConfiguration_basic
=== RUN   TestAccNetworkFirewallTLSInspectionConfiguration_disappears
=== PAUSE TestAccNetworkFirewallTLSInspectionConfiguration_disappears
=== RUN   TestAccNetworkFirewallTLSInspectionConfiguration_tags
=== PAUSE TestAccNetworkFirewallTLSInspectionConfiguration_tags
=== RUN   TestAccNetworkFirewallTLSInspectionConfiguration_encryptionConfiguration
=== PAUSE TestAccNetworkFirewallTLSInspectionConfiguration_encryptionConfiguration
=== RUN   TestAccNetworkFirewallTLSInspectionConfiguration_checkCertificateRevocationStatus
=== PAUSE TestAccNetworkFirewallTLSInspectionConfiguration_checkCertificateRevocationStatus
=== CONT  TestAccNetworkFirewallTLSInspectionConfiguration_basic
=== CONT  TestAccNetworkFirewallTLSInspectionConfiguration_encryptionConfiguration
=== CONT  TestAccNetworkFirewallTLSInspectionConfiguration_tags
=== CONT  TestAccNetworkFirewallTLSInspectionConfiguration_checkCertificateRevocationStatus
=== CONT  TestAccNetworkFirewallTLSInspectionConfiguration_disappears
--- PASS: TestAccNetworkFirewallTLSInspectionConfiguration_tags (161.77s)
--- PASS: TestAccNetworkFirewallTLSInspectionConfiguration_encryptionConfiguration (164.64s)
--- PASS: TestAccNetworkFirewallTLSInspectionConfiguration_basic (166.39s)
--- PASS: TestAccNetworkFirewallTLSInspectionConfiguration_disappears (190.89s)
--- PASS: TestAccNetworkFirewallTLSInspectionConfiguration_checkCertificateRevocationStatus (200.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall    200.553s

$

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkFirewallTLSInspectionConfiguration_' PKG=networkfirewall ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/networkfirewall/... -v -count 1 -parallel 3  -run=TestAccNetworkFirewallTLSInspectionConfiguration_ -timeout 360m
=== RUN   TestAccNetworkFirewallTLSInspectionConfiguration_basic
=== PAUSE TestAccNetworkFirewallTLSInspectionConfiguration_basic
=== RUN   TestAccNetworkFirewallTLSInspectionConfiguration_disappears
=== PAUSE TestAccNetworkFirewallTLSInspectionConfiguration_disappears
=== RUN   TestAccNetworkFirewallTLSInspectionConfiguration_tags
=== PAUSE TestAccNetworkFirewallTLSInspectionConfiguration_tags
=== RUN   TestAccNetworkFirewallTLSInspectionConfiguration_encryptionConfiguration
=== PAUSE TestAccNetworkFirewallTLSInspectionConfiguration_encryptionConfiguration
=== RUN   TestAccNetworkFirewallTLSInspectionConfiguration_checkCertificateRevocationStatus
=== PAUSE TestAccNetworkFirewallTLSInspectionConfiguration_checkCertificateRevocationStatus
=== CONT  TestAccNetworkFirewallTLSInspectionConfiguration_basic
=== CONT  TestAccNetworkFirewallTLSInspectionConfiguration_encryptionConfiguration
=== CONT  TestAccNetworkFirewallTLSInspectionConfiguration_tags
--- PASS: TestAccNetworkFirewallTLSInspectionConfiguration_basic (176.10s)
=== CONT  TestAccNetworkFirewallTLSInspectionConfiguration_disappears
--- PASS: TestAccNetworkFirewallTLSInspectionConfiguration_tags (178.23s)
=== CONT  TestAccNetworkFirewallTLSInspectionConfiguration_checkCertificateRevocationStatus
--- PASS: TestAccNetworkFirewallTLSInspectionConfiguration_encryptionConfiguration (178.79s)
--- PASS: TestAccNetworkFirewallTLSInspectionConfiguration_disappears (175.00s)
--- PASS: TestAccNetworkFirewallTLSInspectionConfiguration_checkCertificateRevocationStatus (198.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	381.644s

[ewbankkit]

@acwwat Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.