-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cache_config arg for aws_amplify_app #39215
feat: Add cache_config arg for aws_amplify_app #39215
Conversation
Community NoteVoting for Prioritization
For Submitters
|
0c5fe85
to
c14a762
Compare
c14a762
to
4a0817f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=amplify TESTS=TestAccAmplify_serial/App
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/amplify/... -v -count 1 -parallel 20 -run='TestAccAmplify_serial/App' -timeout 360m
=== RUN TestAccAmplify_serial
=== PAUSE TestAccAmplify_serial
=== CONT TestAccAmplify_serial
=== RUN TestAccAmplify_serial/App
=== RUN TestAccAmplify_serial/App/Description
=== RUN TestAccAmplify_serial/App/EnvironmentVariables
app_test.go:427: Step 4/4 error: Error running apply: exit status 1
Error: updating Amplify App (d2rf7akle3rllz): operation error Amplify: UpdateApp, https response error StatusCode: 400, RequestID: 8f1429d1-9a62-4464-b4e3-14369e5c0e67, BadRequestException: Environment variables cannot have an empty key.
with aws_amplify_app.test,
on terraform_plugin_test.tf line 12, in resource "aws_amplify_app" "test":
12: resource "aws_amplify_app" "test" {
=== RUN TestAccAmplify_serial/App/Name
=== RUN TestAccAmplify_serial/App/disappears
=== RUN TestAccAmplify_serial/App/tags
=== RUN TestAccAmplify_serial/App/tags/basic
=== RUN TestAccAmplify_serial/App/tags/null
=== RUN TestAccAmplify_serial/App/tags/EmptyTag_OnUpdate_Add
=== RUN TestAccAmplify_serial/App/tags/DefaultTags_updateToResourceOnly
=== RUN TestAccAmplify_serial/App/tags/ComputedTag_OnUpdate_Replace
=== RUN TestAccAmplify_serial/App/tags/AddOnUpdate
=== RUN TestAccAmplify_serial/App/tags/EmptyTag_OnCreate
=== RUN TestAccAmplify_serial/App/tags/EmptyTag_OnUpdate_Replace
=== RUN TestAccAmplify_serial/App/tags/DefaultTags_updateToProviderOnly
=== RUN TestAccAmplify_serial/App/tags/DefaultTags_nonOverlapping
=== RUN TestAccAmplify_serial/App/tags/DefaultTags_emptyResourceTag
=== RUN TestAccAmplify_serial/App/tags/ComputedTag_OnCreate
=== RUN TestAccAmplify_serial/App/tags/DefaultTags_providerOnly
=== RUN TestAccAmplify_serial/App/tags/DefaultTags_overlapping
=== RUN TestAccAmplify_serial/App/tags/DefaultTags_nullOverlappingResourceTag
=== RUN TestAccAmplify_serial/App/tags/DefaultTags_nullNonOverlappingResourceTag
=== RUN TestAccAmplify_serial/App/tags/ComputedTag_OnUpdate_Add
=== RUN TestAccAmplify_serial/App/BasicAuthCredentials
app_test.go:206: Step 1/4 error: Check failed: Check 2/3 error: aws_amplify_app.test: Attribute 'basic_auth_credentials' expected "dXNlcm5hbWUxOnBhc3N3b3JkMQ==", got "dXNlcm5hbWUxOlRZTFpncVYrM1NpVlZFak5LeWxFQmc9PXx8dVF3WnlpalhOL2xNaWVYQUVCVnVGNkJKWFhPOGFRaFBBVnlBa2MwL1IwTT0="
=== RUN TestAccAmplify_serial/App/CacheConfig
=== RUN TestAccAmplify_serial/App/CustomRules
=== RUN TestAccAmplify_serial/App/IamServiceRole
=== RUN TestAccAmplify_serial/App/Repository
app_test.go:552: Environment variable AMPLIFY_GITHUB_ACCESS_TOKEN is not set
=== RUN TestAccAmplify_serial/App/basic
=== RUN TestAccAmplify_serial/App/AutoBranchCreationConfig
app_test.go:109: Step 2/5 error: Check failed: Check 3/16 error: aws_amplify_app.test: Attribute 'auto_branch_creation_config.0.basic_auth_credentials' expected "dXNlcm5hbWUxOnBhc3N3b3JkMQ==", got "dXNlcm5hbWUxOm5kb2YwbGNzczFjV0FMMytVRlBZQXc9PXx8bmd5UTFuUlRSRTYrM2k0NjJUS1VaVTBzNS93ODhGS0llTzE1bjV6Vm9JND0="
=== RUN TestAccAmplify_serial/App/BuildSpec
--- FAIL: TestAccAmplify_serial (7740.87s)
--- FAIL: TestAccAmplify_serial/App (7740.87s)
--- PASS: TestAccAmplify_serial/App/Description (300.52s)
--- FAIL: TestAccAmplify_serial/App/EnvironmentVariables (24.48s)
--- PASS: TestAccAmplify_serial/App/Name (291.11s)
--- PASS: TestAccAmplify_serial/App/disappears (281.79s)
--- PASS: TestAccAmplify_serial/App/tags (5340.11s)
--- PASS: TestAccAmplify_serial/App/tags/basic (320.35s)
--- PASS: TestAccAmplify_serial/App/tags/null (288.57s)
--- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnUpdate_Add (306.19s)
--- PASS: TestAccAmplify_serial/App/tags/DefaultTags_updateToResourceOnly (293.07s)
--- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnUpdate_Replace (297.27s)
--- PASS: TestAccAmplify_serial/App/tags/AddOnUpdate (295.27s)
--- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnCreate (296.85s)
--- PASS: TestAccAmplify_serial/App/tags/EmptyTag_OnUpdate_Replace (294.10s)
--- PASS: TestAccAmplify_serial/App/tags/DefaultTags_updateToProviderOnly (294.74s)
--- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nonOverlapping (309.30s)
--- PASS: TestAccAmplify_serial/App/tags/DefaultTags_emptyResourceTag (285.42s)
--- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnCreate (288.05s)
--- PASS: TestAccAmplify_serial/App/tags/DefaultTags_providerOnly (322.09s)
--- PASS: TestAccAmplify_serial/App/tags/DefaultTags_overlapping (310.30s)
--- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nullOverlappingResourceTag (285.66s)
--- PASS: TestAccAmplify_serial/App/tags/DefaultTags_nullNonOverlappingResourceTag (285.43s)
--- PASS: TestAccAmplify_serial/App/tags/ComputedTag_OnUpdate_Add (297.45s)
--- FAIL: TestAccAmplify_serial/App/BasicAuthCredentials (9.51s)
--- PASS: TestAccAmplify_serial/App/CacheConfig (292.53s)
--- PASS: TestAccAmplify_serial/App/CustomRules (301.33s)
--- PASS: TestAccAmplify_serial/App/IamServiceRole (301.12s)
--- SKIP: TestAccAmplify_serial/App/Repository (0.00s)
--- PASS: TestAccAmplify_serial/App/basic (283.92s)
--- FAIL: TestAccAmplify_serial/App/AutoBranchCreationConfig (16.19s)
--- PASS: TestAccAmplify_serial/App/BuildSpec (298.27s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/amplify 7747.018s
Failures are pre-existing and not related to this change.
Thanks for your contribution, @acwwat! 👍 |
This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the
cache_config
configuration block argument to theaws_amplify_app
resource.Relations
Closes #38864
References
Referred to CreateApp for specs and wordings.
Output from Acceptance Testing